Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99789C6FD19 for ; Thu, 16 Mar 2023 19:27:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B47D685E03; Thu, 16 Mar 2023 20:27:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ROzdrW1s"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AA93785CA2; Thu, 16 Mar 2023 20:27:06 +0100 (CET) Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5288685A4D for ; Thu, 16 Mar 2023 20:27:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf35.google.com with SMTP id x8so1958880qvr.9 for ; Thu, 16 Mar 2023 12:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1678994820; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/HIg6tItKNMQNT53YOUMl7CZjdPPl6hysngkOe2eq+U=; b=ROzdrW1sxM7ao+HlIw9KSsImOwIWziFkl/aQIq3ghU6SQ8siY32GXyPeHrx1ErS8kp GTeh1/ylLronKD/XPKvzRoGJ4/YCzZlXO2vE2w7wG62JaT+7LaQi+m4Fb8w28uEkBet1 Ew84LZyDXYXqEyfMfRPL+7MVJlhyoAri4jpLY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678994820; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/HIg6tItKNMQNT53YOUMl7CZjdPPl6hysngkOe2eq+U=; b=PwzyAfHROooz6cPBpo1i/SGsEOI4y/tBcyUFnl/BGFixlg1jNbWGx/SBgAZ5tPs9Ca nAnL3ZxXBTlMDQWZlNOSmTmykn6Nm0dny2w6z3Jv7w1yZIGiSgcwIYS96BY8zC8Cheq+ zn9iaHkmtmWZxjeo3g7ScWkGBIQNPZSZBZxanClHsOc3A9BqQEbR1MnD4EVvBu3jaQhy kQ1AsJXdFz++bWlKlaDXMtq1TLUY5jMrenWePU/3rZt2QlccSCBneUhH1GK/0jS7jQb/ kyc7K6hD/nRO4AvouBtCXMclmsC5chlDJxQpEN1w4/CRTAfTNlQ1sbZExzjPc3viue8V Msig== X-Gm-Message-State: AO0yUKU3eWymL4ey3ndNl7hIkdoEzyL2qzbakJbdTG2D520KZJYwGSGb VFyqcbf70tcQsSER6tSBvmjLcDb1jOJ/w69odqqAsQ== X-Google-Smtp-Source: AK7set/7f98ve0duTjgJHrGSHJWEJ5zFuv2zA6HopV72r2tzcSv6UtiiYG1ar6T+Pe7MrAa1+hHc6w== X-Received: by 2002:ad4:5ae3:0:b0:56f:fb19:1650 with SMTP id c3-20020ad45ae3000000b0056ffb191650mr38650307qvh.2.1678994820087; Thu, 16 Mar 2023 12:27:00 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-1b74-53e3-8162-4fca.res6.spectrum.com. [2603:6081:7b00:6400:1b74:53e3:8162:4fca]) by smtp.gmail.com with ESMTPSA id j68-20020a37b947000000b0074577e835f2sm150833qkf.48.2023.03.16.12.26.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 12:26:59 -0700 (PDT) Date: Thu, 16 Mar 2023 15:26:58 -0400 From: Tom Rini To: Simon Glass Cc: u-boot@lists.denx.de Subject: Re: [PATCH] Revert 9f62a472dfb2 ("video: Remove duplicate cursor-positioning function") Message-ID: <20230316192658.GT54321@bill-the-cat> References: <20230315160136.2087793-1-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iRMLbGoRULjE9PQh" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --iRMLbGoRULjE9PQh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 15, 2023 at 10:23:34AM -0600, Simon Glass wrote: > On Wed, 15 Mar 2023 at 10:01, Tom Rini wrote: > > > > This reverts commit 9f62a472dfb26ec14408a27938ddd2a25700009d. > > > > The changes here aren't quite right, and on platforms such as Raspberry > > Pi where we can have both serial and video output, the change above > > causes output to change. This can be seen as the hush tests we have now > > fail. > > > > Signed-off-by: Tom Rini > > --- > > Cc: Simon Glass > > > > Some other issues in my lab meant I thought I had tested this platform > > when I took the PR in originally, but hadn't. So I'd like to grab this > > ASAP. > > --- > > drivers/video/vidconsole-uclass.c | 44 ++++++++++++++++++++++++------- > > 1 file changed, 34 insertions(+), 10 deletions(-) > > >=20 > Reviewed-by: Simon Glass Applied to u-boot/next, thanks! --=20 Tom --iRMLbGoRULjE9PQh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQTbYEACgkQFHw5/5Y0 tyyb6wv/fVV8wWDibjiM8nLBzli6RdeWMCvIpUKclJX21RMvRvJrGCvzy47/5RKk +c0Sek4eQopz3w4PRNygM7RalIHDg80CDLo41MXW5jtUYyhXhsDyQvJ1X0SPaiwY 8UZLLfwOGkrx8kGr120coUX9ne9B8PAfgn+VDHkztcNpdSlLByiB2HhH8bcMNdUY ASxjPnnDiRVtvAgLt5QEtwCB+9RZKlkOAMHSgc8jupUuqW7aKAjKTJez049EU2W0 JvjkOADt4OW4GIqqwZUnovw5rLmMul81k6qQ8uWhPe3mZpLb6+aJxxBS7mkURD6x qNuVl8DKKScRJKDYjeSnFE3nZUrqB2zdGiv2XKi+acXcEA6lwbgUQUx7v6QpKyGb cIbD0JHvRtFb9u9Jz2OjOHeBUxwIdLJTypLeXuxIS4IFinTmRaMx5ljMoOSzbkk2 ylb2RESDQllTjsQOhnD2eG3F4phnLjcac841+GBCEY0itrlMUO0UcctgXv0m17/s qolNqaa/ =B8FK -----END PGP SIGNATURE----- --iRMLbGoRULjE9PQh--