Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B087C74A5B for ; Fri, 24 Mar 2023 02:25:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3EAE58445C; Fri, 24 Mar 2023 03:25:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="MUtUUq0g"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8E73F85664; Fri, 24 Mar 2023 03:25:06 +0100 (CET) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C82588445C for ; Fri, 24 Mar 2023 03:25:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x834.google.com with SMTP id bz27so341907qtb.1 for ; Thu, 23 Mar 2023 19:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1679624702; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rKeQ/qdHT+U40DP5APqKJ4Rq3Xlx8MtkASks4csUY8A=; b=MUtUUq0gvZ5/yAcTQxv0ZeNWw+Q1QnyI6PNDGvD8+YLaeX6keZj+WwqLbVhyh6W3KE wzGvUzyQw0X2NmtYfP7SaQ/x7Mf2Zxm0ccBarn+y6/L6Kxtj8wsrt7L72k2T09XyFT1b iGXmknymzXaYRvAIHZPaX6zZvJ+t0r440oRoM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679624702; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rKeQ/qdHT+U40DP5APqKJ4Rq3Xlx8MtkASks4csUY8A=; b=TF8OtPK2xPEGWg0aAgS3CnUjaV+WugoNdAWD3Wof7EpMSYmGJY/BET0iAJhJAA8GuW axygKWPJaMsFFJ2ou3xQf//otHD/Ir7/H87hBi6tjg4fZql5tzxJoxUpNZJUNPkDEuLc YUF36UOe4chw6/7ZlPl2bl5wEJW1U62yOOTtvzzYGkiv/OQ8R7dn7vwhiN+FXObydFzc IRXque598ySIJ5kayvmmuiBtXBB+y4RB5Yt8qwkzUS/HCmZIUg/HSg99B+3Tjs0v0rxI hYefunNMbgrtvGq7prD3RVyRyswRgkXjrv4BnDaPeeoSJwGSgHk86gB/FuQ65x2Zfc8P Z/jA== X-Gm-Message-State: AO0yUKU7giXqGDI6cNoLZ+yEapRZOnlhS69MSMQFUPG6oMU7erNPi6Np uVGOXvqdEtnzu6izPbeNERn62A== X-Google-Smtp-Source: AK7set/g2cPUUrRUwYA06rAcd2hRcZjC1FSc20pmSrCI/ml+2libbSP/7+IsvpJ1tqt4YCBZxIEVIA== X-Received: by 2002:ac8:5d94:0:b0:3b6:9c63:5ca1 with SMTP id d20-20020ac85d94000000b003b69c635ca1mr3018010qtx.43.1679624702465; Thu, 23 Mar 2023 19:25:02 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-ef17-d9dc-8ac6-ade4.res6.spectrum.com. [2603:6081:7b00:6400:ef17:d9dc:8ac6:ade4]) by smtp.gmail.com with ESMTPSA id j13-20020a37ef0d000000b00729b7d71ac7sm13859113qkk.33.2023.03.23.19.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 19:25:01 -0700 (PDT) Date: Thu, 23 Mar 2023 22:24:59 -0400 From: Tom Rini To: Adam Ford Cc: u-boot@lists.denx.de, aford@beaconembedded.com, Stefano Babic , Fabio Estevam , "NXP i.MX U-Boot Team" Subject: Re: [PATCH V4] arm64: imx: Add support for imx8mp-beacon-kit Message-ID: <20230324022459.GI8135@bill-the-cat> References: <20230324002705.123088-1-aford173@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XG4djXZIymYfA05W" Content-Disposition: inline In-Reply-To: <20230324002705.123088-1-aford173@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --XG4djXZIymYfA05W Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 23, 2023 at 07:27:04PM -0500, Adam Ford wrote: > Beacon Embedded has an i.MX8M Plus development kit which consists > of a SOM + baseboard. The SOM includes Bluetooth, WiFi, QSPI, eMMC, > and one Ethernet PHY. The baseboard includes audio, HDMI, USB-C Dual > Role port, USB Hub with five ports, a PCIe slot, and a second Ethernet > PHY. The device trees are already queued for inclusion in Linux 6.3. >=20 > Signed-off-by: Adam Ford > Reviewed-by: Tom Rini > --- >=20 > V4: Rebase off Marek V's EQOS series. > Remove code no longer needed from the EQOS series > Remove unnecessary include files. >=20 > V3: Fix Doc indicies to fix errors with 'make htmldocs' > Remove duplicated entries in imx8mp_beacon.env found in env_default.h > Remove unnecessary include options from imx8mp_beacon.h >=20 > V2: Move default environment from imx8mp_beacon.h to imx8mp_beacon.env > Move README to beacon-imx8mp.rst >=20 > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile > index d9b719f85d..d812ad4048 100644 > --- a/arch/arm/dts/Makefile > +++ b/arch/arm/dts/Makefile > @@ -986,6 +986,7 @@ dtb-$(CONFIG_ARCH_IMX8M) +=3D \ > imx8mn-beacon-kit.dtb \ > imx8mq-mnt-reform2.dtb \ > imx8mq-phanbell.dtb \ > + imx8mp-beacon-kit.dtb \ > imx8mp-dhcom-pdk2.dtb \ > imx8mp-evk.dtb \ > imx8mp-icore-mx8mp-edimm2.2.dtb \ > diff --git a/arch/arm/dts/imx8mp-beacon-kit-u-boot.dtsi b/arch/arm/dts/im= x8mp-beacon-kit-u-boot.dtsi > new file mode 100644 > index 0000000000..0f7c91a078 > --- /dev/null > +++ b/arch/arm/dts/imx8mp-beacon-kit-u-boot.dtsi > @@ -0,0 +1,216 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright 2022 Logic PD, Inc DBA Beacon EmbeddedWorks > + */ > + > +#include "imx8mp-u-boot.dtsi" > + > +/ { > + wdt-reboot { > + compatible =3D "wdt-reboot"; > + wdt =3D <&wdog1>; > + u-boot,dm-spl; > + }; So, the patch needs to be vs next, where these are all bootph- tags, which can (and need to be) upstreamed. To make syncing easier, and not block the platform itself, you can keep the bootph- parts in the -u-boot.dtsi file until it's upstream in -next or what have you, but please push these upstream now. --=20 Tom --XG4djXZIymYfA05W Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQdCfgACgkQFHw5/5Y0 tyzq7wv/QyuO0XT3r+jTaL8h2L5EZaUub48C3HmIylfIUwflmZWGQ9lDv0sb0nyo lO3vHPpBElRgAjhuwSzGnUsiLnxtbUSgdc7DS/l+AUxAYYM3YEndLH/8eCXefxGz iuFtTjFWsNClYy8dVpsuhJJF1oxkURq+boVRA6GDJzGYq+IY4koIyxWYM2OeAyzH XG/oDrSYpOHsKLUNLlwObBqbbYfa4OMk8u3uAR3mYt2r0hrR0o/vtIjbIu4TaydP 5SP9kl1dIa0G+mn8+GTfYiFOsu3ThhkDfh2XjA5ynYsqn09YADeTFoYt23LdIKRW XpGnKoRzt2EagRrA3+WYecQCBp//hz3nm0HuTp2PrXFQ7Uqpi9Qy9sWmHiEuPqAn nn9zS+UAMMnenC3CR18I3it7Msl1ZlR+OuOtOvj6r+np8DJKawHqQQzMlpkSF90O QTK8nQwwkx/kPulrFaOqVdLod5txjmMSQh+SWhNfpTVGj2BSlNhU/6u8LRyTv2L8 Yw2z4IZc =dDEn -----END PGP SIGNATURE----- --XG4djXZIymYfA05W--