Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE07DC761A6 for ; Sat, 1 Apr 2023 01:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nhc7U+Dkgh9LJWR65r4JRjhfvS3GlwhIa4LXYoWNcOA=; b=Pp0knYNBFmCtfB WeRtnbC5N2/Wf2wiilrEIuqyZkLu/xnwf04+TZN3HtlzeQ52gXcAShPCISRQVHnv0FoNujSZVkLoL 0UxQeTZBTvrrJWPbKXQBi4pN8Kk3yzwPBcFr0QSpwLcdjNkTKJIDdBbrKK7VVLBanCF/IpZ92OJtl 9aqKJ0nJE1GjiW9eUzWO8HYZPXbWad3Idp4co8/0XqCwcdZGndEGIUn+6SAoXKII4Q0FgBEYBx6QX sw6ilxR5KjnVhIujhZYYhjxGTKIUMCwHSYHfqT0khXfZc20pSXSnw0EPd1Vi/IWJqr9/afojjDtFu d9lUWCk1/237mlhwrp4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1piQIT-009V4m-0p; Sat, 01 Apr 2023 01:44:49 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1piQIN-009Uyz-1f for kexec@lists.infradead.org; Sat, 01 Apr 2023 01:44:47 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AF36262D36; Sat, 1 Apr 2023 01:44:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5320DC4331D; Sat, 1 Apr 2023 01:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680313482; bh=bLUCoqyy4oAJvRQcFVc1K6a1zMsgEFgCKpZ3NUVxUDo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cej8dOa9msGbAD+izEkFq8JXXoHjOYPEvO+Lk5lCL+JWxRgMD6zy/ajvTeu6yeh7m Q4+uZqhWvhK6zsmWLbHbtC199pw6ZC/ykV+bbCdDnKCxMwg4tGBqFS6ekhG8aLI9AC p1znjwdqVMuvshrRIPf6LbEz34Y+M6GO6ny+Ug9+iCxa5B4L7pWJt0BnSSnVo0xY8/ XCj1uVJkpz7xZDcibszr2poJgeHVad1i7+HvHXBFdEg/QFE612W2fy20709LmWfwIb 6o36wxWITUaOK2apwdYWY3slXnGWj1muIA41UoVNZRJxxCmbMMb6FQxNPngQ7FtgJl BpVS8p+zCQCfg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Robbie Harwood , David Howells , Jarkko Sakkinen , Eric Biederman , Herbert Xu , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, kexec@lists.infradead.org, Sasha Levin , davem@davemloft.net Subject: [PATCH AUTOSEL 5.4 5/6] verify_pefile: relax wrapper length check Date: Fri, 31 Mar 2023 21:44:30 -0400 Message-Id: <20230401014431.3357345-5-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401014431.3357345-1-sashal@kernel.org> References: <20230401014431.3357345-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230331_184443_649773_D834C09C X-CRM114-Status: GOOD ( 13.57 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org From: Robbie Harwood [ Upstream commit 4fc5c74dde69a7eda172514aaeb5a7df3600adb3 ] The PE Format Specification (section "The Attribute Certificate Table (Image Only)") states that `dwLength` is to be rounded up to 8-byte alignment when used for traversal. Therefore, the field is not required to be an 8-byte multiple in the first place. Accordingly, pesign has not performed this alignment since version 0.110. This causes kexec failure on pesign'd binaries with "PEFILE: Signature wrapper len wrong". Update the comment and relax the check. Signed-off-by: Robbie Harwood Signed-off-by: David Howells cc: Jarkko Sakkinen cc: Eric Biederman cc: Herbert Xu cc: keyrings@vger.kernel.org cc: linux-crypto@vger.kernel.org cc: kexec@lists.infradead.org Link: https://learn.microsoft.com/en-us/windows/win32/debug/pe-format#the-attribute-certificate-table-image-only Link: https://github.com/rhboot/pesign Link: https://lore.kernel.org/r/20230220171254.592347-2-rharwood@redhat.com/ # v2 Signed-off-by: Sasha Levin --- crypto/asymmetric_keys/verify_pefile.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/crypto/asymmetric_keys/verify_pefile.c b/crypto/asymmetric_keys/verify_pefile.c index cc9dbcecaacaa..c43b077ba37db 100644 --- a/crypto/asymmetric_keys/verify_pefile.c +++ b/crypto/asymmetric_keys/verify_pefile.c @@ -135,11 +135,15 @@ static int pefile_strip_sig_wrapper(const void *pebuf, pr_debug("sig wrapper = { %x, %x, %x }\n", wrapper.length, wrapper.revision, wrapper.cert_type); - /* Both pesign and sbsign round up the length of certificate table - * (in optional header data directories) to 8 byte alignment. + /* sbsign rounds up the length of certificate table (in optional + * header data directories) to 8 byte alignment. However, the PE + * specification states that while entries are 8-byte aligned, this is + * not included in their length, and as a result, pesign has not + * rounded up since 0.110. */ - if (round_up(wrapper.length, 8) != ctx->sig_len) { - pr_debug("Signature wrapper len wrong\n"); + if (wrapper.length > ctx->sig_len) { + pr_debug("Signature wrapper bigger than sig len (%x > %x)\n", + ctx->sig_len, wrapper.length); return -ELIBBAD; } if (wrapper.revision != WIN_CERT_REVISION_2_0) { -- 2.39.2 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec