Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5093BC761A6 for ; Mon, 3 Apr 2023 08:38:42 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PqknX5mWNz3cMT for ; Mon, 3 Apr 2023 18:38:40 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.113; helo=out30-113.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=) Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PqknP47s2z3bhJ for ; Mon, 3 Apr 2023 18:38:32 +1000 (AEST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_---0VfGK3hg_1680511100; Received: from e18g06460.et15sqa.tbsite.net(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VfGK3hg_1680511100) by smtp.aliyun-inc.com; Mon, 03 Apr 2023 16:38:28 +0800 From: Gao Xiang To: linux-erofs@lists.ozlabs.org Subject: [PATCH] erofs-utils: fix nid lookup for packed inode Date: Mon, 3 Apr 2023 16:38:19 +0800 Message-Id: <20230403083819.47453-1-hsiangkao@linux.alibaba.com> X-Mailer: git-send-email 2.24.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gao Xiang Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" If inode->nid is less than 0, it should be unallocated nid as well. Reported-by: Jingbo Xu Fixes: 21d84349e79a ("erofs-utils: rearrange on-disk metadata") Signed-off-by: Gao Xiang --- lib/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/inode.c b/lib/inode.c index e2b02c4..54ea5fa 100644 --- a/lib/inode.c +++ b/lib/inode.c @@ -288,7 +288,7 @@ erofs_nid_t erofs_lookupnid(struct erofs_inode *inode) struct erofs_buffer_head *const bh = inode->bh; erofs_off_t off, meta_offset; - if (!bh || inode->nid) + if (!bh || (long long)inode->nid > 0) return inode->nid; erofs_mapbh(bh->block); -- 2.24.4