Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 154E3C761A6 for ; Tue, 4 Apr 2023 18:05:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1670685C6D; Tue, 4 Apr 2023 20:05:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1680631536; bh=bMntyk0aEsNcB9UT894hFyV0APJ2HyAhPBax9MMhDVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DVP3tjBbG0LSa1EDa/wbkfZyZhkSBsV2ruhX3vHW5QAQBeg9z55vZG8pSn2+a6fVd Q8ETKmIZmdZkNoaknBWE2XLdypu4XE+dvO1E5pcvH/noEnJUxbu2j0mQ59puB1KXpM cLsUKI4Z333uYScS/5EUHhU9CUfKjp5QJntgtf7qa+15JMYw+pKSpy5vl+uhur+gye UkRg8Rj6BryLHbYnl0XjeT+nsxuPmNDPPqIdCHOACejUSDoHb7bDkPAbDakI0UQHUc fCNM+n5M6YOeyq8AgEnEa7cUJm2u9DRxhRRJXh24hsN8kjXl+Lhqq+e1uyB0rVG4Rv kd5x0UUPAYUvg== Received: from tr.lan (ip-86-49-120-218.bb.vodafone.cz [86.49.120.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id E89EE856B2; Tue, 4 Apr 2023 20:05:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1680631527; bh=bMntyk0aEsNcB9UT894hFyV0APJ2HyAhPBax9MMhDVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s9IkRQ5FJRdpLXoK6POCJ9/Nd/J4NYuSCRgwO3O8YK/1dDN7lCLb5yE4Jx/Jyk8A2 c0ZI8qcc7BGM5PiNBgbsckRlET5WzK2+2PvA+KBykA0zK+REQFYMbSwul7xJX7Ff/c 3Z9CB7l4vfWLd7kjzrvqmD3qSMVNVzzjZIQovMF8mRgnMEF5LXdgOmEZZL2mJADM6g VIDuGzCxV8vPpdn9opCtd1oNwWHQHf9RUlpjvnKgM+xZanJp6hkHL/zUJKkyyibJNa fotG2FMb5gDHVk7ICkbwoZRFAdB/w5+bARkcgn8udoJykIamFLMgjzXW0C8fXw6hyI KTpVo0ofknvCw== From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Fedor Ross , Jaehoon Chung , Peng Fan Subject: [PATCH v3 2/2] spl: mmc: Pass eMMC HW partition 7 through Date: Tue, 4 Apr 2023 20:05:15 +0200 Message-Id: <20230404180515.49821-2-marex@denx.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230404180515.49821-1-marex@denx.de> References: <20230404180515.49821-1-marex@denx.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The eMMC HW partition 0 and 7 both mean USER HW partition. Use this as a mean of propagating A/B copy selection within USER HW partition. The spl_mmc_get_uboot_raw_sector() can detect that a USER HW partition is in use and based on whether it is 0 or 7, select appropriate sector to load from. Signed-off-by: Fedor Ross Signed-off-by: Marek Vasut --- Cc: Jaehoon Chung Cc: Peng Fan --- V2: Initialize the part variable, else it is passed uninitialized to mmc_load_image_raw_sector(..raw_sect + spl_mmc_raw_uboot_offset(part)); and that prevents pine64 from booting. Interestingly enough, there is no warning emitted, which sounds like a compiler bug. V3: Update on u-boot/master --- common/spl/spl_mmc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c index f1f87d78ba7..865c395b9fe 100644 --- a/common/spl/spl_mmc.c +++ b/common/spl/spl_mmc.c @@ -412,7 +412,7 @@ int spl_mmc_load(struct spl_image_info *spl_image, static struct mmc *mmc; u32 boot_mode; int err = 0; - __maybe_unused int hw_part = 0; + __maybe_unused int part = 0, hw_part = 0; int mmc_dev; /* Perform peripheral init only once for an mmc device */ @@ -437,11 +437,12 @@ int spl_mmc_load(struct spl_image_info *spl_image, switch (boot_mode) { case MMCSD_MODE_EMMCBOOT: hw_part = spl_mmc_emmc_boot_partition(mmc); + part = hw_part == 7 ? 0 : hw_part; if (CONFIG_IS_ENABLED(MMC_TINY)) - err = mmc_switch_part(mmc, hw_part); + err = mmc_switch_part(mmc, part); else - err = blk_dselect_hwpart(mmc_get_blk_desc(mmc), hw_part); + err = blk_dselect_hwpart(mmc_get_blk_desc(mmc), part); if (err) { #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT @@ -471,7 +472,7 @@ int spl_mmc_load(struct spl_image_info *spl_image, #endif #ifdef CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR err = mmc_load_image_raw_sector(spl_image, bootdev, mmc, - raw_sect + spl_mmc_raw_uboot_offset(hw_part)); + raw_sect + spl_mmc_raw_uboot_offset(part)); if (!err) return err; #endif -- 2.39.2