Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EECAC77B61 for ; Fri, 7 Apr 2023 14:50:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 44E1F86170; Fri, 7 Apr 2023 16:49:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="OQgrDKvn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8506985FB3; Fri, 7 Apr 2023 16:49:55 +0200 (CEST) Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 517CC85CAC for ; Fri, 7 Apr 2023 16:49:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2b.google.com with SMTP id om8so305799qvb.3 for ; Fri, 07 Apr 2023 07:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1680878991; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wD/L+GNN5PYuE4GDIHx860E1xR88GedMMnCj0yXkM2E=; b=OQgrDKvnTPefMw4Pi2MK+8CTpUXUOUzdHl7DTMft5FC5NO01Dm+Sgb/9FN/kqdi4pe 2yLNAI9QbNgi6hEf5HzFtt1HgK3b/VJB2PkmYZMQo17W2iPAk++HRGc1NbPGAPv9xH1v o6945dfoQtgGuWjVbHHqu8w6HP3Qbb2de2090= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680878991; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wD/L+GNN5PYuE4GDIHx860E1xR88GedMMnCj0yXkM2E=; b=4FouGfIhhBx3zsCrXQOEoDLFLlZWQQWe4dN98OWF6M5+E5XROns4j9UcOcfgI+8d70 fhxBqjAhybRbt7mgnVuqLlHY4OVlbw/vJWkWVCSgpDoH/dTbgQgJ9rug61CBR1Y0jFKD xp9sZrCziz90r3lHuA1zxus5RwxA553ly47Umm9sUYvTigjxl6jBR0NIgBN7GdavQdo9 JQMymS4/LvSogJdtvKn+6L4d/KLn91GzZKRDyZ/jI4Kgpm6DSaIannhk/o4J1S4fMGJH 3EWvlQpM+uk8VWzSqKkIgFhQwN+MVhZ8V0Zr0EOBbo4qXadnr366L/jzQZ50JMipiOxD aWwQ== X-Gm-Message-State: AAQBX9corZQBcCF5K9t//EF2QnaC0onUKDQ3o8CQM9IFCgfU6QgozqEl lWKUFtTwDWDgW48aWU1SCv4/7haeZXX2uZuc+fQbLA== X-Google-Smtp-Source: AKy350a4eqTkVExlx+mphV4DviCDH3kbQ8zJBNXqBdvEJ52yXRylPwRvYnU4hDgKaksiAc6kAABhcQ== X-Received: by 2002:a05:6214:21a8:b0:5e0:ad80:6847 with SMTP id t8-20020a05621421a800b005e0ad806847mr4034421qvc.38.1680878991049; Fri, 07 Apr 2023 07:49:51 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-4d7a-a40c-ed12-3a35.res6.spectrum.com. [2603:6081:7b00:6400:4d7a:a40c:ed12:3a35]) by smtp.gmail.com with ESMTPSA id dr9-20020a05621408e900b005e750d07153sm973869qvb.135.2023.04.07.07.49.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 07:49:50 -0700 (PDT) Date: Fri, 7 Apr 2023 10:49:48 -0400 From: Tom Rini To: Tim Lee Cc: sjg@chromium.org, chli30@nuvoton.com, u-boot@lists.denx.de Subject: Re: [PATCH v1 1/1] tools: env: use /run to store lockfile Message-ID: <20230407144948.GL1134230@bill-the-cat> References: <20230210090539.1631-1-timlee660101@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="t053ryKF8uH2vaXT" Content-Disposition: inline In-Reply-To: <20230210090539.1631-1-timlee660101@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --t053ryKF8uH2vaXT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 10, 2023 at 05:05:39PM +0800, Tim Lee wrote: > According this issue https://github.com/ppp-project/ppp/issues/339. > Eventually, the dt-utils changed lock directory to fix missing /var/lock > directory error then make dt-utils can run normally. >=20 > We also have a similar issue with these two utilities fw_printenv and > fw_setenv will failed when the directory /var/lock is non-existent. >=20 > We have a custom linux distribution built with yocto (OpenBMC) that > use systemd and it deprecated the /var/lock directory. > More discussion in systemd/systemd#15668. >=20 > Thus, we sync with community's solution for uboot/tools/env utilities: > The current location /var/lock is considered legacy (at least by systemd). > Just use /run to store the lockfile and append the usual .lock suffix. >=20 > Tested: > Verified /run/lock is now present and fw_printenv can work in OpenBMC. >=20 > Signed-off-by: Tim Lee > Reviewed-by: Tom Rini > Reviewed-by: Tom Rini Applied to u-boot/master, thanks! --=20 Tom --t053ryKF8uH2vaXT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQwLYwACgkQFHw5/5Y0 tywjjQv9HdKC4CZqOEDzu9qUxmlyq76nebGiam7YEa6CiszHSbrMu+Y0adF2ywtj aXdFX49MOfXKWwLVXeYj2fT+syrHu5xPxg37S6rbBCNdu/hW25AdtWaW8mK6OaCd nSCDVEPaw1mXZeMmAHpZKjIYehBlFpV6eN9Xl0+mSt9c/H4AhF48hAz1jHIQMEAj 0uxNLvXajjpujjoN2NDvxleCZcvM9N6WkpEiiJxREHU6lHUCslU0Q6fsTWp5mN8S XNf0hmWtQM6lROQnWYLM/NkChoaOe72bcZykELFuw/wsiZd9COEBvI1/53Kjwc4C JExko/h5XuWm4dzxMLH5u7ePYIu4SionJL/moazW71d7uiihUHMQdtV63F+iQN+z MNDbXjQnASi7rZsPwExNWwt38TDAo63Oq9N0x1byzJsfwKzbsBPcBUSY4LIJIRtp 3xqR7kWSkApdsLVJFuzVbyP6KgTZ0HIBUflj3I9jB/ihAkL8o7+9jvvcLMN+be1x pcBANTft =yEUt -----END PGP SIGNATURE----- --t053ryKF8uH2vaXT--