From: Horatiu Vultur Subject: Re: [PATCH nf-next v2 2/4] ipvs: Consistently use array_size() in ip_vs_conn_init() Date: Tue, 11 Apr 2023 13:34:50 +0200 Message-ID: <20230411113450.ky4jp6jsptvlzrtx@soft-dev3-1> References: <20230409-ipvs-cleanup-v2-0-204cd17da708@kernel.org> <20230409-ipvs-cleanup-v2-2-204cd17da708@kernel.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1681212901; x=1712748901; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rCpRx8zrwmywWfUW2YxiAvJ2J1O/eklkQmlDcOmjNXM=; b=fhAKYZ41cHJHfbwdsQOuVm7zIQzmM1Y7NfILam97srLnMnG72a/IPMyU MUOpFIDgdIKKA8C5LdKLc5Ioz366hcEP0y4fCWCEnEd19VKwVPUQf3dtq 1Gs933GhUxvw0vargbJM0E8xIeReVkfw3XkqxW/XcSVNBa2F9e7l28xUf GlZxFmxv+JRIe4jKjtMkA9jGPAnZ2dFnxvFDb9H0xfbEWMSXFfHsmgEv/ UtKsHU/VGNa8BGi7UCVfTzbYWuLT04FtyBfAACya6KPbcwOfABlqSuJhN PDRTI78UeJKJIpwDGfGIIEGz/qGu4OLEZ0pZKFK+06yAEP5iZHZ9ysP8q w==; Content-Disposition: inline In-Reply-To: <20230409-ipvs-cleanup-v2-2-204cd17da708@kernel.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Simon Horman Cc: Julian Anastasov , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , netdev@vger.kernel.org, "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , lvs-devel@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org The 04/11/2023 09:10, Simon Horman wrote: > > Consistently use array_size() to calculate the size of ip_vs_conn_tab > in bytes. > > Flagged by Coccinelle: > WARNING: array_size is already used (line 1498) to compute the same size > > No functional change intended. > Compile tested only. Reviewed-by: Horatiu Vultur > > Signed-off-by: Simon Horman > --- > v2 > * Retain division by 1024, which was lost in v1 > --- > net/netfilter/ipvs/ip_vs_conn.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c > index 13534e02346c..84d273a84dc8 100644 > --- a/net/netfilter/ipvs/ip_vs_conn.c > +++ b/net/netfilter/ipvs/ip_vs_conn.c > @@ -1481,6 +1481,7 @@ void __net_exit ip_vs_conn_net_cleanup(struct netns_ipvs *ipvs) > > int __init ip_vs_conn_init(void) > { > + size_t tab_array_size; > int idx; > > /* Compute size and mask */ > @@ -1494,8 +1495,9 @@ int __init ip_vs_conn_init(void) > /* > * Allocate the connection hash table and initialize its list heads > */ > - ip_vs_conn_tab = vmalloc(array_size(ip_vs_conn_tab_size, > - sizeof(*ip_vs_conn_tab))); > + tab_array_size = array_size(ip_vs_conn_tab_size, > + sizeof(*ip_vs_conn_tab)); > + ip_vs_conn_tab = vmalloc(tab_array_size); > if (!ip_vs_conn_tab) > return -ENOMEM; > > @@ -1508,10 +1510,8 @@ int __init ip_vs_conn_init(void) > return -ENOMEM; > } > > - pr_info("Connection hash table configured " > - "(size=%d, memory=%ldKbytes)\n", > - ip_vs_conn_tab_size, > - (long)(ip_vs_conn_tab_size*sizeof(*ip_vs_conn_tab))/1024); > + pr_info("Connection hash table configured (size=%d, memory=%zdKbytes)\n", > + ip_vs_conn_tab_size / 1024, tab_array_size); > IP_VS_DBG(0, "Each connection entry needs %zd bytes at least\n", > sizeof(struct ip_vs_conn)); > > > -- > 2.30.2 > -- /Horatiu