Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 991AAC7619A for ; Wed, 12 Apr 2023 05:02:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229573AbjDLFCv (ORCPT ); Wed, 12 Apr 2023 01:02:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjDLFCu (ORCPT ); Wed, 12 Apr 2023 01:02:50 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 086212D66 for ; Tue, 11 Apr 2023 22:02:50 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 78AC168BFE; Wed, 12 Apr 2023 07:02:47 +0200 (CEST) Date: Wed, 12 Apr 2023 07:02:47 +0200 From: Christoph Hellwig To: Bart Van Assche Cc: Christoph Hellwig , Jens Axboe , linux-block@vger.kernel.org Subject: Re: [PATCH 14/16] blk-mq: pass a flags argument to blk_mq_insert_request Message-ID: <20230412050247.GB17948@lst.de> References: <20230411133329.554624-1-hch@lst.de> <20230411133329.554624-15-hch@lst.de> <17f6f705-fb78-f6e3-3427-eae801fc06af@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17f6f705-fb78-f6e3-3427-eae801fc06af@acm.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Apr 11, 2023 at 11:11:51AM -0700, Bart Van Assche wrote: >> +#define BLK_MQ_INSERT_AT_HEAD (1U << 0) > > Has it been considered to introduce a new bitwise type for this flag? That > would allow sparse to detect accidental conversions from bool into flag and > vice versa. I did think about it, but decided not to bother. But now that there's a request for it I'll add it.