Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pmTmq-0006EU-II for mharc-grub-devel@gnu.org; Wed, 12 Apr 2023 02:16:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmTmo-0006DO-U0 for grub-devel@gnu.org; Wed, 12 Apr 2023 02:16:55 -0400 Received: from mail-am6eur05on2086.outbound.protection.outlook.com ([40.107.22.86] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmTmm-0006SV-Oi for grub-devel@gnu.org; Wed, 12 Apr 2023 02:16:54 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BJ/yP9bQI+p7rqR0PP9dTAGyDsKW9rSrS70XMskfEOuXGN+pIqanIFRrvPUbuaLH0yoWipnm5n7olB8lJTSgNaL1odqXAcu3NTjAV1gctYFO0LGWVMxbueLtTAOcdhQcX0WZ6yBRIktq2u0Vh/u3jE94LhUCU12q7pGIfgrfNWGA/n3/CaQG/NgNNi2Wn/WuKSQqR3cY3TIiItiksdGbE0uICrBVVrEB2PIjPDtysvwfzWxlbgsX1FPz5cKVeIH+XllQC90bIFWN95bRc6sj+rn1f0SOqA24l7N4uRFNA0B3q88cSStp2ZDYM8J8uqNkjsb1D8GnYTDqGmtiyVq+jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ymg7F8p0DJiDAowo6hto4mbr4+bevALYCPdmQ9B+h+M=; b=GF5y4n9+yC+KGjDtonN9nhLkS3U6+FFhwW3Brc7Kr/B3FVXQMsIIzrpKl9BEqdJYLh8WH+vNNFv/QyYsz7eGqa5ueKfhEFXiymtcqANAR2DAodVdhkw2yhs/B9QyO+hDY+q+sDycEQckX257j7D58OWfxQ9p45S/TqFPv1ZzzHS0tti+mpGqfCJ4p44RXky/GKLBGc7seVgutNggjxuRWQhJScHhm73TbS7XPhJK1rj2sY/CTFz0CKZ3mnhKwBWS/mk1S568M3pSj2/uFUdNPCQb9L58P8Wxg7Pb++1ULSfM6Zvl5hW6UC+NiXGVdOTUvQWW55vtHrJJBLUoe0B7+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ymg7F8p0DJiDAowo6hto4mbr4+bevALYCPdmQ9B+h+M=; b=nTK9oEPoZE3nvoGp+LbeZqn6ZYw8Lk5nLHizYub/05TZypqg6ozvbzslyyFkQPoFpQxnXNatRzv+zN3RqCALHL5fmIZg09OLeLnyZ1zsMOV1WF19Texet8YBFJ19WmcBUNFySCEY3th0UzDJKn2kYp1+2OQQlMfKriwyS3+1Z1+uE5vBHiegQBbILmeyPZv4jbcfYx+3pxgeftPp69h3+rt5cVkFOJAwkImsS7UHW0MYz1DpRldTw1nINowtT3ZA+NBLxzbx8Wo6sqAMqFod9kgn9jcRF6kyH3AzgMMMbUkvyabrz87vRU2hkNu+hXr7XTE4OB46PdLLTajMGNcvzg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DBBPR04MB6140.eurprd04.prod.outlook.com (2603:10a6:10:c7::18) by DU2PR04MB8663.eurprd04.prod.outlook.com (2603:10a6:10:2de::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Wed, 12 Apr 2023 06:16:43 +0000 Received: from DBBPR04MB6140.eurprd04.prod.outlook.com ([fe80::8e45:fffd:c1eb:3ebd]) by DBBPR04MB6140.eurprd04.prod.outlook.com ([fe80::8e45:fffd:c1eb:3ebd%4]) with mapi id 15.20.6277.038; Wed, 12 Apr 2023 06:16:43 +0000 From: Gary Lin To: The development of GNU GRUB Cc: Hernan Gatta , Daniel Axtens , 'Daniel Kiper ' , shkhisti@microsoft.com, jaskaran.khurana@microsoft.com, christopher.co@microsoft.com, daniel.mihai@microsoft.com, rharwood@redhat.com, jaredz@redhat.com, development@efficientek.com, jejb@linux.ibm.com, mchang@suse.com Subject: [PATCH v3 11/12] cryptodisk: Support key protectors Date: Wed, 12 Apr 2023 14:15:52 +0800 Message-Id: <20230412061553.7597-12-glin@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230412061553.7597-1-glin@suse.com> References: <20230412061553.7597-1-glin@suse.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: FR2P281CA0099.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::9) To DBBPR04MB6140.eurprd04.prod.outlook.com (2603:10a6:10:c7::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR04MB6140:EE_|DU2PR04MB8663:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c1af2e4-0cc3-4952-f13a-08db3b1d7c56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Idu8DtArLY57V8MfeydqXRTBWP/cBrXtt6kCKhQYDDA320OhaWNzU1fmvUFrqEqE1WSCQtDjQYUbCqO7HeF1f2W9pC2Q4D/i3c+PamHWyjMnPS3Yag2wQHUXEODZ5A0RGtrgvRCOjzcTLucYUdC4jaem9ujePe4Qe4i0tgcmLVa/8wW5wG0eyHKdugbAHa4x2vSFgbrTXaVnOn7M+LUzKff9S/Z40BRgFkLVo+CUQnCObsNrCgffdvYRmGXt+rjsOyRN5sKTAQPDXdSQmiYRTwhRp0g2v6Sgz/tF2uewBqimLqJZA9xHaIlqxDcLQDVng5t6vZtuNaHbLAhvzirIxeypygjuZppJRPFc4xkmy2kqVmXlLWARVCMcBsA/wtnVZP3CBbW7KpBmlwAO66t6+1EmumZXiOPsUuP87pNZdJ4/6jH6++cuP3XYYs8qZG3wrJK0Bhwy/DMHWOf6dd4oxW2NOwEElGgfl5lZCA0YUxZ7OzmVKMJrI6DqreDFy0tJlSTYV0atRJ9S7XrrNAORV7T+5efu6VpBo+sBcnwf+hzn41ALsLXrYGZ/NXmZthk4 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR04MB6140.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(366004)(346002)(396003)(136003)(376002)(451199021)(83380400001)(107886003)(2616005)(478600001)(6486002)(6666004)(186003)(54906003)(26005)(1076003)(6506007)(6512007)(2906002)(7416002)(30864003)(36756003)(5660300002)(38100700002)(66556008)(6916009)(4326008)(41300700001)(66476007)(66946007)(316002)(8936002)(86362001)(8676002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UxY815NpsU9EyQxDvwpDj20aKj9fTuaMQYav1kPhtsHSDsUErhVxoO2TPRr7?= =?us-ascii?Q?b0ikmrWVTEH4RlUqsDP8K/WvDtFKtkXzRSBbos+jVNr8i4HwOB8q46IzLKvm?= =?us-ascii?Q?p9VoCF1lXYYhnajb71ViLsOR9lpiOceEV2CuDtXpC+uh29cHFv68xwstwX2h?= =?us-ascii?Q?vK1qnQHk5rMwLHOBWziy1NN9jCzfbtZWj705ycTOqm59zUmGjj0+zq6T+mHb?= =?us-ascii?Q?tZIDrbUGyl28gZn78SYuvK4l8xlSisl5XUQQuhKyvJdcBc0WGfxJq/IYMiNv?= =?us-ascii?Q?NCUL76JMOIDNtJmkz/nLdlp1DgxcHHKvkPFYKm+5yg1QU3gTQYw5EBpqt4Ou?= =?us-ascii?Q?UFw4D6jriNRiXrv9o4zPSMNIUASFwhQr3Ex5YeOmKzOnqcalpIKF+/aYK63D?= =?us-ascii?Q?BzKJBuvNzosqLWHDW5VaxdF/i+E2b/3XU1pLDPTcjjOn/lQ7rpKW6jJJ+mia?= =?us-ascii?Q?ZDAbaN04tEivE/Ui31vLotN/+y2UTAQJicVrC+nmD03fY9oSJzBRWwBqYWgI?= =?us-ascii?Q?ME/Ir3RC3N0UzADM3S8dKM/GvC8WYhsRhZMeODaLI2UMs9TrGk6Ek0wYdxhs?= =?us-ascii?Q?muJvnaVTDUBB55vBWWv9NYFuAXYc86uKA6KtBUQl00TZV75laujxdCC7Eq1k?= =?us-ascii?Q?RXwKW/mFme1lrEpbZLyKetsVY45p28ZpsQiIrqzRsrhxWYOy9wGIk/xk1/bu?= =?us-ascii?Q?07ScVp2uXF8DnB43eXf+vv6A5wT3DUE8Q/8dvY6LcOLO+fjUzy6HPMuKmdIv?= =?us-ascii?Q?BNFL1KFQd0KsQ+A5wqOLdNk4/k2iSb6x5kAVKZAZtGnGgeP8YLrxM/4I4Xlh?= =?us-ascii?Q?Oi5SaL62BHs42BSWQWw+8MNb1z1gv5EdsPFipSn0tg+jYwpKpy1eDqs7ftOK?= =?us-ascii?Q?clauyTBhSLs19D4/i0WAl8XzsqamEKCaeZhSCY+VFvu43Vv6pPP9721QKvzS?= =?us-ascii?Q?KNKV/OJYcWgBSy+cXz7ZTPJz1TL70//5PRUXdA8+bYJkiPn/IEKOg+mIM3Q4?= =?us-ascii?Q?BsrJGE2GlK0Cj12c5DnvWMPW9z7kML+5cHbM3Wmf40lykqsUQak/4+KczKlf?= =?us-ascii?Q?SHNHMC6vYzvqqcFCDSFjfdudZ2uMJjuMG2reu5iwquctJqTpB5jqnfKiVRWW?= =?us-ascii?Q?jHDEEd9+G/H07QDSUrTHYBHG74qCWsMuZoYDi0o+G6dOQXxERDrTk85uGQKB?= =?us-ascii?Q?E0iCOzI7sLw+UI1nCyasKGOFOepnGQCSCG9apA+AGV1qz+aWdwlJnCkty6Hd?= =?us-ascii?Q?mVHDbtnNbkRjlZqU4CcqocsKOgsTRy+JW3e2nydG9SykA4hzLSxonPCyqnmj?= =?us-ascii?Q?BKh/K5kaL131FMmqsJ9uAuJ13V+2rQEdvKjg+xBYtCBTYTNIFfmdasbbfm31?= =?us-ascii?Q?o1/sCSY+A0lM+CAm0pNEdg5jChYEFQIKYn9rcWvpNevnLa8PQBIrfmcKhNTF?= =?us-ascii?Q?JAcOLIKg1bf7A3TqySOopa+QYTYd4CGuJiPjJNyWIM2e1LVTAv+wekAUI40Y?= =?us-ascii?Q?EkIPXAJe728U2GjsKIyqyMZZaI99wdE7NDg7+ng7GSRVxs3IzvZrDjvbOEkJ?= =?us-ascii?Q?/1bxnCrxrQECwfOxLfWJljT3vsq4H6le3eS6zy+W?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c1af2e4-0cc3-4952-f13a-08db3b1d7c56 X-MS-Exchange-CrossTenant-AuthSource: DBBPR04MB6140.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 06:16:43.2750 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oaJMnvTuogmKzzUyXv/Ux+5pUtnC6m8B6oafn5+4yGsqYclUt1eAekdYJ//DbBDY X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8663 Received-SPF: pass client-ip=40.107.22.86; envelope-from=GLin@suse.com; helo=EUR05-AM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2023 06:16:55 -0000 From: Hernan Gatta Add a new parameter to cryptomount to support the key protectors framework: -P. The parameter is used to automatically retrieve a key from specified key protectors. The parameter may be repeated to specify any number of key protectors. These are tried in order until one provides a usable key for any given disk. Signed-off-by: Hernan Gatta Signed-off-by: Michael Chang Signed-off-by: Gary Lin --- Makefile.util.def | 1 + grub-core/disk/cryptodisk.c | 172 +++++++++++++++++++++++++++++------- include/grub/cryptodisk.h | 16 ++++ 3 files changed, 158 insertions(+), 31 deletions(-) diff --git a/Makefile.util.def b/Makefile.util.def index c3b7df96d..7d8db722e 100644 --- a/Makefile.util.def +++ b/Makefile.util.def @@ -35,6 +35,7 @@ library = { common = grub-core/kern/list.c; common = grub-core/kern/misc.c; common = grub-core/kern/partition.c; + common = grub-core/kern/protectors.c; common = grub-core/lib/crypto.c; common = grub-core/lib/json/json.c; common = grub-core/disk/luks.c; diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c index 34b67a705..8fdae74cf 100644 --- a/grub-core/disk/cryptodisk.c +++ b/grub-core/disk/cryptodisk.c @@ -26,6 +26,7 @@ #include #include #include +#include #ifdef GRUB_UTIL #include @@ -44,7 +45,8 @@ enum OPTION_KEYFILE, OPTION_KEYFILE_OFFSET, OPTION_KEYFILE_SIZE, - OPTION_HEADER + OPTION_HEADER, + OPTION_PROTECTOR }; static const struct grub_arg_option options[] = @@ -58,6 +60,8 @@ static const struct grub_arg_option options[] = {"keyfile-offset", 'O', 0, N_("Key file offset (bytes)"), 0, ARG_TYPE_INT}, {"keyfile-size", 'S', 0, N_("Key file data size (bytes)"), 0, ARG_TYPE_INT}, {"header", 'H', 0, N_("Read header from file"), 0, ARG_TYPE_STRING}, + {"protector", 'P', GRUB_ARG_OPTION_REPEATABLE, + N_("Unlock volume(s) using key protector(s)."), 0, ARG_TYPE_STRING}, {0, 0, 0, 0, 0, 0} }; @@ -1061,6 +1065,7 @@ grub_cryptodisk_scan_device_real (const char *name, grub_err_t ret = GRUB_ERR_NONE; grub_cryptodisk_t dev; grub_cryptodisk_dev_t cr; + int i; struct cryptodisk_read_hook_ctx read_hook_data = {0}; int askpass = 0; char *part = NULL; @@ -1113,41 +1118,112 @@ grub_cryptodisk_scan_device_real (const char *name, goto error_no_close; if (!dev) continue; + break; + } - if (!cargs->key_len) - { - /* Get the passphrase from the user, if no key data. */ - askpass = 1; - part = grub_partition_get_name (source->partition); - grub_printf_ (N_("Enter passphrase for %s%s%s (%s): "), source->name, - source->partition != NULL ? "," : "", - part != NULL ? part : N_("UNKNOWN"), - dev->uuid); - grub_free (part); - - cargs->key_data = grub_malloc (GRUB_CRYPTODISK_MAX_PASSPHRASE); - if (cargs->key_data == NULL) - goto error_no_close; - - if (!grub_password_get ((char *) cargs->key_data, GRUB_CRYPTODISK_MAX_PASSPHRASE)) - { - grub_error (GRUB_ERR_BAD_ARGUMENT, "passphrase not supplied"); - goto error; - } - cargs->key_len = grub_strlen ((char *) cargs->key_data); - } + if (!dev) + { + grub_error (GRUB_ERR_BAD_MODULE, + "no cryptodisk module can handle this device"); + goto error_no_close; + } - ret = cr->recover_key (source, dev, cargs); - if (ret != GRUB_ERR_NONE) - goto error; + if (cargs->protectors) + { + for (i = 0; cargs->protectors[i]; i++) + { + if (cargs->key_cache[i].invalid) + continue; + + if (!cargs->key_cache[i].key) + { + ret = grub_key_protector_recover_key (cargs->protectors[i], + &cargs->key_cache[i].key, + &cargs->key_cache[i].key_len); + if (ret != GRUB_ERR_NONE) + { + if (grub_errno) + { + grub_print_error (); + grub_errno = GRUB_ERR_NONE; + } + + grub_dprintf ("cryptodisk", + "failed to recover a key from key protector " + "%s, will not try it again for any other " + "disks, if any, during this invocation of " + "cryptomount\n", + cargs->protectors[i]); + + cargs->key_cache[i].invalid = 1; + continue; + } + } + + cargs->key_data = cargs->key_cache[i].key; + cargs->key_len = cargs->key_cache[i].key_len; - ret = grub_cryptodisk_insert (dev, name, source); - if (ret != GRUB_ERR_NONE) + ret = cr->recover_key (source, dev, cargs); + if (ret != GRUB_ERR_NONE) + { + part = grub_partition_get_name (source->partition); + grub_dprintf ("cryptodisk", + "recovered a key from key protector %s but it " + "failed to unlock %s%s%s (%s)\n", + cargs->protectors[i], source->name, + source->partition != NULL ? "," : "", + part != NULL ? part : N_("UNKNOWN"), dev->uuid); + grub_free (part); + continue; + } + else + { + ret = grub_cryptodisk_insert (dev, name, source); + if (ret != GRUB_ERR_NONE) + goto error; + goto cleanup; + } + } + + part = grub_partition_get_name (source->partition); + grub_error (GRUB_ERR_ACCESS_DENIED, + N_("no key protector provided a usable key for %s%s%s (%s)"), + source->name, source->partition != NULL ? "," : "", + part != NULL ? part : N_("UNKNOWN"), dev->uuid); + grub_free (part); goto error; + } + + if (!cargs->key_len) + { + /* Get the passphrase from the user, if no key data. */ + askpass = 1; + part = grub_partition_get_name (source->partition); + grub_printf_ (N_("Enter passphrase for %s%s%s (%s): "), source->name, + source->partition != NULL ? "," : "", + part != NULL ? part : N_("UNKNOWN"), dev->uuid); + grub_free (part); + + cargs->key_data = grub_malloc (GRUB_CRYPTODISK_MAX_PASSPHRASE); + if (cargs->key_data == NULL) + goto error; + + if (!grub_password_get ((char *) cargs->key_data, GRUB_CRYPTODISK_MAX_PASSPHRASE)) + { + grub_error (GRUB_ERR_BAD_ARGUMENT, "passphrase not supplied"); + goto error; + } + cargs->key_len = grub_strlen ((char *) cargs->key_data); + } + + ret = cr->recover_key (source, dev, cargs); + if (ret != GRUB_ERR_NONE) + goto error; + + ret = grub_cryptodisk_insert (dev, name, source); + if (ret != GRUB_ERR_NONE) + goto error; - goto cleanup; - } - grub_error (GRUB_ERR_BAD_MODULE, "no cryptodisk module can handle this device"); goto cleanup; error: @@ -1258,6 +1334,20 @@ grub_cryptodisk_scan_device (const char *name, return ret; } +static void +grub_cryptodisk_clear_key_cache (struct grub_cryptomount_args *cargs) +{ + int i; + + if (cargs->key_cache == NULL || cargs->protectors == NULL) + return; + + for (i = 0; cargs->protectors[i]; i++) + grub_free (cargs->key_cache[i].key); + + grub_free (cargs->key_cache); +} + static grub_err_t grub_cmd_cryptomount (grub_extcmd_context_t ctxt, int argc, char **args) { @@ -1270,6 +1360,10 @@ grub_cmd_cryptomount (grub_extcmd_context_t ctxt, int argc, char **args) if (grub_cryptodisk_list == NULL) return grub_error (GRUB_ERR_BAD_MODULE, "no cryptodisk modules loaded"); + if (state[OPTION_PASSWORD].set && state[OPTION_PROTECTOR].set) /* password and key protector */ + return grub_error (GRUB_ERR_BAD_ARGUMENT, + "a password and a key protector cannot both be set"); + if (state[OPTION_PASSWORD].set) /* password */ { cargs.key_data = (grub_uint8_t *) state[OPTION_PASSWORD].arg; @@ -1362,6 +1456,15 @@ grub_cmd_cryptomount (grub_extcmd_context_t ctxt, int argc, char **args) return grub_errno; } + if (state[OPTION_PROTECTOR].set) /* key protector(s) */ + { + cargs.key_cache = grub_zalloc (state[OPTION_PROTECTOR].set * sizeof (*cargs.key_cache)); + if (!cargs.key_cache) + return grub_error (GRUB_ERR_OUT_OF_MEMORY, + "no memory for key protector key cache"); + cargs.protectors = state[OPTION_PROTECTOR].args; + } + if (state[OPTION_UUID].set) /* uuid */ { int found_uuid; @@ -1370,6 +1473,7 @@ grub_cmd_cryptomount (grub_extcmd_context_t ctxt, int argc, char **args) dev = grub_cryptodisk_get_by_uuid (args[0]); if (dev) { + grub_cryptodisk_clear_key_cache (&cargs); grub_dprintf ("cryptodisk", "already mounted as crypto%lu\n", dev->id); return GRUB_ERR_NONE; @@ -1378,6 +1482,7 @@ grub_cmd_cryptomount (grub_extcmd_context_t ctxt, int argc, char **args) cargs.check_boot = state[OPTION_BOOT].set; cargs.search_uuid = args[0]; found_uuid = grub_device_iterate (&grub_cryptodisk_scan_device, &cargs); + grub_cryptodisk_clear_key_cache (&cargs); if (found_uuid) return GRUB_ERR_NONE; @@ -1397,6 +1502,7 @@ grub_cmd_cryptomount (grub_extcmd_context_t ctxt, int argc, char **args) { cargs.check_boot = state[OPTION_BOOT].set; grub_device_iterate (&grub_cryptodisk_scan_device, &cargs); + grub_cryptodisk_clear_key_cache (&cargs); return GRUB_ERR_NONE; } else @@ -1420,6 +1526,7 @@ grub_cmd_cryptomount (grub_extcmd_context_t ctxt, int argc, char **args) disk = grub_disk_open (diskname); if (!disk) { + grub_cryptodisk_clear_key_cache (&cargs); if (disklast) *disklast = ')'; return grub_errno; @@ -1430,12 +1537,14 @@ grub_cmd_cryptomount (grub_extcmd_context_t ctxt, int argc, char **args) { grub_dprintf ("cryptodisk", "already mounted as crypto%lu\n", dev->id); grub_disk_close (disk); + grub_cryptodisk_clear_key_cache (&cargs); if (disklast) *disklast = ')'; return GRUB_ERR_NONE; } dev = grub_cryptodisk_scan_device_real (diskname, disk, &cargs); + grub_cryptodisk_clear_key_cache (&cargs); grub_disk_close (disk); if (disklast) @@ -1576,6 +1685,7 @@ GRUB_MOD_INIT (cryptodisk) cmd = grub_register_extcmd ("cryptomount", grub_cmd_cryptomount, 0, N_("[ [-p password] | [-k keyfile" " [-O keyoffset] [-S keysize] ] ] [-H file]" + " [-P protector [-P protector ...]]" " "), N_("Mount a crypto device."), options); grub_procfs_register ("luks_script", &luks_script); diff --git a/include/grub/cryptodisk.h b/include/grub/cryptodisk.h index d94df68b6..0b41e249e 100644 --- a/include/grub/cryptodisk.h +++ b/include/grub/cryptodisk.h @@ -70,6 +70,18 @@ typedef gcry_err_code_t (*grub_cryptodisk_rekey_func_t) (struct grub_cryptodisk *dev, grub_uint64_t zoneno); +struct grub_cryptomount_cached_key +{ + grub_uint8_t *key; + grub_size_t key_len; + + /* + * The key protector associated with this cache entry failed, so avoid it + * even if the cached entry (an instance of this structure) is empty. + */ + int invalid; +}; + struct grub_cryptomount_args { /* scan: Flag to indicate that only bootable volumes should be decrypted */ @@ -81,6 +93,10 @@ struct grub_cryptomount_args /* recover_key: Length of key_data */ grub_size_t key_len; grub_file_t hdr_file; + /* recover_key: Names of the key protectors to use (NULL-terminated) */ + char **protectors; + /* recover_key: Key cache to avoid invoking the same key protector twice */ + struct grub_cryptomount_cached_key *key_cache; }; typedef struct grub_cryptomount_args *grub_cryptomount_args_t; -- 2.35.3