Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92AF4A2A for ; Sat, 15 Apr 2023 03:19:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681528756; x=1713064756; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=At3LVELmCIhiFDSkZqqJumA4m68e9mNIxzyuLdqNRmI=; b=HuWoTnWoPNS8OCUZQ6DlW/B8MDWcLv7ZPj3YFTP8u7GKhuZ8gHrz43bI R0Vi8n0L2BeVHY/P2wbLBG7gyPafNe9pLIYwWBv03IrAJgX4IVGvpD8H8 en+jTWONpzhLH8qA1q8Ayi9EUF3rH5Ikb+57+cFGACTUPfJgrsu3PTsf1 VuQzDcmj07CsRmEGWgMly5Y6UnZkVWjARmUqjE3mOKOvnTo1IUpbMZgqY lStC+6uDbl6Bz+gI+oAc8s6YoSTk0iqvjukIcBtTew0A6+eNXlthQnCre cR//Dr6Bhx/8pZLmpDalMI4PhMz5WKEv7XStZHhma87/WMOt+4umFM7y+ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10680"; a="324234619" X-IronPort-AV: E=Sophos;i="5.99,198,1677571200"; d="scan'208";a="324234619" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2023 20:19:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10680"; a="1019792045" X-IronPort-AV: E=Sophos;i="5.99,198,1677571200"; d="scan'208";a="1019792045" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by fmsmga005.fm.intel.com with ESMTP; 14 Apr 2023 20:19:12 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pnWRO-000aMV-2Y; Sat, 15 Apr 2023 03:19:06 +0000 Date: Sat, 15 Apr 2023 11:18:16 +0800 From: kernel test robot To: Marco Pagani Cc: oe-kbuild-all@lists.linux.dev Subject: Re: [RFC PATCH v3 4/4] fpga: add initial KUnit test suites Message-ID: <202304151151.Ja0JFj5q-lkp@intel.com> References: <20230414163636.236174-5-marpagan@redhat.com> Precedence: bulk X-Mailing-List: oe-kbuild-all@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230414163636.236174-5-marpagan@redhat.com> Hi Marco, [This is a private test report for your RFC patch.] kernel test robot noticed the following build errors: [auto build test ERROR on 09a9639e56c01c7a00d6c0ca63f4c7c41abe075d] url: https://github.com/intel-lab-lkp/linux/commits/Marco-Pagani/fpga-add-fake-FPGA-manager/20230415-003918 base: 09a9639e56c01c7a00d6c0ca63f4c7c41abe075d patch link: https://lore.kernel.org/r/20230414163636.236174-5-marpagan%40redhat.com patch subject: [RFC PATCH v3 4/4] fpga: add initial KUnit test suites config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230415/202304151151.Ja0JFj5q-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/5883c4e0127553e7d1bba4ecb9c84f9409844122 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Marco-Pagani/fpga-add-fake-FPGA-manager/20230415-003918 git checkout 5883c4e0127553e7d1bba4ecb9c84f9409844122 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202304151151.Ja0JFj5q-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/fpga/tests/fake-fpga-region.c:170:1: error: expected ';' before 'static' 170 | static int fake_region_get_bridges(struct fpga_region *region) | ^~~~~~ In file included from drivers/fpga/tests/fake-fpga-region.c:12: drivers/fpga/tests/fake-fpga-region.c: In function 'fake_fpga_region_drv_init': >> drivers/fpga/tests/fake-fpga-region.c:255:24: error: 'fake_fpga_region_drv' undeclared (first use in this function); did you mean 'fake_fpga_region'? 255 | module_platform_driver(fake_fpga_region_drv); | ^~~~~~~~~~~~~~~~~~~~ include/linux/platform_device.h:245:36: note: in definition of macro 'platform_driver_register' 245 | __platform_driver_register(drv, THIS_MODULE) | ^~~ include/linux/platform_device.h:275:9: note: in expansion of macro 'module_driver' 275 | module_driver(__platform_driver, platform_driver_register, \ | ^~~~~~~~~~~~~ drivers/fpga/tests/fake-fpga-region.c:255:1: note: in expansion of macro 'module_platform_driver' 255 | module_platform_driver(fake_fpga_region_drv); | ^~~~~~~~~~~~~~~~~~~~~~ drivers/fpga/tests/fake-fpga-region.c:255:24: note: each undeclared identifier is reported only once for each function it appears in 255 | module_platform_driver(fake_fpga_region_drv); | ^~~~~~~~~~~~~~~~~~~~ include/linux/platform_device.h:245:36: note: in definition of macro 'platform_driver_register' 245 | __platform_driver_register(drv, THIS_MODULE) | ^~~ include/linux/platform_device.h:275:9: note: in expansion of macro 'module_driver' 275 | module_driver(__platform_driver, platform_driver_register, \ | ^~~~~~~~~~~~~ drivers/fpga/tests/fake-fpga-region.c:255:1: note: in expansion of macro 'module_platform_driver' 255 | module_platform_driver(fake_fpga_region_drv); | ^~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/device.h:32, from drivers/fpga/tests/fake-fpga-region.c:10: drivers/fpga/tests/fake-fpga-region.c: In function 'fake_fpga_region_drv_exit': >> drivers/fpga/tests/fake-fpga-region.c:255:24: error: 'fake_fpga_region_drv' undeclared (first use in this function); did you mean 'fake_fpga_region'? 255 | module_platform_driver(fake_fpga_region_drv); | ^~~~~~~~~~~~~~~~~~~~ include/linux/device/driver.h:269:24: note: in definition of macro 'module_driver' 269 | __unregister(&(__driver) , ##__VA_ARGS__); \ | ^~~~~~~~ drivers/fpga/tests/fake-fpga-region.c:255:1: note: in expansion of macro 'module_platform_driver' 255 | module_platform_driver(fake_fpga_region_drv); | ^~~~~~~~~~~~~~~~~~~~~~ drivers/fpga/tests/fake-fpga-region.c: In function 'fake_fpga_region_drv_init': include/linux/device/driver.h:265:1: error: control reaches end of non-void function [-Werror=return-type] 265 | } \ | ^ include/linux/platform_device.h:275:9: note: in expansion of macro 'module_driver' 275 | module_driver(__platform_driver, platform_driver_register, \ | ^~~~~~~~~~~~~ drivers/fpga/tests/fake-fpga-region.c:255:1: note: in expansion of macro 'module_platform_driver' 255 | module_platform_driver(fake_fpga_region_drv); | ^~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +255 drivers/fpga/tests/fake-fpga-region.c 34b28b44394492 Marco Pagani 2023-04-14 169 34b28b44394492 Marco Pagani 2023-04-14 @170 static int fake_region_get_bridges(struct fpga_region *region) 34b28b44394492 Marco Pagani 2023-04-14 171 { 34b28b44394492 Marco Pagani 2023-04-14 172 struct fake_region_priv *priv; 34b28b44394492 Marco Pagani 2023-04-14 173 struct bridge_elem *elem; 34b28b44394492 Marco Pagani 2023-04-14 174 int ret; 34b28b44394492 Marco Pagani 2023-04-14 175 34b28b44394492 Marco Pagani 2023-04-14 176 priv = region->priv; 34b28b44394492 Marco Pagani 2023-04-14 177 34b28b44394492 Marco Pagani 2023-04-14 178 /* Copy the list of bridges from the private context to the region */ 34b28b44394492 Marco Pagani 2023-04-14 179 list_for_each_entry(elem, &priv->bridge_list, node) { 34b28b44394492 Marco Pagani 2023-04-14 180 ret = fpga_bridge_get_to_list(elem->bridge->dev.parent, 34b28b44394492 Marco Pagani 2023-04-14 181 region->info, 34b28b44394492 Marco Pagani 2023-04-14 182 ®ion->bridge_list); 34b28b44394492 Marco Pagani 2023-04-14 183 if (ret) 34b28b44394492 Marco Pagani 2023-04-14 184 break; 34b28b44394492 Marco Pagani 2023-04-14 185 } 34b28b44394492 Marco Pagani 2023-04-14 186 34b28b44394492 Marco Pagani 2023-04-14 187 return ret; 34b28b44394492 Marco Pagani 2023-04-14 188 } 34b28b44394492 Marco Pagani 2023-04-14 189 34b28b44394492 Marco Pagani 2023-04-14 190 static int fake_fpga_region_probe(struct platform_device *pdev) 34b28b44394492 Marco Pagani 2023-04-14 191 { 34b28b44394492 Marco Pagani 2023-04-14 192 struct device *dev; 34b28b44394492 Marco Pagani 2023-04-14 193 struct fpga_region *region; 34b28b44394492 Marco Pagani 2023-04-14 194 struct fpga_manager *mgr; 34b28b44394492 Marco Pagani 2023-04-14 195 struct fake_region_data *pdata; 34b28b44394492 Marco Pagani 2023-04-14 196 struct fake_region_priv *priv; 34b28b44394492 Marco Pagani 2023-04-14 197 struct fpga_region_info info; 34b28b44394492 Marco Pagani 2023-04-14 198 static int id_count; 34b28b44394492 Marco Pagani 2023-04-14 199 34b28b44394492 Marco Pagani 2023-04-14 200 dev = &pdev->dev; 34b28b44394492 Marco Pagani 2023-04-14 201 pdata = dev_get_platdata(dev); 34b28b44394492 Marco Pagani 2023-04-14 202 34b28b44394492 Marco Pagani 2023-04-14 203 if (!pdata) { 34b28b44394492 Marco Pagani 2023-04-14 204 dev_err(&pdev->dev, "Missing platform data\n"); 34b28b44394492 Marco Pagani 2023-04-14 205 return -EINVAL; 34b28b44394492 Marco Pagani 2023-04-14 206 } 34b28b44394492 Marco Pagani 2023-04-14 207 34b28b44394492 Marco Pagani 2023-04-14 208 priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); 34b28b44394492 Marco Pagani 2023-04-14 209 if (!priv) 34b28b44394492 Marco Pagani 2023-04-14 210 return -ENOMEM; 34b28b44394492 Marco Pagani 2023-04-14 211 34b28b44394492 Marco Pagani 2023-04-14 212 mgr = fpga_mgr_get(pdata->mgr->dev.parent); 34b28b44394492 Marco Pagani 2023-04-14 213 if (IS_ERR(mgr)) 34b28b44394492 Marco Pagani 2023-04-14 214 return PTR_ERR(mgr); 34b28b44394492 Marco Pagani 2023-04-14 215 34b28b44394492 Marco Pagani 2023-04-14 216 INIT_LIST_HEAD(&priv->bridge_list); 34b28b44394492 Marco Pagani 2023-04-14 217 priv->id = id_count++; 34b28b44394492 Marco Pagani 2023-04-14 218 priv->test = pdata->test; 34b28b44394492 Marco Pagani 2023-04-14 219 34b28b44394492 Marco Pagani 2023-04-14 220 memset(&info, 0, sizeof(info)); 34b28b44394492 Marco Pagani 2023-04-14 221 info.priv = priv; 34b28b44394492 Marco Pagani 2023-04-14 222 info.mgr = mgr; 34b28b44394492 Marco Pagani 2023-04-14 223 info.get_bridges = fake_region_get_bridges; 34b28b44394492 Marco Pagani 2023-04-14 224 34b28b44394492 Marco Pagani 2023-04-14 225 region = fpga_region_register_full(dev, &info); 34b28b44394492 Marco Pagani 2023-04-14 226 if (IS_ERR(region)) { 34b28b44394492 Marco Pagani 2023-04-14 227 fpga_mgr_put(mgr); 34b28b44394492 Marco Pagani 2023-04-14 228 return PTR_ERR(region); 34b28b44394492 Marco Pagani 2023-04-14 229 } 34b28b44394492 Marco Pagani 2023-04-14 230 34b28b44394492 Marco Pagani 2023-04-14 231 platform_set_drvdata(pdev, region); 34b28b44394492 Marco Pagani 2023-04-14 232 34b28b44394492 Marco Pagani 2023-04-14 233 return 0; 34b28b44394492 Marco Pagani 2023-04-14 234 } 34b28b44394492 Marco Pagani 2023-04-14 235 34b28b44394492 Marco Pagani 2023-04-14 236 static int fake_fpga_region_remove(struct platform_device *pdev) 34b28b44394492 Marco Pagani 2023-04-14 237 { 34b28b44394492 Marco Pagani 2023-04-14 238 struct fpga_region *region = platform_get_drvdata(pdev); 34b28b44394492 Marco Pagani 2023-04-14 239 struct fpga_manager *mgr = region->mgr; 34b28b44394492 Marco Pagani 2023-04-14 240 34b28b44394492 Marco Pagani 2023-04-14 241 fpga_mgr_put(mgr); 34b28b44394492 Marco Pagani 2023-04-14 242 fpga_region_unregister(region); 34b28b44394492 Marco Pagani 2023-04-14 243 34b28b44394492 Marco Pagani 2023-04-14 244 return 0; 34b28b44394492 Marco Pagani 2023-04-14 245 } 34b28b44394492 Marco Pagani 2023-04-14 246 34b28b44394492 Marco Pagani 2023-04-14 247 static struct platform_driver fake_fpga_region_drv = { 34b28b44394492 Marco Pagani 2023-04-14 248 .driver = { 34b28b44394492 Marco Pagani 2023-04-14 249 .name = FAKE_FPGA_REGION_DEV_NAME 34b28b44394492 Marco Pagani 2023-04-14 250 }, 34b28b44394492 Marco Pagani 2023-04-14 251 .probe = fake_fpga_region_probe, 34b28b44394492 Marco Pagani 2023-04-14 252 .remove = fake_fpga_region_remove, 34b28b44394492 Marco Pagani 2023-04-14 253 }; 34b28b44394492 Marco Pagani 2023-04-14 254 34b28b44394492 Marco Pagani 2023-04-14 @255 module_platform_driver(fake_fpga_region_drv); 34b28b44394492 Marco Pagani 2023-04-14 256 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests