Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B44D2C77B61 for ; Fri, 21 Apr 2023 17:12:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3550986297; Fri, 21 Apr 2023 19:12:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id ECA808629E; Fri, 21 Apr 2023 19:12:41 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id A866086296 for ; Fri, 21 Apr 2023 19:12:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B551015A1; Fri, 21 Apr 2023 10:13:22 -0700 (PDT) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2FD133F6C4; Fri, 21 Apr 2023 10:12:38 -0700 (PDT) Date: Fri, 21 Apr 2023 15:03:25 +0100 From: Andre Przywara To: Peter Hoyes Cc: u-boot@lists.denx.de, fenghua@phytium.com.cn, liviu.dudau@foss.arm.com Subject: Re: [PATCH 1/3] vexpress64: Use OF_HAS_PRIOR_STAGE for BASE_FVP variant Message-ID: <20230421150325.2142e391@donnerap.cambridge.arm.com> In-Reply-To: <20230331085813.321590-1-peter.hoyes@arm.com> References: <20230331085813.321590-1-peter.hoyes@arm.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri, 31 Mar 2023 09:58:11 +0100 Peter Hoyes wrote: > From: Peter Hoyes > > BASE_FVP now typically uses a devicetree provided by a prior boot stage > (typically Arm TF-A), so imply this option by default when > TARGET_VEXPRESS64_BASE_FVP is selected. > > OF_HAS_PRIOR_STAGE selects OF_BOARD so this change is minor, but aligns > TARGET_VEXPRESS64_BASE_FVP with TARGET_VEXPRESS64_BASER_FVP. Yeah, makes sense. Both secure firmware implementations commonly used (boot-wrapper and TF-A) provide a DTB. > Signed-off-by: Peter Hoyes Reviewed-by: Andre Przywara Cheers, Andre > --- > board/armltd/vexpress64/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/armltd/vexpress64/Kconfig b/board/armltd/vexpress64/Kconfig > index 5616e223a9..bd15cbeb7e 100644 > --- a/board/armltd/vexpress64/Kconfig > +++ b/board/armltd/vexpress64/Kconfig > @@ -23,7 +23,7 @@ choice > config TARGET_VEXPRESS64_BASE_FVP > bool "Support Versatile Express ARMv8a FVP BASE model" > select VEXPRESS64_BASE_MODEL > - select OF_BOARD > + imply OF_HAS_PRIOR_STAGE > > config TARGET_VEXPRESS64_BASER_FVP > bool "Support Versatile Express ARMv8r64 FVP BASE model"