Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B147C77B7C for ; Tue, 25 Apr 2023 22:24:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC9CB6B0071; Tue, 25 Apr 2023 18:24:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A79BB6B0072; Tue, 25 Apr 2023 18:24:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 941196B0074; Tue, 25 Apr 2023 18:24:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 82A986B0071 for ; Tue, 25 Apr 2023 18:24:58 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 49709160237 for ; Tue, 25 Apr 2023 22:24:58 +0000 (UTC) X-FDA: 80721344676.06.CC089E5 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by imf10.hostedemail.com (Postfix) with ESMTP id 90829C0014 for ; Tue, 25 Apr 2023 22:24:56 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=rtE+w3+E; spf=pass (imf10.hostedemail.com: domain of jim.cromie@gmail.com designates 209.85.166.174 as permitted sender) smtp.mailfrom=jim.cromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682461496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=CuJKxfEGJnOY6oqokaUbcqI0hvo9kY/6oilZjxK5wcg=; b=hqGPXv4wgUN9p7w9AvbZJVZx/ghSarp2TaKrIY3n+zZL26btOsthgBLt4WXMpUs1ns1SmH 1Juwbh3424uaFbg+b7QcNixEJGsQKkkeVUSAFPvOJfrbSbLiRbQhDz7yM3/QRRdv7iyDuI wFSU4gZuuWUqfwBo+Kz79pZ8/oZiGzw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=rtE+w3+E; spf=pass (imf10.hostedemail.com: domain of jim.cromie@gmail.com designates 209.85.166.174 as permitted sender) smtp.mailfrom=jim.cromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682461496; a=rsa-sha256; cv=none; b=16gW/E+vQUieL6/JEg5bstoESDinCg8tUIoZU+DXVVy+AI9CG0JNYAFqhh1J/C2F5yNh9n rsjyM7zdPx4gMyKye6ZEQp/gYUVXYaaXGx1UqGGTvN+H8ufmd99QTdiJS60o4YV2rz1kBh 3fOrjDIw3Uw52fJm21XFtmT8iZBuMy0= Received: by mail-il1-f174.google.com with SMTP id e9e14a558f8ab-32a89b6f185so53292355ab.2 for ; Tue, 25 Apr 2023 15:24:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682461495; x=1685053495; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CuJKxfEGJnOY6oqokaUbcqI0hvo9kY/6oilZjxK5wcg=; b=rtE+w3+EToaewzliFYao4Gx1k1pEZ50a7374ouPdyz4c9KyTOyvd0qX4+vebjUT91O 1ehLcOt1ZPq7IzncS6xzKdJ79V0s3ZCo3kcZ75G/bvNsoRy14lqGkvTxe68CAylZVZYM qGyvp0tFX/j14geYVbbAFAT5byjRneS86DEmz9rYYvxcmaesNBelbG95489L/VrsFOtQ 316WnTF7sBRgxos/V7TCcVznwNurt5hIIeXNeOLZoZx+G6jUUDWN255/qQfiAFtAz3kQ n6YtmMdgn8mX8nKUTx1zhh2ppHt9lHH1qB5AfIyGFFcAXG8avY/NWw6P0HIs7pAoYUPh 2Kcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682461495; x=1685053495; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CuJKxfEGJnOY6oqokaUbcqI0hvo9kY/6oilZjxK5wcg=; b=RJhPiw2aSvigt+QUtjZMj5wQgeh298wbanENlVODbMl1l7Ie7oNz42AiKGoPHovnLt JEaKV2mytnQh2aLDJHx0ANmd8irDgglwTsRiGFecJ4/pIqoqvEHH6Q/xziQyDjOz44Q8 ah2jJqcrDfwcUyhr+gAK/QtrrnyIgdcl0VQhOkvsXVSkr752s3+rd78SlcXrTeHpB4as e0WriTBtjV18UawJIDPjUyI5NR+FYHlmhfiTP1u3m8tvlcqZdFy+6LZCzyB0m4kwHbyI 6wNByXEZoQYr+0CEHB62mFD28ZAdNt9TmqhjUWuA29+1LXH6oNc+5CORuik49gJhaEGO Xz0A== X-Gm-Message-State: AAQBX9eF/ml/ckHTaKXa6AY+NhRXuy4HrQtHVAmf9LY8pOhigxjZ2GgS 89XD2ElxWvUJQvKmjjnIMUg= X-Google-Smtp-Source: AKy350a8yjGj8+9pDxme1/97N0vQc1KuCnae7bWnGIYBb0cQDqinbFIbGE3MZ3Vhrzx+/3bDXvetmA== X-Received: by 2002:a92:d40d:0:b0:317:c80f:b416 with SMTP id q13-20020a92d40d000000b00317c80fb416mr8313209ilm.20.1682461495601; Tue, 25 Apr 2023 15:24:55 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id 13-20020a92180d000000b003244d7f2292sm3833008ily.32.2023.04.25.15.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 15:24:55 -0700 (PDT) From: Jim Cromie To: catalin.marinas@arm.com, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Jim Cromie Subject: [PATCH 0/3] kmemleak report format changes Date: Tue, 25 Apr 2023 16:24:43 -0600 Message-Id: <20230425222446.170486-1-jim.cromie@gmail.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 90829C0014 X-Stat-Signature: do8qqfygoyxip151qfbieifur818zjrc X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1682461496-141710 X-HE-Meta: U2FsdGVkX1+UWLmtT5RXmtCD9E0W5yMj0kpGfL1aO7VKUiCJXGKQg+6FTFWlC9m9nXmI6IojndD1CSO3vwsn7/7wqviSHVrwIBgiDNXX3qs/yPwT/yLLPSMi6U2eXrKtflWDRUfsJOoD0MKiz8KeUaf/28xznLecglypGehz4M+crLwb1h/z1eo6wfV9zFjHJK6MO++Frt/EIVJu1W5LRX6EFdGX0t63qBeFvz+AnQiVySrumhIxSMrfI1GSpkQH3dP2w0rZFvOrdGMQl2/SMl1ZC8Q4jAftCpkHjC7eXBRQZXud9chHpWBuExTQh45Gr5Zl5Wz3+N6clfQfJccU38lwzvLuxwvs57t1ak+EHTsmiS+bkK3Mvk4JhjSrZi52cxAlRIOYgnirwzTh66K5DJJ3nIH6uy91j6j5YTiCKIaL7SSVdM6dB8PJ8UlNRxzAoRMvyu5zqjP17Pl0B3ljXL4YxMeP4vAjMMsNhC2LF7o84XqRan8d+dtb5Gm9RUgdC7MsvRQZ2jVb8qgqi/Np2EHohvL7DoOK+dBI4cT4GvtnMXZUT2oVUzDyRP7u9GkOwoUVlxAB/P+we6nCdOIr1ggyShqZFtM32l3ySB8bVNP8hqXC7WHlXVYOODIT9QDoZX78o+uz18/wCzUGxTdqblhkK5kH7GenifX5JsqXstfjjwjcyFpgn62qTEvv5T30vVT2mnZA/1L82zm1AD0bRV/NIQsePqT/j9ewydNiauHG6hmy9Svzgtk5eeMnbm8j4Ut5+KiVNsAL3PJK86+G/L0sNCKoDNhwEKRQa8HbsCz5Lk2NqvZJc+XE3nkFJPOTNQog1qgKHLveZPJBLzTZ0PjZ396ofyO3B2a6sU+/qYLKCVUCRqpQ6XRUXqmB8RLL7HRO3c4kBn1i3ZYDg8J3i4haNO/QBMR7qXPjp9d4jc3JZEywQjxyGU20AckdbZIQQrIcfU5/o0lNwvo0Evo DV2tQ0fs 9ig63676Uq5moKJPZk0uuIrp7Det8Fz9lPZuvKvM11dJy+AjNlaUTCOLLlWAEtm6x2Olw0rSsaXZPfw5Rk4qNwif3Z0gUVDLZGsuKKb5sLdkEVHSCViqHxaZQWD7DqfgwZX9FZOXTBBCv48q3WlNtvuoKvYUTGltI4Js6A5F+oVWrDsrQBIpzKxiCHCw8XqnTQjIeNweK2V/o/VVmhxOASt9/vr/OQubvT/3pCATlSTfL5pFqEJO5qJZBT62+HpsTDPHuIDxbxHWeLS7CgtPOUrpuoivCx8xapP+JVXxFU7LJ7slRxdxBILQJvQuGi1mS9IE9MWU9vNLNpELh5pExTwJn7iYSxkMGvEVoJJcFMZYmgUoos3b4tNRYSbsPYltZGEttH9A+xPHFf9oCjV0ONklR3gx5O2GjtJOHdtzQUY7D16gO25I0l1IsSyhZe7ydV5KkdUYOaxeBkmEVPCfFDuLsiMvQDKnPG/uPDjNkVu6G6QvQfjuZ1Gphe1VCPlQFdmxMkPdm7dyQ3eI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If format changes are not /sys/** ABI violating, heres 3 minor ones: 1st strips "age " from output. This makes the output idempotent; unchanging until a new leak is reported. 2nd adds the backtrace.checksum to the "backtrace:" line. This lets a user see repeats without actually reading the whole backtrace. So now the backtrace line looks like this: backtrace (ck 603070071): # also see below Q: should ck be spelled crc ? it feels more communicative. NB: with ck exposed, it becomes possible to do a "selective clear", something like: echo drop 603070071 > /sys/kernel/debug/kmemleak The 3rd patch takes __init off of kmemleak_test_init(). This fixes a bare-pointer in the 2nd line of the backtrace below, which previously looked like: [<00000000ef738764>] 0xffffffffc02350a2 NB: this happens still/again, after rmmod kmemleak-test. unreferenced object 0xffff888005d9ca40 (size 32): comm "modprobe", pid 412, jiffies 4294703300 hex dump (first 32 bytes): 00 cd d9 05 80 88 ff ff 40 cf d9 05 80 88 ff ff ........@....... 14 a7 c4 f6 7d f9 87 10 00 00 00 00 00 00 00 00 ....}........... backtrace (ck 1354775490): [<000000002c474f61>] kmalloc_trace+0x26/0x90 [<00000000b26599c1>] kmemleak_test_init+0x58/0x2d0 [kmemleak_test] [<0000000044d13990>] do_one_initcall+0x43/0x210 [<00000000131bc505>] do_init_module+0x4a/0x210 [<00000000b2902890>] __do_sys_finit_module+0x93/0xf0 [<00000000673fdce2>] do_syscall_64+0x34/0x80 [<00000000357a2d80>] entry_SYSCALL_64_after_hwframe+0x46/0xb0 Jim Cromie (3): kmemleak: drop (age ) from leak record kmemleak: add checksum to backtrace report kmemleak-test: drop __init to get better backtrace mm/kmemleak.c | 8 +++----- samples/kmemleak/kmemleak-test.c | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) -- 2.40.0