Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5024FC77B7F for ; Mon, 1 May 2023 18:53:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 652A2862BA; Mon, 1 May 2023 20:53:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ap4BvAFL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4478B8625C; Mon, 1 May 2023 20:53:56 +0200 (CEST) Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 27A1E862BA for ; Mon, 1 May 2023 20:53:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-55a8e9e2c53so737087b3.1 for ; Mon, 01 May 2023 11:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1682967231; x=1685559231; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BP9dnAYyJwz/7kIFSWadeR5ydn/LRfGh9dxl/8QG36s=; b=ap4BvAFLypZYgPHOGFJdIkhhqgiDSmSAapJwDXTxR6qyO60uwytTYlDlBTo16qY3mm xnBbfVAx3l4/DrXByLsSIde0G3MU518jxtH0S3LkMEU7fQxX9WYgK3sMrrpOHr1Kw0eE ru97IpdFxFvBcW33rUZfgT485CG7H/GQoXEMA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682967231; x=1685559231; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BP9dnAYyJwz/7kIFSWadeR5ydn/LRfGh9dxl/8QG36s=; b=M1nFsI94ublMdpIPDcEtZW1owhclJhDB0jCfNZxyYIx3lU04qb+zFAyQMwzA2luz8m UykYdHlbC+I0Q8cZ7iV954e3PUB3IjeCiweKQR0uw+BYWhwkPgoq12qnBQjvOovhRvSq uPuMGfBtdZtRe1hR0ISXkmbIyoJAufUN0pmlMks8NyLP0wmblZvtMR4FviwR6UtyCElG AIISqi9fSuUs7INKv1H99CtqAkbXjaWn5/gyZ/6W1FRUhg6c+JUaiTob56zMGBHyi/nQ RIEzJfhTbOJmh26YjZ5SBrx+EQWuZoA0jm5Hrq0F3GOH4Z7uRBEQXiXMFNyIs8gzoxG+ tsIA== X-Gm-Message-State: AC+VfDwEXCH+HM/CEKs5yV4UEvsXzfXxC/GVDqM9PjuYS7g75I98txoJ O9PG1mKJA5nDOMH7tivNG6eXCK1F0jwwXTu7cv2bAQ== X-Google-Smtp-Source: ACHHUZ5qtbTxk8JECY3VClW3/5YevRm+A1LBDVlFyBVTE9lBqNo3sU2thfOUTgi7wh7oqc1E2Yo4Cg== X-Received: by 2002:a0d:ff05:0:b0:54f:a8cf:6b44 with SMTP id p5-20020a0dff05000000b0054fa8cf6b44mr12637748ywf.2.1682967230862; Mon, 01 May 2023 11:53:50 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-d140-a0bb-6bbe-7743.res6.spectrum.com. [2603:6081:7b00:6400:d140:a0bb:6bbe:7743]) by smtp.gmail.com with ESMTPSA id n5-20020a255905000000b00b9d8a0a65c7sm1642900ybb.3.2023.05.01.11.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 11:53:50 -0700 (PDT) Date: Mon, 1 May 2023 14:53:48 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Lukasz Majewski Subject: Re: [PATCH] usb: gadget: Compile USB ethernet gadget only if NET is enabled Message-ID: <20230501185348.GF1134230@bill-the-cat> References: <20230430212035.379838-1-marex@denx.de> <20230501134756.GX1134230@bill-the-cat> <20230501172333.GE1134230@bill-the-cat> <9eef63ed-ccdd-77bf-8255-b5c8a19dad41@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fMdpL7eftzT1ALfu" Content-Disposition: inline In-Reply-To: <9eef63ed-ccdd-77bf-8255-b5c8a19dad41@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --fMdpL7eftzT1ALfu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 01, 2023 at 07:40:57PM +0200, Marek Vasut wrote: > On 5/1/23 19:23, Tom Rini wrote: > > On Mon, May 01, 2023 at 06:53:52PM +0200, Marek Vasut wrote: > > > On 5/1/23 15:47, Tom Rini wrote: > > > > On Sun, Apr 30, 2023 at 11:20:35PM +0200, Marek Vasut wrote: > > > >=20 > > > > > In case NET networking is not enabled, it is not possible to comp= ile > > > > > the USB ethernet gadget. Protect the symbols in Makefile to avoid= build > > > > > failure. Such build failure may occur e.g. in case NET and USB et= hernet > > > > > gadget is enabled in U-Boot proper, but not in SPL. > > > > >=20 > > > > > Signed-off-by: Marek Vasut > > > > > --- > > > > > Cc: Lukasz Majewski > > > > > --- > > > > > drivers/usb/gadget/Makefile | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > >=20 > > > > > diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Mak= efile > > > > > index 6cfe0f3a041..36f65e7eb95 100644 > > > > > --- a/drivers/usb/gadget/Makefile > > > > > +++ b/drivers/usb/gadget/Makefile > > > > > @@ -34,8 +34,10 @@ endif > > > > > obj-$(CONFIG_CI_UDC) +=3D ci_udc.o > > > > > +ifeq ($(CONFIG_$(SPL_TPL_)NET),y) > > > > > obj-$(CONFIG_USB_ETHER) +=3D ether.o > > > > > obj-$(CONFIG_USB_ETH_RNDIS) +=3D rndis.o > > > > > +endif > > > > > # Devices not related to the new gadget layer depend on CONFIG= _USB_DEVICE > > > > > # This is really only N900 and USBTTY now. > > > >=20 > > > > Why can't we just enforce this via Kconfig? > > >=20 > > > Because there is no SPL/TPL USB_ETHER Kconfig . > > > Do we want to grow the Kconfig file with those instead ? > >=20 > > Ah right. Yes, we have SPL_USB_ETHER today >=20 > This is exactly the opposite of what I wrote. >=20 > And no, we do NOT have this symbol, see: >=20 > $ git grep SPL_USB_ETHER drivers/usb | wc -l > 0 Yes, it resides in common/spl/Kconfig --=20 Tom --fMdpL7eftzT1ALfu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmRQCrkACgkQFHw5/5Y0 tyzThgv/SvwqTdA8VVwZfg8qbDTXQraj6/SsisMns0AO5Y2eIj7VkmnYZM81b2Fk 3gjBT9SH2FZtmIGuj0RBG/0wd0heXO6Gmxamg2utAO9twGTm31Io2jpEboGXuwa2 B87ljBZuvMFJO4WFMj4A4+cv+x5HoPlzSXM6F75oSWjd720Z1tsMY02J3iUt7Q9I e+/nOufSm0GzSk4vedrH6Q/lEcSYSwdpvup+V6sxb1JzyQZlQM0sme22ubSYi3lW YcDBnFhaTx6s4FHKUEMHGh10u3HXU1SmOavBL+Fkkci4/VZnWI/+yXAfut6Eq7Ag 8mulkBXkZO+sN3SlwnofXZ9n4/4zUqfRyp81b5ThrE9Uvcj1YOLqOQqzHb2yXT9O IhuLn9a9cxOdS3rvmGRdvA9UzNMfUFYdtlbLC2yCZTFTxtob27Has4i/9v85IoZU fOLAoD1wLg0NgWG9Dz/2BAIEevWk9gz0ywUEeBqLGuz8trz9BXeYADgAE7bHKMdg 8D001G0H =CM8I -----END PGP SIGNATURE----- --fMdpL7eftzT1ALfu--