Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62179C77B75 for ; Fri, 5 May 2023 22:03:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 201D985D8B; Sat, 6 May 2023 00:03:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="bqQcF6YW"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DDC2985DB0; Sat, 6 May 2023 00:03:08 +0200 (CEST) Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 991EE85CD8 for ; Sat, 6 May 2023 00:03:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-b9a6ab9ede3so3077829276.2 for ; Fri, 05 May 2023 15:03:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1683324185; x=1685916185; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+Cxq5+EGSFrvJM9sskwVQm4+rwwWrfB6qzbHnWjFFzs=; b=bqQcF6YWalhQd8x2e/eDjp544hCLW71UHUPmPQhslc4e6ACmAexSc0N4TPurJmKPUJ tKBRilN8RPjPTYD7eIE6ucu8KAs0mHK8JbjizSuKz/nKie6JOguQvh8JwmGOLRUIzUP6 dlrTDBVZWqYm2VxMA45V1WhpmMpYUKs4HnXvM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683324185; x=1685916185; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+Cxq5+EGSFrvJM9sskwVQm4+rwwWrfB6qzbHnWjFFzs=; b=BpMXFIWqiPYLryUxtrx//g6dh8JDXWG5ub4Xx1aqjFQ9TY3SVg0tDexsTlankXh8eI Y/1vf4nWZZd1ZjnXKUVlcediIWQ0mr+y/z9xK4fKejs3+3pScu+zl3IGOLWr2LTB7n8P 0lK7sT2bYuccfpHbgX45F6zaGOC7YBjC3PJoiNpWysLbsmJlfgra5hCwvlGLpzdIif7Z o1jHgukTPozKrDh5C5eGMLgVJpzamS/RtPypY9LqaV5ZjCZBQSrOZlVIttPeq7J3fMV2 RK0BKOZi5zE1qTJ7qf0Wl4ziwlPce//5Oeg5U1uoPQ8N4N5ProBT44aQ8ABzHm/2RfA0 Aq3A== X-Gm-Message-State: AC+VfDza2YPEA0wudocky+AZMXOJrKUJBTLDYoNfTGqNknteD96uSlk9 BZ2iqf7i/o+xG9fcRnGngFWb3A== X-Google-Smtp-Source: ACHHUZ5QN4hbzQvhXqZijuXGr1cXUfNLGp2/kQiIMdBHa5kx5l2LXAol6dQH2T45TDgKO/WH8LFI5w== X-Received: by 2002:a25:1542:0:b0:b9e:84b0:bfa6 with SMTP id 63-20020a251542000000b00b9e84b0bfa6mr2993811ybv.25.1683324185191; Fri, 05 May 2023 15:03:05 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-4494-b767-dca3-461d.res6.spectrum.com. [2603:6081:7b00:6400:4494:b767:dca3:461d]) by smtp.gmail.com with ESMTPSA id t9-20020a254609000000b00b993b8e0e4bsm725653yba.38.2023.05.05.15.03.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 15:03:04 -0700 (PDT) Date: Fri, 5 May 2023 18:03:03 -0400 From: Tom Rini To: Eugen Hristev Cc: u-boot@lists.denx.de, joe.hershberger@ni.com, jonas@kwiboo.se, jagan@edgeble.ai, kever.yang@rock-chips.com Subject: Re: [PATCH 2/2] configs: rock5b-rk3588: add rtl8169 driver Message-ID: <20230505220303.GA2499096@bill-the-cat> References: <20230425130659.62361-1-eugen.hristev@collabora.com> <20230425130659.62361-2-eugen.hristev@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HltOGz1c0xDMrXvY" Content-Disposition: inline In-Reply-To: <20230425130659.62361-2-eugen.hristev@collabora.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --HltOGz1c0xDMrXvY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 25, 2023 at 04:06:59PM +0300, Eugen Hristev wrote: > Add the rtl8169 driver, which supports the rtl8125b device, which is > connected on the pciE bus on this board. > Enable also CONFIG_SYS_HAS_NONCACHED_MEMORY to have the descriptors store= d. >=20 > Signed-off-by: Eugen Hristev > --- > configs/rock5b-rk3588_defconfig | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defc= onfig > index a14fcd2ee924..bfa48227aee2 100644 > --- a/configs/rock5b-rk3588_defconfig > +++ b/configs/rock5b-rk3588_defconfig > @@ -1,5 +1,6 @@ > CONFIG_ARM=3Dy > CONFIG_SKIP_LOWLEVEL_INIT=3Dy > +CONFIG_SYS_HAS_NONCACHED_MEMORY=3Dy > CONFIG_COUNTER_FREQUENCY=3D24000000 > CONFIG_ARCH_ROCKCHIP=3Dy > CONFIG_TEXT_BASE=3D0x00a00000 > @@ -71,6 +72,7 @@ CONFIG_MMC_SDHCI_SDMA=3Dy > CONFIG_MMC_SDHCI_ROCKCHIP=3Dy > CONFIG_SPI_FLASH_MACRONIX=3Dy > CONFIG_ETH_DESIGNWARE=3Dy > +CONFIG_RTL8169=3Dy > CONFIG_GMAC_ROCKCHIP=3Dy > CONFIG_PCI=3Dy > CONFIG_PCIE_DW_ROCKCHIP=3Dy Does this depend on some series I missed where PCI is enabled on this config? --=20 Tom --HltOGz1c0xDMrXvY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmRVfRQACgkQFHw5/5Y0 tyyglAv/WXdgcBHHkQ8aZRWk6ApDPkO737nZDjnzA/M0mhDgsBzf2+hNKwlAtP3B IeRz2ErlblyaDrGWyrJPrm2T3EUprz1C72KZskKpXkR1XhB7reshYeYe7pXhlZEf JjN1BxhKPjH1waDWXMiOPdJeA8p6eZfzbi7EIos+MaeL2z3HQLVJo+OfQ59iYTYE IC3NS1alskdTMzygD7m1V/1ObK88XhRuNYoM/7pkOh3k45MsqJcKZvN18EMqtKmP stm5/csdsQQAgT3gqUohjV1LIoIznEly1Ylk+P/Ey6DebDcTBNKhPpfA1YS79tbT qdRskeF5jlvCLqxP++zJ/J3MK/qmBncNNKAKTw69pKNSCZJkFJa7Ih+293ZO1N6f sI2NswmOnbt3BRgoq9xl7teZcLs+BWdAJr60TQa5seruqudCr+Ohs8t2pim7x13e 8ylRd+pAsToZQMoBguda7+vwMzryuHOXXOqWynJXO912nHb2l2DZI9fWxOIAfBGx V7FIA3jS =FGs2 -----END PGP SIGNATURE----- --HltOGz1c0xDMrXvY--