Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 759357C for ; Sun, 7 May 2023 09:52:20 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A9912F4; Sun, 7 May 2023 02:53:04 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D3C743F64C; Sun, 7 May 2023 02:52:16 -0700 (PDT) Date: Sun, 7 May 2023 10:52:01 +0100 From: Andre Przywara To: Maksim Kiselev Cc: Icenowy Zheng , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Cristian Ciocaltea , Maxime Ripard , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 4/5] spi: sun6i: add support for R329/D1/R528/T113s SPI controllers Message-ID: <20230507105201.530523b1@slackpad.lan> In-Reply-To: <20230506232616.1792109-5-bigunclemax@gmail.com> References: <20230506232616.1792109-1-bigunclemax@gmail.com> <20230506232616.1792109-5-bigunclemax@gmail.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 7 May 2023 02:26:07 +0300 Maksim Kiselev wrote: > These SoCs has two SPI controllers. One of it is quite similar to previous > ones, but with internal clock divider removed; the other added MIPI DBI > Type-C offload based on the first one. > > Add basical support for these controllers. As we're not going to > support the DBI functionality now, just implement the two kinds of > controllers as the same. > > Co-developed-by: Icenowy Zheng > Signed-off-by: Maksim Kiselev Reviewed-by: Andre Przywara Cheers, Andre > --- > drivers/spi/spi-sun6i.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c > index 1e9e9a8159d9..292fd6101283 100644 > --- a/drivers/spi/spi-sun6i.c > +++ b/drivers/spi/spi-sun6i.c > @@ -739,9 +739,17 @@ static const struct sun6i_spi_cfg sun8i_h3_spi_cfg = { > .has_clk_ctl = true, > }; > > +static const struct sun6i_spi_cfg sun50i_r329_spi_cfg = { > + .fifo_depth = SUN8I_FIFO_DEPTH, > +}; > + > static const struct of_device_id sun6i_spi_match[] = { > { .compatible = "allwinner,sun6i-a31-spi", .data = &sun6i_a31_spi_cfg }, > { .compatible = "allwinner,sun8i-h3-spi", .data = &sun8i_h3_spi_cfg }, > + { > + .compatible = "allwinner,sun50i-r329-spi", > + .data = &sun50i_r329_spi_cfg > + }, > {} > }; > MODULE_DEVICE_TABLE(of, sun6i_spi_match);