Date: Mon, 8 May 2023 13:55:34 +0200 (CEST) Message-Id: <202305081155.348BtYlh004143@...2054...> From: Gert Doering In-Reply-To: <20230414094227.9153-1-kprovost@...2661...> References: <20230414094227.9153-1-kprovost@...2661...> Subject: [Openvpn-devel] [PATCH applied] Re: DCO: support key rotation notifications List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Kristof Provost Cc: openvpn-devel@lists.sourceforge.net I have stared a bit at the code, and it all looks sane (though kp@ and Antonio are the experts here, anyway :-) ). I have not tested things beyond "passes client/server tests, with and without DCO" - my kernel does not have the new code bits yet (and for a real tests, one would have to modify it to send OVPN_NOTIF_ROTATE_KEY after like 1000 packets or so...). There were a few indentations that uncrustify did not like, so fixed those one the fly (only whitespace). Your patch has been applied to the master and release/2.6 branch (this is somewhere between "bugfix" and "long-term compatibility", and less of a "new feature"). commit ec71489bfc7c1d798f5f6de8e9fc187b9127072c (master) commit c468af2cd90c9f682519eff38a21fac8a3feb148 (release/2.6) Author: Kristof Provost Date: Fri Apr 14 11:42:27 2023 +0200 DCO: support key rotation notifications Signed-off-by: Kristof Provost Acked-by: Antonio Quartulli Message-Id: <20230414094227.9153-1-kprovost@...2661...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26590.html Signed-off-by: Gert Doering -- kind regards, Gert Doering