Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 835F0C7EE22 for ; Tue, 9 May 2023 17:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230124AbjEIRLt (ORCPT ); Tue, 9 May 2023 13:11:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233512AbjEIRLd (ORCPT ); Tue, 9 May 2023 13:11:33 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C78D6EE for ; Tue, 9 May 2023 10:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683652198; x=1715188198; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=n2Fgrw6xn6MZYVBpnki0BXXGAkz3fr3FL+kM3NhjGtk=; b=BihAu9byyh4oOhERGEk62SxZC8RyKGDz581zOkAKk6Q/BDIfxll9tD2Y hsuI8kAURCEB+p2knT8iAXtbS7LMC5N2OEJqoJeqMSWw8z18ERFH/kLE2 KhoZQHUfTyRALoq0kwje9/Br05J56Vt8Sv7O/iInGSGcZ0nVjfj03xjFy dPtNFCu9CHZozh5CXrWtK5YNdrJNi0Y+evUw3P2QD9qGNPWCO7xe0DpIv 6NcIrIvgBJ45szhVzIXYcrXuwdWd4vVr3F1JRMyRP/Q4bNTReVbDPotn2 ZVMTcNYm0TOQ00IljJgtjisKCqzVRCMIkWJ2uBHQNHzO00KOy7GrAGEtH w==; X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="352168610" X-IronPort-AV: E=Sophos;i="5.99,262,1677571200"; d="scan'208";a="352168610" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2023 10:09:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="1028889396" X-IronPort-AV: E=Sophos;i="5.99,262,1677571200"; d="scan'208";a="1028889396" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 09 May 2023 10:09:38 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 5F03617D; Tue, 9 May 2023 20:09:48 +0300 (EEST) Date: Tue, 9 May 2023 20:09:48 +0300 From: Mika Westerberg To: Hans de Goede Cc: "Rafael J . Wysocki" , Andy Shevchenko , linux-acpi@vger.kernel.org, Andy Shevchenko , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH v2] ACPI: LPSS: Add pwm_lookup_table entry for second PWM on CHT/BSW devices Message-ID: <20230509170948.GN66750@black.fi.intel.com> References: <20230509124100.288814-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230509124100.288814-1-hdegoede@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, May 09, 2023 at 02:41:00PM +0200, Hans de Goede wrote: > BSW PWM2 is used for backlight control for fixed (etched into the glass) > touch controls on some models. > > Add an entry for the second PWM controller to bsw_pwm_lookup, > so that drivers can use pwm_get() to get a reference to it. > > These touch-controls have specialized drivers which bind to different > devices on different models, so the consumer-device-name in the lookup > table entry is set to NULL, so that only con-id matching is used. > > The con-id is set to "pwm_soc_lpss_2" which describes the PWM controller > rather than the usual approach of describing its function. > The specialized (model specific) drivers which need access to the PWM > controller know they need the "pwm_soc_lpss_2" con-id. > > Reviewed-by: Andy Shevchenko > Acked-by: Uwe Kleine-König > Signed-off-by: Hans de Goede Reviewed-by: Mika Westerberg