Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FA31C77B7C for ; Wed, 10 May 2023 12:12:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C059610E48C; Wed, 10 May 2023 12:12:12 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 85FFE10E484 for ; Wed, 10 May 2023 12:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683720731; x=1715256731; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=W6d951HqdP6Rzl6X1eMpIhUEgy0arX7S6CklXaE1iQs=; b=RNLEeQgdaC076Fyx7pO9j4tnmcaw/mKs48Bb3YxrAEFYk3HvVRyQJQJm z58bMI0+cta2fp8y4OeZZIdGAFwk0P9ClDPXVHhUCQGT+JfkkBEYrne8L BrHD+1/QzkV5K7ny9l6FFK9NkeIUbMsQjyzhyFQLrdB8TvfWYlVjGUm94 GYb1RZ8E1MNm/iMBDFbtRnhd5IOFm99BrhfO9oZX/mRyrCf7V6ZiQ3LOY tuMraLdQn3hYMOzWqqS3DMqQi8iKs/NS7DnSZLVOtJOPtlBBZTK2crRd2 TCM06OZMVWNXjmP4lLyjPeFxDxk+FMQc1Ta8DVne3XKeeBN0VObmlsVsJ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="353268045" X-IronPort-AV: E=Sophos;i="5.99,264,1677571200"; d="scan'208";a="353268045" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2023 05:12:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="788905993" X-IronPort-AV: E=Sophos;i="5.99,264,1677571200"; d="scan'208";a="788905993" Received: from iisaev-mobl2.ger.corp.intel.com (HELO jhogande-mobl1.ger.corp.intel.com) ([10.252.62.141]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2023 05:12:06 -0700 From: =?UTF-8?q?Jouni=20H=C3=B6gander?= To: intel-xe@lists.freedesktop.org Date: Wed, 10 May 2023 15:11:29 +0300 Message-Id: <20230510121152.736148-1-jouni.hogander@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Transfer-Encoding: 8bit Subject: [Intel-xe] [RFC PATCH v2 00/23] Xe frontbuffer tracking X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jani.nikula@intel.com, Lucas De Marchi , =?UTF-8?q?Jouni=20H=C3=B6gander?= , Uma Shankar , Rodrigo Vivi , rodrigo.vivi@kernel.org, ville.syrjala@linux.intel.com Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" This patch set is taking frontbuffer tracking into use for Xe driver as well. This allows using custom dirtyfb ioctl implemented for i915 instead of doing full atomic commit on dirtyfb ioctl. It also provides support for CPU/GPU frontbuffer rendering with features like PSR, DRRS and FBC. Even as frontbuffer tracking is targeted being discontinued it is seen as too risky to remove it completely at this point. DirtyFB IOCTL Dirtyfb ioctl is modified to be dma fence aware: 1. If all the fences for the buffer dirtyfb ioctl is called on are all signaled perform flush. 2. If there are unsignaled fences for the buffer perform invalidate and add dma fence callback for them and initiate flushes when these each of these happens. Also perfrom flush immediately on each fence which are already signaled. i915 Patch set is keeping current frontbuffer tracking implementation as it is. It is just refactoring the code to allow using it with Xe driver as well. I915 is currently using hooks in gem code to perform frontbuffer tracking flush when GPU rendering completes. Patch set is initiating extra flushes which are perform on dma fence signaling. This will be triggering extra updates for features like PSR and FBC addition to the flush triggerd by the gem hooks. Xe Instead of modifying frontbuffer tracking for Xe driver this patch set is doing minimalistic changes to current implemenation and using it as needed for Xe as well. Functionality is pretty much same as with i915 driver. As Xe doesn't have gem hooks to trigger frontbuffer tracking flush it will be relying completely on dirtyfb ioctl and frontbuffer tracking flush initiated by the ioctl. This requires user-space using GPU frontbuffer rendering to import completion fence using dmabuf_import_sync_file. Also carrying intel_frontbuffer pointer in xe_bo is not done because we don't really need that as we don't have those gem hooks. Build Breakage In current form this patch set is breaking build between patches 2-20. I couldn't find reasonable way to keep build working as originally reverted frontbuffer tracking removal patches (2-3) are breaking build. Then this broken build is fixed later in several patches. v2: Remove intel_frontbuffer pointer from struct xe_bo Cc: Maarten Lankhorst Cc: Ville Syrjälä Cc: Uma Shankar Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Lucas De Marchi Jouni Högander (23): fixup! drm/i915/display: Remaining changes to make xe compile Revert "drm/i915/display: Neuter frontbuffer tracking harder" Revert "drm/i915: Remove gem and overlay frontbuffer tracking" fixup! drm/i915/display: Remaining changes to make xe compile fixup! drm/xe/display: Implement display support drm/i915: Add macros to get i915 device from i915_gem_object drm/xe: Add macro to get i915 device from xe_bo drm/i915: Add getter for i915_gem_object->frontbuffer drm/xe: Add frontbuffer setter/getter for xe_bo drm/i915/display: Remove i915_gem_object_types.h from intel_frontbuffer.h drm/xe: Add intel_bo_flush_if_display define for Xe drm/i915: Add intel_bo_flush_if_display define for i915 drm/xe: Add struct i915_active for Xe drm/xe: Add i915_active.h compatibility header drm/xe/display: Include i916_active header drm/i915: Add function to clear scanout flag for vmas drm/xe: Add empty define for i915_ggtt_clear_scanout drm/i915/display: Use i915_ggtt_clear_scanout drm/i915/display: Use drm_gem_object_get/put drm/xe/display: Use frontbuffer tracking for Xe as well drm/i915: Add new frontbuffer tracking interface to queue flush drm/i915: Handle dma fences in dirtyfb callback drm/xe/display: Use custom dirtyfb for Xe as well drivers/gpu/drm/i915/display/i9xx_plane.c | 1 - drivers/gpu/drm/i915/display/intel_cursor.c | 6 +- drivers/gpu/drm/i915/display/intel_display.c | 4 +- .../drm/i915/display/intel_display_types.h | 8 +- drivers/gpu/drm/i915/display/intel_fb.c | 75 +++++++++-- drivers/gpu/drm/i915/display/intel_fb_pin.c | 8 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 7 +- .../gpu/drm/i915/display/intel_frontbuffer.c | 127 ++++++++++++++++-- .../gpu/drm/i915/display/intel_frontbuffer.h | 43 ++++-- drivers/gpu/drm/i915/display/intel_overlay.c | 14 ++ .../drm/i915/display/intel_plane_initial.c | 3 +- drivers/gpu/drm/i915/display/intel_sprite.c | 1 - drivers/gpu/drm/i915/gem/i915_gem_clflush.c | 4 + drivers/gpu/drm/i915/gem/i915_gem_domain.c | 7 + .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 + drivers/gpu/drm/i915/gem/i915_gem_object.c | 91 +++++++++++++ drivers/gpu/drm/i915/gem/i915_gem_object.h | 28 ++++ .../gpu/drm/i915/gem/i915_gem_object_types.h | 5 + drivers/gpu/drm/i915/gem/i915_gem_phys.c | 4 + drivers/gpu/drm/i915/i915_driver.c | 1 - drivers/gpu/drm/i915/i915_gem.c | 8 ++ drivers/gpu/drm/i915/i915_gem_gtt.c | 1 + drivers/gpu/drm/i915/i915_vma.c | 32 +++++ drivers/gpu/drm/i915/i915_vma.h | 2 + .../drm/xe/compat-i915-headers/i915_active.h | 22 +++ .../compat-i915-headers/i915_active_types.h | 13 ++ .../gpu/drm/xe/compat-i915-headers/i915_vma.h | 2 + drivers/gpu/drm/xe/display/xe_plane_initial.c | 2 +- drivers/gpu/drm/xe/xe_bo.h | 9 ++ drivers/gpu/drm/xe/xe_bo_types.h | 5 + 30 files changed, 488 insertions(+), 47 deletions(-) create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/i915_active.h -- 2.34.1