Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 121DDC7EE22 for ; Mon, 15 May 2023 12:52:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1A63585EE8; Mon, 15 May 2023 14:52:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="mFcv1OdP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 87FA985F71; Mon, 15 May 2023 14:52:52 +0200 (CEST) Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 382C384660 for ; Mon, 15 May 2023 14:52:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-ba76528fe31so8812419276.1 for ; Mon, 15 May 2023 05:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1684155169; x=1686747169; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MXB1o9P0ei0rbC6vsiTMPl9LGVFYwYDTCA0ExXNJfW4=; b=mFcv1OdPdreVjr52Nugs+jpc4utZh/ssTZYmmV6QAdRvAVlPLXXTA2IUD1PyhKDYtp qN9SaTO0NegtbuUS6OK4LGQEE+irTD07nIqJLTjLzkUd/Y3Xjto1SRiFP3aAK+k3D07j CfRz3lAIr4caidRzh1qo3g9sKDPSK8i//ZPoc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684155169; x=1686747169; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MXB1o9P0ei0rbC6vsiTMPl9LGVFYwYDTCA0ExXNJfW4=; b=Fx85Bm2MG7gPBLEnTwpifd0iNUraaoQP46rV7aACnMxcVoIj1FChg1dXyrwcO7kQ0w q9XwhadOXoDnxWEXDPVsaITnJAsQwtY2kiswpTBFdICsH4u9vFIQh9f1Nkk5WrGFPX4J TGY0e9cp7kWstGt8sTbp3Qnhim9mQe+9Yx3lILlCcaWCnnMpLN/G9tNQlxeBvpkYP7e+ GqVpLWqaHWyG4DRieEPYhOcd12O6b9xwgM/rPAc3+GAu8rrTPa4LQDXu9P3ot/fOK+Mr wBoH4EOevkrPZr/WC6YC7+jAahNP2x2IqBEVRSatIPc2rNksc+rktmwMXaP2ySUHdeAs zuYg== X-Gm-Message-State: AC+VfDzeqdHDqrslqGPtOrlpbqvmKI/SewboMfefAQ7aqbN+S7Rtjn9P QXQ2nPmM4egn6e0iICEWBwbc3g== X-Google-Smtp-Source: ACHHUZ6/Fxp+YUvn1y51J6mZlEM/QPRK5dkWzH/FZXp8tJpc1vRvW1Ty57TCvth+7IDAWdxOpev2Kw== X-Received: by 2002:a05:6902:100a:b0:ba7:4c49:95e with SMTP id w10-20020a056902100a00b00ba74c49095emr7481136ybt.7.1684155168956; Mon, 15 May 2023 05:52:48 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-6982-b4e8-dc8f-16a1.res6.spectrum.com. [2603:6081:7b00:6400:6982:b4e8:dc8f:16a1]) by smtp.gmail.com with ESMTPSA id u1-20020a259b41000000b00ba6ffc7ef35sm2320216ybo.65.2023.05.15.05.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 05:52:48 -0700 (PDT) Date: Mon, 15 May 2023 08:52:46 -0400 From: Tom Rini To: Eugen Hristev Cc: u-boot@lists.denx.de, joe.hershberger@ni.com, jonas@kwiboo.se, jagan@edgeble.ai, kever.yang@rock-chips.com Subject: Re: [PATCH 2/2] configs: rock5b-rk3588: add rtl8169 driver Message-ID: <20230515125246.GA3036637@bill-the-cat> References: <20230425130659.62361-1-eugen.hristev@collabora.com> <20230425130659.62361-2-eugen.hristev@collabora.com> <20230505220303.GA2499096@bill-the-cat> <225e8cbc-8694-2465-3e63-f1833a098d93@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="z0mCknxxKi+9vf8Q" Content-Disposition: inline In-Reply-To: <225e8cbc-8694-2465-3e63-f1833a098d93@collabora.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --z0mCknxxKi+9vf8Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 15, 2023 at 03:36:24PM +0300, Eugen Hristev wrote: > On 5/6/23 01:03, Tom Rini wrote: > > On Tue, Apr 25, 2023 at 04:06:59PM +0300, Eugen Hristev wrote: > > > Add the rtl8169 driver, which supports the rtl8125b device, which is > > > connected on the pciE bus on this board. > > > Enable also CONFIG_SYS_HAS_NONCACHED_MEMORY to have the descriptors s= tored. > > >=20 > > > Signed-off-by: Eugen Hristev > > > --- > > > configs/rock5b-rk3588_defconfig | 2 ++ > > > 1 file changed, 2 insertions(+) > > >=20 > > > diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_= defconfig > > > index a14fcd2ee924..bfa48227aee2 100644 > > > --- a/configs/rock5b-rk3588_defconfig > > > +++ b/configs/rock5b-rk3588_defconfig > > > @@ -1,5 +1,6 @@ > > > CONFIG_ARM=3Dy > > > CONFIG_SKIP_LOWLEVEL_INIT=3Dy > > > +CONFIG_SYS_HAS_NONCACHED_MEMORY=3Dy > > > CONFIG_COUNTER_FREQUENCY=3D24000000 > > > CONFIG_ARCH_ROCKCHIP=3Dy > > > CONFIG_TEXT_BASE=3D0x00a00000 > > > @@ -71,6 +72,7 @@ CONFIG_MMC_SDHCI_SDMA=3Dy > > > CONFIG_MMC_SDHCI_ROCKCHIP=3Dy > > > CONFIG_SPI_FLASH_MACRONIX=3Dy > > > CONFIG_ETH_DESIGNWARE=3Dy > > > +CONFIG_RTL8169=3Dy > > > CONFIG_GMAC_ROCKCHIP=3Dy > > > CONFIG_PCI=3Dy > > > CONFIG_PCIE_DW_ROCKCHIP=3Dy > >=20 > > Does this depend on some series I missed where PCI is enabled on this > > config? > >=20 >=20 > Hi Tom, >=20 > the network device is connected on PCI express, that is right. I have a > separate series for that. > However, the network driver itself and the enabling of the network driver= is > somewhat independent, so I sent it as a separate series (this one ) > I think the config patch can go through rockchip custodian tree. With 1/2 now applied this results in failure to build due to DM_PCI not being enabled. --=20 Tom --z0mCknxxKi+9vf8Q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmRiKxUACgkQFHw5/5Y0 tyyb4gwAoFnbHx5FNJUfNaxTx9HMQRgPTL/1kv/3TaaVnN9OW8q5v9yp0NBHrl+W a2+0cHYRdyxHUFMndGM4rW9x2WlDaaMqTO99DQCL88H4D4N9W2Sqeb0esHTatQdZ u9OUDs/9D/E2RA0sP3Sfg1ZEqNFLfTG6yhhKwYQbfRxbFx2rrw+dtJsjNegg6S45 HAZgZLGD7ZyYSqmdhYPgki65lVVhUY1RoZcI9yyBFmum9ddPqMmUm0nwxQnJzL47 2mGTjhj7JoCatEXq423uDZyRMsvIIIABnMVKJ+TwoKmBdAZUOCt8iJ1MYMSczzvm vNWOkGDuVigYnhWcke7jcs41uexsI8IarCGzW8e8sN1m9JrztNe5/UItyQ7Nh6d8 SkbcI1tARuNLIORkfn6gI+epW0c8m5PAwk+FFZY5teMmf5IG9FWnij/AAzQx4XV0 ZKbZBXY0QbM3KdixgLoKdo9SID4s+WRbTkCDOM/wB0q1zW1lJ7wVTeMLXySF6s/t VH9GTMKq =GK3T -----END PGP SIGNATURE----- --z0mCknxxKi+9vf8Q--