Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2F01C77B7F for ; Wed, 17 May 2023 07:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=i2ezDfttm1tjWbozVCfAcEwRw872G1+EQV3HYjWGt7c=; b=V7SsjbFLKgKFwXlv+B/Nk/G30K dbVHss4N20Q5hHIDcbvOS1ZWEFMXOPde3aYPDbW6hRUFUtOZfW/todN3m5DPOjBsasitJAccgUolO 7P6NXhEo6vImzhYVmgDlfKvg1DklL0MDhAqH7OA3qlorj/WVUBFm4zB5Kqp1aOV+nCqfVzDAj/LZc KkIKdA0NFDVH2uYIBqAt/fzrJ6W26AWKWnTKcisUr2wxb59k+XDwNAmRLUkz1mtA68PseiwZ3V01d vTWtULbXIgE8IH4aWXsDzpaB1AReunY/KCd7gmr61KLwhqfB3n7u5mEN/JsCn3HIu9PcUqxtj0WmD kuPgHa3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzByn-008kPT-31; Wed, 17 May 2023 07:53:49 +0000 Received: from [2001:4bb8:188:3dd5:bc0:409a:ad8d:a02b] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pzBym-008kOm-1l; Wed, 17 May 2023 07:53:48 +0000 From: Christoph Hellwig To: kbusch@kernel.org, sagi@grimberg.me Cc: linux-nvme@lists.infradead.org Subject: [PATCH] nvme-multipath: don't call blk_mark_disk_dead in nvme_mpath_remove_disk Date: Wed, 17 May 2023 09:53:45 +0200 Message-Id: <20230517075345.246138-1-hch@lst.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org nvme_mpath_remove_disk is called after del_gendisk, at which point a blk_mark_disk_dead call doesn't make any sense. Signed-off-by: Christoph Hellwig --- drivers/nvme/host/multipath.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c index 9171452e2f6d4e..2bc159a318ff0a 100644 --- a/drivers/nvme/host/multipath.c +++ b/drivers/nvme/host/multipath.c @@ -884,7 +884,6 @@ void nvme_mpath_remove_disk(struct nvme_ns_head *head) { if (!head->disk) return; - blk_mark_disk_dead(head->disk); /* make sure all pending bios are cleaned up */ kblockd_schedule_work(&head->requeue_work); flush_work(&head->requeue_work); -- 2.39.2