Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74B07C77B7D for ; Wed, 17 May 2023 14:42:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1221A86215; Wed, 17 May 2023 16:41:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="lvreUizF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6D9A5861AC; Wed, 17 May 2023 16:41:56 +0200 (CEST) Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 309EC86240 for ; Wed, 17 May 2023 16:41:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb2f.google.com with SMTP id 3f1490d57ef6-ba8253f635cso1157264276.0 for ; Wed, 17 May 2023 07:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1684334512; x=1686926512; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EbXavTLP4WKkS9Irn8Oatf4Vs/Zrm7JZvJ1/8X1mFRk=; b=lvreUizFfJArcXJjE9et8TA4CKReRv8+dmngrCPDfmKEwRXE35E45n6qWsNw2yUV5/ ZpXCaqasimewbkNoj9VpSWbaiCtudm5dk/G1xat01YO1eXnldV+oaPyVG4aGooT24psQ F/l4hOIFL+DMulXq9TYjqS9H0Mw2PJjzKbbYw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684334512; x=1686926512; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EbXavTLP4WKkS9Irn8Oatf4Vs/Zrm7JZvJ1/8X1mFRk=; b=H+CiPxLzHckxBtX6qK440Eqzp2POG7TaHL0FOigj453unF/MOFOUqLChL+WoB+FByv soJPwkxhCX0cBt0+FDWPJW2uvCuyigg4HAw1z7RXClkyHDb+9BGPCSrtPr671zC/d6i3 BbcDQgMbWR5J8Jj6qFXsezGwg9NiHPMdnm339up7oxuYP8k+CPZfPcVm/1BcjQmcHSA7 eWG71z33Gmb+Ps1NYbGFRtaKtSPIZrr6jBJVdH7VCck/9lgWBpQZyr9TuXLKvIC9Jj/6 8yKUn02RfPfbkk44HthFqv5iLGZVC6bBwXyCqgfm/4FRVzs+Ot+Q0c6delnsrxTqYXVP bIOw== X-Gm-Message-State: AC+VfDwXzd/ZC4fBy8XnL63GtT5bXWDA2EkKplphSKG0hWP3WADL4LVU WcFJUr2KV8Owu+vbubxCJwlNiA== X-Google-Smtp-Source: ACHHUZ4aTJiTgtRkavSY0ZYdshQVTqf8X2zO7juVE97612M5oVtEC3lsuJ9zUWiBCH1JkiXQQLv2WA== X-Received: by 2002:a25:a047:0:b0:b9e:d97:e34b with SMTP id x65-20020a25a047000000b00b9e0d97e34bmr39270236ybh.50.1684334511900; Wed, 17 May 2023 07:41:51 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-a2da-5788-2855-381d.res6.spectrum.com. [2603:6081:7b00:6400:a2da:5788:2855:381d]) by smtp.gmail.com with ESMTPSA id j11-20020a25550b000000b00b9a80b9e08esm583687ybb.12.2023.05.17.07.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 07:41:51 -0700 (PDT) Date: Wed, 17 May 2023 10:41:47 -0400 From: Tom Rini To: Mayuresh Chitale Cc: Bin Meng , Simon Glass , u-boot@lists.denx.de, Heinrich Schuchardt , Rick Chen , Leo Subject: Re: [PATCH v3 4/5] spl: Support loading a FIT from ext FS Message-ID: <20230517144147.GA3595985@bill-the-cat> References: <20230504095327.2791676-1-mchitale@ventanamicro.com> <20230504095327.2791676-5-mchitale@ventanamicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="N9C284OnIAad93Zq" Content-Disposition: inline In-Reply-To: <20230504095327.2791676-5-mchitale@ventanamicro.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --N9C284OnIAad93Zq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 04, 2023 at 03:23:26PM +0530, Mayuresh Chitale wrote: > Detect a FIT when loading from an ext File system and handle it using > the FIT SPL support. >=20 > Signed-off-by: Mayuresh Chitale > --- > common/spl/spl_ext.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) >=20 > diff --git a/common/spl/spl_ext.c b/common/spl/spl_ext.c > index f117c630bf..7b771c41e9 100644 > --- a/common/spl/spl_ext.c > +++ b/common/spl/spl_ext.c > @@ -8,6 +8,26 @@ > #include > #include > #include > +#include > + > +static ulong spl_fit_read(struct spl_load_info *load, ulong file_offset, > + ulong size, void *buf) > +{ > + loff_t filelen =3D (loff_t)load->priv, actlen; > + char *filename =3D (char *)load->filename; Please build on 32bit platforms such as j721e_evm_r5 as well: +common/spl/spl_ext.c:16:26: error: cast from pointer to integer of differe= nt size [-Werror=3Dpointer-to-int-cast] + 16 | loff_t filelen =3D (loff_t)load->priv, actlen; --=20 Tom --N9C284OnIAad93Zq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmRk56gACgkQFHw5/5Y0 tyxMjgv/S1ERxmIpG14anYvRsXSGTzPYqJLUkVTWbNf6JzwmVIXIFznqHPWfJtLd pMTn1AH35gJGMEFI91EopPwxB4bHhBKHjkcHX0nrCoEKTfUHWxWjZswq8H5hPFnO Sh/E9OkbIq65dVe8A+wp6L/FQ0o0FMI0legTx8hM4bw45rWKBN3kP1UIVY8keffU B2iyAz9mz6rNWHbTDlrQAcOmOJohzUYPNy2aBZdOZ/L8PpgRqOuz9ps1qnwDr/fq s74K6anSiUcjrS/lGi5UlsnQFfdRu0TTJeLmJh4Low84kGq6iLGqqlAM+0XPZH6k k71rDIwm4g0zNtxsXGA92tD+DNa3DONaOwTSzOa35WgUS5c3DYlJATau2b6zkXEm Ko3TPKYvg/c4EcMceiWPHRkmw2gtKfrV6orjw7poo/hhL0AYc/011eAGoLC6BG5+ k8wnxmxdngFEO1KDuPuSp1K4Mz6sIA8uyut4K/viyH5MNePciB+NWP+aIcwRP3fl b397Vkq1 =3u+r -----END PGP SIGNATURE----- --N9C284OnIAad93Zq--