Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0194EC7EE2D for ; Mon, 22 May 2023 16:18:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BA65810E367; Mon, 22 May 2023 16:18:44 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 971DF10E0C1 for ; Mon, 22 May 2023 16:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684772320; x=1716308320; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=qj/hRbRp3nwapuKreNgDCJZIR/U7fbTRBJzmHCkB1lA=; b=kgnQY3l/aYBKrW1dAe/YhvBpxzY2CQ57VQ9DnvvK75Us4qQRYxNQKFeV PruNPBAHvXzX3t3gjaNb9xKelV3dNSMZLIktj/1Bp1iX5dx7V7yY8iPy+ ddIPJfNlGUozfkcDC8WSuKD0QNRsu8igJZni0UDbvRBz7t36yN4zqaaeW IAsTjiGs7JeOMz4VSW/z1sFpQ7XiWRQNnsf15gc4Nv8uqfAIjHbYxBAbR 6MvIMiMQcDPhNh6JIoNUAK/1VyVACmst23ovdeWUbccbcAcF3OVkmVa4/ fJS7eVI6r+BYkNxJtT0ZdW8pgCwKKXXgtR1R2r54Hw0jkQDYqSnCqjfU+ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="381199172" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="381199172" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 09:15:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="703586456" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="703586456" Received: from amigon-mobl.ger.corp.intel.com (HELO mwauld-desk1.intel.com) ([10.249.128.230]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 09:15:45 -0700 From: Matthew Auld To: intel-xe@lists.freedesktop.org Date: Mon, 22 May 2023 17:13:57 +0100 Message-Id: <20230522161403.79731-1-matthew.auld@intel.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Intel-xe] [PATCH v7 1/7] Revert "drm/xe: Use atomic instead of mutex for xe_device_mem_access_ongoing" X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rodrigo Vivi Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" This reverts commit c3712d924f6b5022498f4357009943c326389f9c. We add a similar version back, once we fix the locking inside xe_device_mem_access. Signed-off-by: Matthew Auld Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_device.c | 18 ++++++++++-------- drivers/gpu/drm/xe/xe_device.h | 18 ++++++++++++------ drivers/gpu/drm/xe/xe_device_types.h | 4 +++- 3 files changed, 25 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c index f7f6a6a97757..d0297ee432b2 100644 --- a/drivers/gpu/drm/xe/xe_device.c +++ b/drivers/gpu/drm/xe/xe_device.c @@ -216,6 +216,8 @@ struct xe_device *xe_device_create(struct pci_dev *pdev, if (err) goto err_put; + drmm_mutex_init(&xe->drm, &xe->mem_access.lock); + return xe; err_put: @@ -404,25 +406,25 @@ u32 xe_device_ccs_bytes(struct xe_device *xe, u64 size) void xe_device_mem_access_get(struct xe_device *xe) { bool resumed = xe_pm_runtime_resume_if_suspended(xe); - int ref = atomic_inc_return(&xe->mem_access.ref); - if (ref == 1) + mutex_lock(&xe->mem_access.lock); + if (xe->mem_access.ref++ == 0) xe->mem_access.hold_rpm = xe_pm_runtime_get_if_active(xe); + mutex_unlock(&xe->mem_access.lock); /* The usage counter increased if device was immediately resumed */ if (resumed) xe_pm_runtime_put(xe); - XE_WARN_ON(ref == S32_MAX); + XE_WARN_ON(xe->mem_access.ref == S32_MAX); } void xe_device_mem_access_put(struct xe_device *xe) { - bool hold = xe->mem_access.hold_rpm; - int ref = atomic_dec_return(&xe->mem_access.ref); - - if (!ref && hold) + mutex_lock(&xe->mem_access.lock); + if (--xe->mem_access.ref == 0 && xe->mem_access.hold_rpm) xe_pm_runtime_put(xe); + mutex_unlock(&xe->mem_access.lock); - XE_WARN_ON(ref < 0); + XE_WARN_ON(xe->mem_access.ref < 0); } diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h index cbae480a2092..9ab7e6134f89 100644 --- a/drivers/gpu/drm/xe/xe_device.h +++ b/drivers/gpu/drm/xe/xe_device.h @@ -90,14 +90,20 @@ static inline struct xe_force_wake * gt_to_fw(struct xe_gt *gt) void xe_device_mem_access_get(struct xe_device *xe); void xe_device_mem_access_put(struct xe_device *xe); -static inline bool xe_device_mem_access_ongoing(struct xe_device *xe) -{ - return atomic_read(&xe->mem_access.ref); -} - static inline void xe_device_assert_mem_access(struct xe_device *xe) { - XE_WARN_ON(!xe_device_mem_access_ongoing(xe)); + XE_WARN_ON(!xe->mem_access.ref); +} + +static inline bool xe_device_mem_access_ongoing(struct xe_device *xe) +{ + bool ret; + + mutex_lock(&xe->mem_access.lock); + ret = xe->mem_access.ref; + mutex_unlock(&xe->mem_access.lock); + + return ret; } static inline bool xe_device_in_fault_mode(struct xe_device *xe) diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h index 77d1cc6514c4..4d1af6663ab1 100644 --- a/drivers/gpu/drm/xe/xe_device_types.h +++ b/drivers/gpu/drm/xe/xe_device_types.h @@ -260,8 +260,10 @@ struct xe_device { * triggering additional actions when they occur. */ struct { + /** @lock: protect the ref count */ + struct mutex lock; /** @ref: ref count of memory accesses */ - atomic_t ref; + s32 ref; /** @hold_rpm: need to put rpm ref back at the end */ bool hold_rpm; } mem_access; -- 2.40.1