Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1660DC77B7A for ; Tue, 30 May 2023 15:38:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hQewL+8UxEh2PuKqHeF+NhfKANSKM7b87ydX07mf+Q0=; b=OEnMY3pkyk8t7v dFqdVmX3wWUW0b+edmrsxKZ57X3HEeIIIEr/JVEwwI+X0mZFvZ8REQwHoXZYJlRj03b9R0K2pPcJ9 mUCAUCZw3CI1SGw96pTFL/KQb8oGTeSCCR/E/T60lsIj/+4lRw3aeymFphFt4HIh/ryEax0BVgB5a WuEh6+kOHapUSDz5WEx4slQ+E8qlRlksZc5i9iVLXVpISa1Umt8yMUyqosbIjqHA/fNUYlJAYguvO ZB9/Vgkv2t+t3l1j6ziB3XR/o2+aRXuxdyTrl3Mjl7YzFeU/PRdUXagDOp6WtlqRHpW4YXntNrUKA 1yxPWUXX31abpClocreg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q41QI-00EQnR-2S; Tue, 30 May 2023 15:38:10 +0000 Received: from mailrelay5-1.pub.mailoutpod2-cph3.one.com ([2a02:2350:5:404::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q41QF-00EQkg-0X for linux-arm-kernel@lists.infradead.org; Tue, 30 May 2023 15:38:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=yErmUKLEV8p541cORXL+ZjgxkNaQgiMOaq6ZyNHls9A=; b=kJy4mOQJiQ6YFOtAavW7NVC4LtJUJWoWi0t56Isq6GJEQ94tSFFnKj2QAWLm0XaGC4nsXFkBkakDS NJpKJBBKnZj3kxtUaKYQCD2fzGVMwf1GdCYmplTtiUKOMCqmeCodCGDybgd3fBXqq41gTF+jtWaBud ZiifDfsFsxbsCYl7jUi6gqu8AP+taGhEp5M1s3Eje2y9B9jvuhLniBwkansgLifx6SE0ZhmmkwwW0S kQrmWvCeSptvOj1pNPoctQlqP/WS/dhXugy4DsvtYBfPP4+2ibR1557sMasm0CnZgPmuJJrK37Cziw 2hQh7NWvetGo07FA/uw7kZ2ePRqcxCg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=yErmUKLEV8p541cORXL+ZjgxkNaQgiMOaq6ZyNHls9A=; b=9OBjrRKYEtwrxBpN98hY1nffVfOZmReyI/MyWaIBmOFDtTrxJbnAvKHOUUjnmP+bOTyVAwwn+tCeN TfzEQsmCg== X-HalOne-ID: f3492551-feff-11ed-8093-231b2edd0ed2 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay5 (Halon) with ESMTPSA id f3492551-feff-11ed-8093-231b2edd0ed2; Tue, 30 May 2023 15:37:58 +0000 (UTC) Date: Tue, 30 May 2023 17:37:57 +0200 From: Sam Ravnborg To: Thomas Zimmermann Cc: freedreno@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, Tvrtko Ursulin , amd-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, javierm@redhat.com, dri-devel@lists.freedesktop.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 13/13] drm/i915: Implement dedicated fbdev I/O helpers Message-ID: <20230530153757.GA1464878@ravnborg.org> References: <20230524092150.11776-1-tzimmermann@suse.de> <20230524092150.11776-14-tzimmermann@suse.de> <20230529193621.GD1370714@ravnborg.org> <539118fc-ad60-ee3c-4a0c-1472774f5122@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <539118fc-ad60-ee3c-4a0c-1472774f5122@suse.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230530_083808_672615_AED3D107 X-CRM114-Status: GOOD ( 19.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Thomas, > > > - if (helper->funcs->fb_dirty) { > > > - drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area); > > > - drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1, > > > - drm_rect_width(&damage_area), > > > - drm_rect_height(&damage_area)); > > > - } > > > > The generated helpers do not have the if (helper->funcs->fb_dirty) > > check. > > Is this implemented somewhere else that I missed? > > It's not needed any longer. We used to test if the fbdev code needs damage > handling by looking for a fb_dirty callback. If so, we ran the damage > handling code. > > With the patchset applied, the fbdev code that does not need damage handling > calls fb_{io,sys}_write() directly. The fbdev code that needs damage > handling (generic, i915, msm) uses the generator macro that creates > necessary the calls unconditionally. We know each case at build time. > > (I think I have to move the msm patch after patch 10/13 to make it > bisectable.) > > AFAICT the missing test for fb_dirty is also one of the reasons why there's > a difference in performance. > > Hopefully, this answers your question? Makes perfect sense - thanks. That also implies that my conditional r-b's are now OK. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel