Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E86A7C7EE2A for ; Thu, 1 Jun 2023 15:27:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3703586373; Thu, 1 Jun 2023 17:25:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="S+vgPKjP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6AA4986373; Thu, 1 Jun 2023 17:25:19 +0200 (CEST) Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 642198631B for ; Thu, 1 Jun 2023 17:25:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-565c3aa9e82so10461507b3.2 for ; Thu, 01 Jun 2023 08:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1685633113; x=1688225113; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LSJ6GeYu6NdNowm21+CzswR0YRpphyJvwkeMCeocr3U=; b=S+vgPKjPOpajWODdDiyzPTqT96zYP6rYpcEUwhR2vlyxTwmaIHriAK7MPJlyEaCiGs S5nxAkm854id4C8IMs1Iz/ow6gP76nPLbi34azjl7b/Y18wMNio4Gt3H3bqiAYjKJYJJ kXTvnak2UUfdY6agBrh/W+j0kM4wOCHu7Q1Cw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685633113; x=1688225113; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LSJ6GeYu6NdNowm21+CzswR0YRpphyJvwkeMCeocr3U=; b=k7CxO8sh5mXaxKl0mIAQPqNQG+HCyKXOSaeMYPnLbcgCtQtUHo3KNqn5TuAMH25gpy SfRvbJjZQjcsi/GDb7ZcKp5hGwmw0FUaaGs+K0UiQZeBVY5ceaFhVy7bjdIymSzXpbM+ joGQOWZzPf23a7ozRjKukX161JmnYVIQ/tiiSOxlCXNGUd5PZCPtmFYrf9I7KEfmeqYr 7GTonqvHUy3IYmiEJFZCiF4YItaMIhHSLQCfxy7dFPekx/I0IfXXwrgiXpJInP68nJIG XhumZhvGym6bbzb+N5EnmTqEI0G/4RDTg1H+mqX7DT/JgcapdWfFojCNfvGMjGwdYYzM I67Q== X-Gm-Message-State: AC+VfDzgbJ5BTRdovHUIggWWRbgIPjZUb5lEDpeLYb9MwlFp8tqQ5HP8 Ob6cVVtjnss3+J+GethOGEm3/Q== X-Google-Smtp-Source: ACHHUZ4paGdDdZpcBEiKq+agFSjMRs8AtZ3opPzeWzpsWE6du48rI9if9q5mStNpHL9TccnmSFXI6A== X-Received: by 2002:a81:4f13:0:b0:565:ee73:7711 with SMTP id d19-20020a814f13000000b00565ee737711mr9351010ywb.46.1685633112962; Thu, 01 Jun 2023 08:25:12 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-94b3-8a65-fec1-4b24.res6.spectrum.com. [2603:6081:7b00:6400:94b3:8a65:fec1:4b24]) by smtp.gmail.com with ESMTPSA id t83-20020a815f56000000b005616d72f435sm4469455ywb.116.2023.06.01.08.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:25:12 -0700 (PDT) Date: Thu, 1 Jun 2023 11:25:10 -0400 From: Tom Rini To: Ashok Reddy Soma Cc: u-boot@lists.denx.de, jagan@amarulasolutions.com, xypron.glpk@gmx.de, sjg@chromium.org, d-gole@ti.com, jan.kiszka@siemens.com, patrice.chotard@foss.st.com, marex@denx.de, git@amd.com Subject: Re: [PATCH v3] cmd: sf/nand: Print and return failure when 0 length is passed Message-ID: <20230601152510.GT3755309@bill-the-cat> References: <20230516115236.22458-1-ashok.reddy.soma@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mlHwccGapFepjwlI" Content-Disposition: inline In-Reply-To: <20230516115236.22458-1-ashok.reddy.soma@amd.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --mlHwccGapFepjwlI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 16, 2023 at 05:52:36AM -0600, Ashok Reddy Soma wrote: > For sf commands, when '0' length is passed for erase, update, write or > read, there might be undesired results. Ideally '0' length means nothing = to > do. >=20 > So print 'ERROR: Invalid size 0' and return cmd failure when length '0' is > passed to sf commands. Same thing applies for nand commands also. >=20 > Example: >=20 > ZynqMP> sf erase 0 0 > ERROR: Invalid size 0 > ZynqMP> sf write 10000 0 0 > ERROR: Invalid size 0 > ZynqMP> sf read 10000 0 0 > ERROR: Invalid size 0 > ZynqMP> sf update 1000 10000 0 > ERROR: Invalid size 0 > ZynqMP> >=20 > Signed-off-by: Ashok Reddy Soma Applied to u-boot/next, thanks! --=20 Tom --mlHwccGapFepjwlI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmR4uFYACgkQFHw5/5Y0 tyyQoAv/RxclzxwccE/lBkd6poVSjL5me26TDQ1FCkVXHSUAB8O6TvVLqqZB4ENZ lg7X3cw0UCvmqP5/arNoYBQSxJGnQfKTrO4xzyuOhZlJOyFwiv8l2Bi93/JuwoLn 74+D/6mzqna0Hj3MyCS08biiWfKDva2TDV5GWiiFl4e88yz6c7RUgWP/OQIiaUdO 7YhhpZO2WlqkBqmm5mvKl6VsxF+Pa2S90bXw5ODeFiOAw421rudGpruPE6ySl11i Ch/Zc1YNiQr/iPZxa2uWBKzBlL8GRbllq+LjAmAYSNfjzhgPQy7+4c2Np3kSnf4q PsOqBZ2FiAkLVXHPIAv3uw6Ob2fVbKeXKj7pEEayDGx/vnr5i6WA9UDLEfr/CGrw pCWxe7X/LH68g6ttbIqDTgMrRynuhUskvSU4I5butz5K1ZWLGKiN4XzIo9fQFnmU dnEspLtMEV7oL0vhgxZ4lFXG3JwsmsbyTNj+DM9e4cuUj43LXvYoFb4Rz52g/7Dx AhQfZGu4 =2uE5 -----END PGP SIGNATURE----- --mlHwccGapFepjwlI--