Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85125C77B7A for ; Tue, 6 Jun 2023 12:55:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF38010E33E; Tue, 6 Jun 2023 12:55:44 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE20610E33E for ; Tue, 6 Jun 2023 12:55:42 +0000 (UTC) Received: from pendragon.ideasonboard.com (om126253223039.31.openmobile.ne.jp [126.253.223.39]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 42FC2AB; Tue, 6 Jun 2023 14:55:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1686056115; bh=v1ebWPm9f57kmCy8NGOr72XyV35bqnA9olqTFoX1h0E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uTxjqppgykua5g3f+sz22G5bMh0HeRARGlDCvYnIF4hdA+sUbKd1dk3zAzAQZuBpl gA+wZDiERLVn8ntmn8KAdjlbkjFyaT6ISRs+4BnWIZ8l8zS9Vr0YZDS1oDJw7KDGPE W0frUSEwX/86rVESPsLMihBDetS6UsmhRJrOwQNk= Date: Tue, 6 Jun 2023 15:55:37 +0300 From: Laurent Pinchart To: Siddh Raman Pant Subject: Re: [PATCH v9 1/8] Revert "drm: mipi-dsi: Convert logging to drm_* functions." Message-ID: <20230606125537.GC25774@pendragon.ideasonboard.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Robert Foss , Andrzej Hajda , Jonas Karlman , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , Jernej Skrabec , Suraj Upadhyay Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Siddh, Thank you for the patch. On Tue, Jun 06, 2023 at 04:15:15PM +0530, Siddh Raman Pant wrote: > This reverts commit 1040e424353f5f4d39f6f3aa8723eb3bd6ea6446. > > It used an incorrect way to use drm_* functions. Only drm_device ptrs > should be passed, but the mentioned commit passed mipi_dsi_host ptr. > It worked by accident due to macro magic. > > Reported-by: Jani Nikula > Reviewed-by: Jani Nikula > Signed-off-by: Siddh Raman Pant Reviewed-by: Laurent Pinchart Any chance we could prevent this from happening by turning the macros into inline functions ? > --- > drivers/gpu/drm/drm_mipi_dsi.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index 3fd6c733ff4e..a37af4edf394 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -33,7 +33,6 @@ > > #include > #include > -#include > > #include