Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23BA7C77B73 for ; Tue, 6 Jun 2023 19:19:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 69B7F85D3A; Tue, 6 Jun 2023 21:19:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="DpBCwWFQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C203E85E6B; Tue, 6 Jun 2023 21:19:51 +0200 (CEST) Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 87BC385A66 for ; Tue, 6 Jun 2023 21:19:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-565a6837a0bso71520007b3.3 for ; Tue, 06 Jun 2023 12:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1686079187; x=1688671187; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=i7LE5q+Q1dTtVnhi3Mk/b8u5UdhJj6Bx/OFezToYem8=; b=DpBCwWFQbLdXuCqW2bPCTsS1H+R4QD851oX+ydmUAn0jG05Prk7C4UGOxslQkLNHlP bslqC6GOs9EHZqd4r56itkY/IPTAnwpvxDsvR3P8k0gwvQW/Fvp14El8nC/cYa4z1yJj B0NjvtBQnC3pZ4VR5QqeGyRFqvGdvCGIplQik= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686079187; x=1688671187; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i7LE5q+Q1dTtVnhi3Mk/b8u5UdhJj6Bx/OFezToYem8=; b=WD4XFD762/JISCVmQhQG5fWPEU1sehmLJSbtZBWJxfxYbSJGJoE7JZGt655P3pKQ67 M67H4uZh3r/7KIRjVS/C+F0kCd3QhgoNDU3s/OSkxDY2udtvkgczAMKuH92jT3f/X1DE brfJsuk9FCivLIE4qzWI10RtuiIkV4cNPVGzVTiUZbHG2PYbJm8FXyUTPgZvyWQQi6pg XkdwI9/HB9GIM4AJXrgts/KyJBF9q1+mjxlFTpF+4lM8vUJIBGblhQ/YxczJsWzgiLF9 B0Nu/3uvHUcZaqrIdHEaY1GfJGcMkW8kuY8oRFt3+JNyiF9Aliv0igeGa7UgjvoBxbN3 tf0g== X-Gm-Message-State: AC+VfDx7Tfdf03hoeRGSWVrsjGbT3CzUq4E4EG3W2ayQnrxScUmK1TO4 Q+68um9/Mc3rxsJgaN9jE2IWnw== X-Google-Smtp-Source: ACHHUZ69XTVzdraRMWTY4BbwYvF8hZIHSdjLk21FgdfLdGwerAfqUNMsuXfMNEOdWCZd+2mWH72ptQ== X-Received: by 2002:a0d:cc8d:0:b0:565:9d27:c5e0 with SMTP id o135-20020a0dcc8d000000b005659d27c5e0mr4016677ywd.2.1686079187189; Tue, 06 Jun 2023 12:19:47 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-99ca-6782-9ebf-4e83.res6.spectrum.com. [2603:6081:7b00:6400:99ca:6782:9ebf:4e83]) by smtp.gmail.com with ESMTPSA id m5-20020a0dca05000000b0055c935364eesm4278873ywd.2.2023.06.06.12.19.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 12:19:46 -0700 (PDT) Date: Tue, 6 Jun 2023 15:19:44 -0400 From: Tom Rini To: Svyatoslav Ryhel Cc: Tom Warren , Simon Glass , Jonas =?iso-8859-1?Q?Schw=F6bel?= , u-boot@lists.denx.de Subject: Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support Message-ID: <20230606191944.GA1357306@bill-the-cat> References: <20230606071850.270001-1-clamor95@gmail.com> <20230606071850.270001-5-clamor95@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ej76xKlD7iA8Pxot" Content-Disposition: inline In-Reply-To: <20230606071850.270001-5-clamor95@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --ej76xKlD7iA8Pxot Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 06, 2023 at 10:18:47AM +0300, Svyatoslav Ryhel wrote: > The ASUS Transformer T30 family are 2-in-1 detachable tablets > and AiO developed by ASUS that run the Android operating system > (TF600T runs Windows RT and P1801-T runs Android and Windows). > The T30 Transformers feature a 10.1-inch display (apart P1801-T), > an Nvidia Tegra 3 quad-core chip, 1/2 GB of RAM, and 16/32 GB of > storage. Transformers board derives from Nvidia Cardhu development > board. >=20 > This patch brings support for 7 known Transformer devices: > - ASUS Transformer Prime TF201 > - ASUS Transformer Pad TF300T/TF300TG/TF300TL > - ASUS VivoTab RT TF600T (Windows RT based) > - ASUS Transformer Infinity TF700T > - ASUS Transformer AiO P1801-T >=20 > Tested-by: Andreas Westman Dorcsak # all devices > Signed-off-by: Svyatoslav Ryhel > --- > arch/arm/dts/Makefile | 7 + > arch/arm/dts/tegra30-asus-p1801-t.dts | 17 + > arch/arm/dts/tegra30-asus-tf201.dts | 9 + > arch/arm/dts/tegra30-asus-tf300t.dts | 18 + > arch/arm/dts/tegra30-asus-tf300tg.dts | 9 + > arch/arm/dts/tegra30-asus-tf300tl.dts | 9 + > arch/arm/dts/tegra30-asus-tf600t.dts | 89 +++++ > arch/arm/dts/tegra30-asus-tf700t.dts | 13 + > arch/arm/dts/tegra30-asus-transformer.dtsi | 211 ++++++++++ > arch/arm/mach-tegra/tegra30/Kconfig | 5 + > board/asus/transformer-t30/Kconfig | 23 ++ > board/asus/transformer-t30/MAINTAINERS | 6 + > board/asus/transformer-t30/Makefile | 11 + > .../pinmux-config-transformer.h | 365 ++++++++++++++++++ > .../transformer-t30/transformer-t30-spl.c | 41 ++ > board/asus/transformer-t30/transformer-t30.c | 201 ++++++++++ > configs/p1801-t.config | 2 + > configs/tf201.config | 2 + > configs/tf300t.config | 2 + > configs/tf300tg.config | 2 + > configs/tf300tl.config | 2 + > configs/tf600t.config | 4 + > configs/tf700t.config | 2 + > configs/transformer_t30_defconfig | 85 ++++ Sorry for not noticing this part sooner. Looking in the kernel, arch/{riscv,powerpc}/Makefile both provide examples of how to automate generating the resulting defconfigs directly. I think we really want that, and also the config fragments need to be listed in the MAINTAINERS file. I also worry that none of these other configs will be caught by buildmn and so won't be in CI at all, just the base. Which isn't a big problem, yet, but could be as more people use config fragments. I'm just noting this secondary part and not saying you need to fix that as well. --=20 Tom --ej76xKlD7iA8Pxot Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmR/hs0ACgkQFHw5/5Y0 tyxzYgwAnlwYpz1Tav7Hlj9bqEi6opPrynT9/n+SpVADBN5+rT+A/yDnp5akxYJs QXKPtYPESRSYWAAg0V/OQRxTHtgsxc9zx7oK+Rhs6NwbiGN01cPadRkU6SdxUXGH +FXzpLgiFcUbiJXLsBF+V7zn0E+mkoP3V2Fol80hJjD69UQjd1bU0NmfQzXbZhMP c9BUWS/qwpkU+OkOKZBeCFX0dudAUaVOuOB2qbk8fhO/PEOTDHj/la0rGvwRvytF Xr2NH0hryE05X9qklUwX3okgb78Am4+sGZBRtNCPQnTpVC5bEyNTKcQDoeOG3Qvg +g43Sx/qTtwn5bsYUV3DDP9J9ALxCh7J2xno6bgcQYa4Brl/2dIpbW8BZmmg4b6h igiiWZH5CGV6UWpFQo5i38oQ8R6FcKa8HyE998lPlGnq0qMlWRFg1T274iWetbRR icvh3Kh/x59Xl2X+bIIHS1mCXHDM0gc4YZLIbheyLQXVnaF9C53VHbhxcLyOIYm5 1bdxrcyx =LFDO -----END PGP SIGNATURE----- --ej76xKlD7iA8Pxot--