Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A076C77B7A for ; Tue, 6 Jun 2023 19:47:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2243285EE7; Tue, 6 Jun 2023 21:47:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="DLmXfzDp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 07AB885EE7; Tue, 6 Jun 2023 21:47:30 +0200 (CEST) Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C10A985E35 for ; Tue, 6 Jun 2023 21:47:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-5689335d2b6so67672607b3.3 for ; Tue, 06 Jun 2023 12:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1686080845; x=1688672845; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1wbZoU/OJoxmZf5h1GfXYeLOyQQ8KENUu2ly4lBCljw=; b=DLmXfzDpArkvK9XxUDu2kUO0dfzM8MyKKvII94oieGtLLCn789LB6R85TcftEB0ktO HJ+7aXl+rqFwoG+zxId9RhgeTgsBectEhbNRmeJ30CWiofEIlIqCX8Xue/5iQ/ZwM5Ij sVO4BF1TxnWbbScuHWM8AlvzMyHfYYDI1Cz7o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686080845; x=1688672845; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1wbZoU/OJoxmZf5h1GfXYeLOyQQ8KENUu2ly4lBCljw=; b=k8LjNUlrjKqGzlYpHFnY09xuL0wd4I8p+2zNDBa3gbRxzc2CypwNMxjCjZPrIew4H+ Om775XiKfJW6Q1JEcgYKv9MlcWsU0mMdwF+oP0evY2To4y/3FVjVAUYnzlEuN4fUhKDa QhA4/Xg05vn8xFT1hiYnli3ApaBpnVVkbxJm0w5j2mECg6PCmGHE7EVw3VlrzTmlUMlJ hFOFUIDCEHBrJKQYsOVrpIHIO0WF2juWxKFDZXkOr/Pi9TSME5wJlGkYYWi1fbmTQdjH o4WdKZaW22YGNPDPj54/vybknFMuMq1QBFTbYT8A16IuEJkagdQQt7+BK3gebUSW2+TT osgQ== X-Gm-Message-State: AC+VfDzYj0n4TFZ6HNstk+rw9A1FAWVXSOZAA8fKeQEiLsHbDrbPLEoa JlMqopPlx6yUrZ5qEltruTxH1g== X-Google-Smtp-Source: ACHHUZ7oH6FS3AZhmSnNTVLmA9mSFhC4e5v5fT33bTMZq/qGT6mdRA9i0N8ZOGBRC3JL+b82F1MT/w== X-Received: by 2002:a81:c247:0:b0:565:ee47:5844 with SMTP id t7-20020a81c247000000b00565ee475844mr3260851ywg.38.1686080845505; Tue, 06 Jun 2023 12:47:25 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-a32f-7d20-53ba-bf5b.res6.spectrum.com. [2603:6081:7b00:6400:a32f:7d20:53ba:bf5b]) by smtp.gmail.com with ESMTPSA id u5-20020a0deb05000000b0055a07585a91sm4325389ywe.11.2023.06.06.12.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 12:47:24 -0700 (PDT) Date: Tue, 6 Jun 2023 15:47:23 -0400 From: Tom Rini To: Svyatoslav Ryhel Cc: Tom Warren , Simon Glass , Jonas =?iso-8859-1?Q?Schw=F6bel?= , u-boot@lists.denx.de Subject: Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support Message-ID: <20230606194723.GD1871110@bill-the-cat> References: <20230606071850.270001-1-clamor95@gmail.com> <20230606071850.270001-5-clamor95@gmail.com> <20230606191944.GA1357306@bill-the-cat> <9897DF6B-820C-418D-83EA-A6770FF8ABB2@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Bn+BuGw5z8XCDw7v" Content-Disposition: inline In-Reply-To: <9897DF6B-820C-418D-83EA-A6770FF8ABB2@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --Bn+BuGw5z8XCDw7v Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 06, 2023 at 10:40:53PM +0300, Svyatoslav Ryhel wrote: >=20 >=20 > 6 =D1=87=D0=B5=D1=80=D0=B2=D0=BD=D1=8F 2023 =D1=80. 22:19:44 GMT+03:00, T= om Rini =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=B2(-= =D0=BB=D0=B0): > >On Tue, Jun 06, 2023 at 10:18:47AM +0300, Svyatoslav Ryhel wrote: > > > >> The ASUS Transformer T30 family are 2-in-1 detachable tablets > >> and AiO developed by ASUS that run the Android operating system > >> (TF600T runs Windows RT and P1801-T runs Android and Windows). > >> The T30 Transformers feature a 10.1-inch display (apart P1801-T), > >> an Nvidia Tegra 3 quad-core chip, 1/2 GB of RAM, and 16/32 GB of > >> storage. Transformers board derives from Nvidia Cardhu development > >> board. > >>=20 > >> This patch brings support for 7 known Transformer devices: > >> - ASUS Transformer Prime TF201 > >> - ASUS Transformer Pad TF300T/TF300TG/TF300TL > >> - ASUS VivoTab RT TF600T (Windows RT based) > >> - ASUS Transformer Infinity TF700T > >> - ASUS Transformer AiO P1801-T > >>=20 > >> Tested-by: Andreas Westman Dorcsak # all devices > >> Signed-off-by: Svyatoslav Ryhel > >> --- > >> arch/arm/dts/Makefile | 7 + > >> arch/arm/dts/tegra30-asus-p1801-t.dts | 17 + > >> arch/arm/dts/tegra30-asus-tf201.dts | 9 + > >> arch/arm/dts/tegra30-asus-tf300t.dts | 18 + > >> arch/arm/dts/tegra30-asus-tf300tg.dts | 9 + > >> arch/arm/dts/tegra30-asus-tf300tl.dts | 9 + > >> arch/arm/dts/tegra30-asus-tf600t.dts | 89 +++++ > >> arch/arm/dts/tegra30-asus-tf700t.dts | 13 + > >> arch/arm/dts/tegra30-asus-transformer.dtsi | 211 ++++++++++ > >> arch/arm/mach-tegra/tegra30/Kconfig | 5 + > >> board/asus/transformer-t30/Kconfig | 23 ++ > >> board/asus/transformer-t30/MAINTAINERS | 6 + > >> board/asus/transformer-t30/Makefile | 11 + > >> .../pinmux-config-transformer.h | 365 ++++++++++++++++++ > >> .../transformer-t30/transformer-t30-spl.c | 41 ++ > >> board/asus/transformer-t30/transformer-t30.c | 201 ++++++++++ > >> configs/p1801-t.config | 2 + > >> configs/tf201.config | 2 + > >> configs/tf300t.config | 2 + > >> configs/tf300tg.config | 2 + > >> configs/tf300tl.config | 2 + > >> configs/tf600t.config | 4 + > >> configs/tf700t.config | 2 + > >> configs/transformer_t30_defconfig | 85 ++++ > > > >Sorry for not noticing this part sooner. Looking in the kernel, > >arch/{riscv,powerpc}/Makefile both provide examples of how to automate > >generating the resulting defconfigs directly. I think we really want > >that, and also the config fragments need to be listed in the MAINTAINERS > >file. >=20 > Not sure if adding this is a good idea, plus adding fragments into > MAINTAINERS may cause even more issues. Iirc buildman uses it as a > config source and defining multiple fragments may fail not only for > boards under question, but those, already existing in u-boot, as well. If this causes buildman problems then we'll need to figure out something, but it shouldn't. > Issue is not in the arch dir to tweak arch's makefile, fragments are > used by some boards and issue lays in omitting their existence by > system of autobuild. Yes, and I'd like to set some good examples for the first config fragments we're adding as I suspect you're the first person to notice this works (as a feature not a happenstance) and others will make more use if it for more than a few changes. So I'd like to get things going in the right direction. >=20 > >I also worry that none of these other configs will be caught by buildmn > >and so won't be in CI at all, just the base. Which isn't a big problem, > >yet, but could be as more people use config fragments. I'm just noting > >this secondary part and not saying you need to fix that as well. > > >=20 > Buildman indeed is not catching any fragments, which already caused me is= sues since defconfigs are not as generic as I would like to (since else I g= et a big chunk of checks failed). >=20 > A good solution might be to tweak buildman to accept fragments if any are= defined in the dedicated field of MAINTAINERS file. But that would be a ma= jor patchset to implement on the entire project scale. Yes, I'm not sure how best to deal with fragments to start with, for buildman. But we don't need to solve that today for this series, either. --=20 Tom --Bn+BuGw5z8XCDw7v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmR/jUEACgkQFHw5/5Y0 tyyfrQv+KHPRcfkHNlqNMPorRyXX6v4uAl4kOXObfk7NjbGslsPqIZiZpY8rkZ8d xUlM/BVQIQnysepDs+0XDQz7VYfagbUgJZ7eL7F0cVJJJYzSRRJkwViAICr3oVsN ThksEtu5v/n8YWugxqcAVEFxahc5s0pFxoa+myUEzMZT8fsq0sw8pd1iVwxigwRa j3bMqsQEn25yjcFyL6XW2/Iobee0FYrOOfaScnrDK4pZXJdXqyuRSH4OlaufqvBm lsigpBeqbyGjOhDQWnRPvgAKJIWJSEpxaWWfkUcfVFs7f+4d5VCm27G8TV9vQkLi SpnbLa2Rtoq6+ZmoJyzSUyIUu9CZ/KsFg7PiacVZE6VfRWDKSkyKoAJaTzqrc9nQ ulQD3HrMBXxr1Dsi4kI+4cB2AclwZM+yPI9uPOd8CspmT4g6TScLsFcrjwFJBZEN OG5LxKxD+MVSLJdebFOuj+0OwbN+DRQMwKWIswGbLmHOo2uXV/MXnC2wEkOo/R3m mPnZ5wf4 =hRte -----END PGP SIGNATURE----- --Bn+BuGw5z8XCDw7v--