Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B172C7EE25 for ; Thu, 8 Jun 2023 15:58:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236887AbjFHP6F (ORCPT ); Thu, 8 Jun 2023 11:58:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237599AbjFHP6A (ORCPT ); Thu, 8 Jun 2023 11:58:00 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82FA01AE for ; Thu, 8 Jun 2023 08:57:59 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 42FAC1FDE9; Thu, 8 Jun 2023 15:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1686239878; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oKfd9lG7HN8IEQwDcQHX4nsGtG7Y/Puh+34wKA4vA/0=; b=LhNrk9UZ6ph2VVKRYqoSjPxermX9P+Z6dFhQ0Uo5pxAipQ3zu1PiIQmiN922kOFxhTri5K yoq4YnHndCStffeJeZgVloApRcNYW0rTSyaerlbH1XUg+9LS37zblI976WI+2YikCRlnJa ulnol5qOZQxB0CMcpxJPx7EoWsNtvBE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1686239878; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oKfd9lG7HN8IEQwDcQHX4nsGtG7Y/Puh+34wKA4vA/0=; b=ccboDdyPDu9iaUPZc/vWbrFVTQPzqrl1LQiI1NLm4oFOIu0QPakdZKJ64Bi4Uszy4KzEKE izkHwRMExvNeZXBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1ADE0138E6; Thu, 8 Jun 2023 15:57:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4BWqBYb6gWTmJwAAMHmgww (envelope-from ); Thu, 08 Jun 2023 15:57:58 +0000 Date: Thu, 8 Jun 2023 17:51:41 +0200 From: David Sterba To: Christoph Hellwig Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs: set FMODE_CAN_ODIRECT instead of a dummy direct_IO method Message-ID: <20230608155141.GL28933@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20230608091133.104734-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230608091133.104734-1-hch@lst.de> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Jun 08, 2023 at 11:11:33AM +0200, Christoph Hellwig wrote: > Since commit a2ad63daa88b ("VFS: add FMODE_CAN_ODIRECT file flag") file > systems can just set the FMODE_CAN_ODIRECT flag at open time instead of > wiring up a dummy direct_IO method to indicate support for direct I/O. > Do that for btrfs so that noop_direct_IO can eventually be removed. > > Signed-off-by: Christoph Hellwig Added to misc-next, thanks. Seems that a few more filesystem can use the same conversion.