Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05E1DC7EE23 for ; Thu, 8 Jun 2023 17:49:26 +0000 (UTC) Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.64]) by mx.groups.io with SMTP id smtpd.web10.830.1686246563644216691 for ; Thu, 08 Jun 2023 10:49:24 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: denix.org, ip: 64.68.198.64, mailfrom: denis@denix.org) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id 7320D40C52; Thu, 8 Jun 2023 17:49:22 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo14-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xT33wePGiBcr; Thu, 8 Jun 2023 17:49:22 +0000 (UTC) Received: from mail.denix.org (pool-100-15-88-116.washdc.fios.verizon.net [100.15.88.116]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id 3B1B940021; Thu, 8 Jun 2023 17:49:18 +0000 (UTC) Received: by mail.denix.org (Postfix, from userid 1000) id EF78916396E; Thu, 8 Jun 2023 13:48:29 -0400 (EDT) Date: Thu, 8 Jun 2023 13:48:29 -0400 From: Denys Dmytriyenko To: rs@ti.com Cc: reatmon@ti.com, afd@ti.com, nm@ti.com, meta-arago@lists.yoctoproject.org Subject: Re: [oe-layersetup][PATCH 00/15] Sacrifice your first born to the linter Message-ID: <20230608174829.GA9226@denix.org> References: <20230607200504.3810426-1-rs@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230607200504.3810426-1-rs@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 08 Jun 2023 17:49:25 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-arago/message/14541 Do you need to correct From: and SoB: lines in all the patches? On Wed, Jun 07, 2023 at 03:04:49PM -0500, rs@ti.com wrote: > From: Randolph Sapp > > Last night someone in the beagle community reported some cryptic errors from > oe-layersetup so I took the time to address all of the issues reported > by Shellcheck and add some extra sanity checks. > > I tried to split it into reasonable segments. > > StaticRocket (15): > oe-layertool-setup: prefer use of $() notation > oe-layertool-setup: replace all x comparisons with -n/-z > oe-layertool-setup: fix all the printf calls > oe-layertool-setup: fix all quoting, switch eval to export > oe-layertool-setup: only invoke read with -r > oe-layertool-setup: check exit code directly > oe-layertool-setup: guard all cd calls > oe-layertool-setup: eliminate useless cat > oe-layertool-setup: use subshell execution with redirect > oe-layertool-setup: guard against invalid expression in case > oe-layertool-setup: replace all calls to echo with printf > oe-layertool-setup: drop unused variable > oe-layertool-setup: add a path sanity check for oebase > oe-layertool-setup: fix multi-line printfs > oe-layertool-setup: add sanity check for layer names > > oe-layertool-setup.sh | 435 +++++++++++++++++++++--------------------- > 1 file changed, 220 insertions(+), 215 deletions(-) > > -- > 2.40.1