Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A92FBEB64D8 for ; Wed, 14 Jun 2023 19:51:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6B942861B0; Wed, 14 Jun 2023 21:51:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="jXJzgWVS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A3809861CC; Wed, 14 Jun 2023 21:51:28 +0200 (CEST) Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DE7A386020 for ; Wed, 14 Jun 2023 21:51:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-57001c0baddso11799227b3.2 for ; Wed, 14 Jun 2023 12:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1686772284; x=1689364284; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b9Itgu0/Zh3uQXa8akqCzoWSLvEKaFhZXomXh7M2zd4=; b=jXJzgWVSW9MibYGu4032Euv4EIrjRnwXIhxdNlH/T2aIJqHe8bxq712AQob73KFnaU RlRjn6Hkt8wY+c81OxyJ9WXVP43qjCoDoLV6CTgZjApHMM/bX5m+qpF3aKb+H37KhB8N ROu4VsQLsmQZtW0yLTRNE2Kzz4VUyZQVNWURU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686772284; x=1689364284; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b9Itgu0/Zh3uQXa8akqCzoWSLvEKaFhZXomXh7M2zd4=; b=SW0gvfa+IdkZD1JmF0Bi6gDozrMoflj01QXMFHrwYBLaxXNFcprXLoN4tgQB7Sw88r SWP9uzqI7bkAg+QABDLa3Valjw9gtg3HA7VQRO7gWb1bEY1RCdP+Q+l/4R4cKeRY0Z6L AgW2qD3fGP0Hs+jYGaWBIGtp/y9Trp9Quy1fqgAMnZu0LdceOT7fCNrC1G77mpYXr4YO EmA0SCAzxuRJ33vpZqyVEw2U27mmD3LkCPXBWn2nc+3FTsiAEV+zEE9CJ9xb5tvY95OV KNeXJrf1HD9zZV269ZRyB7xCD9RN+E/3t8X389HTd4yln65BBkn8Xy3W7bWo7WsnZC2b n9qQ== X-Gm-Message-State: AC+VfDyl7bsWjkJYbSSzS70/HkAXoaN7XhnCnNYDolPAOZ7kQz9P/U/v S1ETN7R6oQypdBiPb6Us4fFMpg== X-Google-Smtp-Source: ACHHUZ5gbbKCQJs9NFETKSaU+pccE0KEWBzHzVIK/110h/tCGGHqYn+N7BxdIYPKxvtxNcNGnkK0iA== X-Received: by 2002:a81:6706:0:b0:56d:5041:78b with SMTP id b6-20020a816706000000b0056d5041078bmr3137418ywc.2.1686772284411; Wed, 14 Jun 2023 12:51:24 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-3030-37e8-a68b-2c85.res6.spectrum.com. [2603:6081:7b00:6400:3030:37e8:a68b:2c85]) by smtp.gmail.com with ESMTPSA id o12-20020a0dcc0c000000b0056d2fce4e09sm1995280ywd.42.2023.06.14.12.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 12:51:23 -0700 (PDT) Date: Wed, 14 Jun 2023 15:51:21 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= , Simon Glass Cc: Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH u-boot 0/3] Revert broken Bootmenu commits Message-ID: <20230614195121.GR3931582@bill-the-cat> References: <20230611125324.15860-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VYeCyl0jkIsu3Jau" Content-Disposition: inline In-Reply-To: <20230611125324.15860-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --VYeCyl0jkIsu3Jau Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 11, 2023 at 02:53:21PM +0200, Pali Roh=E1r wrote: > These 3 commits broke support for U-Boot Bootmenu on Nokia N900. > Issues were reported more than month ago, but nobody reacted to them. > So revert these broken commits for now, to fix U-Boot Bootmenu support. >=20 > With these revered commits, U-Boot Bootmenu from master branch is > working fine again on Nokia N900. >=20 > Pali Roh=E1r (3): > Revert "video: Enable VIDEO_ANSI by default only with EFI" > Revert "menu: Factor out menu-keypress decoding" > Revert "menu: Make use of CLI character processing" >=20 > cmd/bootmenu.c | 9 ++-- > cmd/eficonfig.c | 12 ++--- > common/cli_getch.c | 12 ++--- > common/menu.c | 122 ++++++++++++++++++++++++++---------------- > drivers/video/Kconfig | 7 +-- > include/cli.h | 4 +- > include/menu.h | 17 +----- > 7 files changed, 91 insertions(+), 92 deletions(-) Following up over here, while https://patchwork.ozlabs.org/project/uboot/patch/20230612201434.861700-1-sj= g@chromium.org/ addresses some of the issues, but not all (as it clearly isn't working in all of the cases Pali has explained), looking in to the VIDEO_ANSI part of this too, all three of these reverts are related seemingly to something escape-character related. I'm not taking any of the revert commits in just yet, but will by the next -rc if we don't have something that fixes all of the issues. --=20 Tom --VYeCyl0jkIsu3Jau Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmSKGjYACgkQFHw5/5Y0 tyyN3wv+P4RDV2CXOKhVi8pbOP9pwtn/6BgfdiQ0WeiM6GhT1QDxKTe87X6NokeL cDWL6dIjBWh9XgCF5kwJzUNvgMU7YHWxaWOOwCyXau8k05dmkyfuSY6sGxrD6+zs 6Tkx0CVgsVj9xyteBiZeBdliItkUi0NLWn3HlbAT2bR3XGCyiJMqIDz2l9112I4g lgeM73lQs9/HuXF1jsxZrCDZgRiyVCjdgEKnJaC6CSxf05aKTLUK/qNVIp5y5fPh wmjvq6h1SHQNGxx4PaIUwT5+Osi7BOu9z2IuT9NgFr4NgHbv5c17oyuLgeQahQDD YWqtF9ywtIVzqx0xFIlF17gbcYS5IIUJkorXNjpvgq0sKQqzwOi3iEqJO1X+WyuJ cDZ7QJSLfh3blqSYzkpo+nw//ZIRFB5WM8v8g5MLdOq119nI6G0YmKxC3pkc+aws xphAmnjfzO0QWa2HLAo1uPzfZMLFPG18nANzsGpLUziexLtt9nlRlMonNpUcNgZX GxdAEHs5 =UQEc -----END PGP SIGNATURE----- --VYeCyl0jkIsu3Jau--