Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E08E1EB64DC for ; Thu, 15 Jun 2023 11:38:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DOBv+MZ/mVZbLWznKl+dO3KeAJYysMMVI3L5b+eXX94=; b=ongIZzV1+D4OK4cTiF/iuOh/GB s8NqGO0LjV2DcZtI4VsXNthGMqumsuUT2mLt6l4YUzvSH0FTYYX+QKaV4MRjcv+Wt7C2rLSLjkCLU /E/9lYJT01wvPDq6vePkZRhzemF9iR7Mq3nBYnbjdIZ+sEnPUC9masQy3htDRzVvyUQwxq+jeqbM4 hTbLMe0bi0DNETbFX+QKlNAfqxskYMq1nUfi1sJ9vj2p3mV/RA4XsBK4sQde+kKkgLYH7dRtXmsAI sHk8hOo6NzL6WyHjFjt9kpolwyhX+NxJAQTBiVi+i3T3umzhQ2E1KFCMp+AEDh8MX9XVKfIDTIYrF GfBrJFkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9lJZ-00EjDD-2P; Thu, 15 Jun 2023 11:38:57 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9lJX-00EjBH-0P for linux-nvme@lists.infradead.org; Thu, 15 Jun 2023 11:38:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9821E639D9; Thu, 15 Jun 2023 11:38:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F35FFC433BC; Thu, 15 Jun 2023 11:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686829134; bh=pC9I6e0OWmAUP6vgtjaR7+ZgsLgeZHz9GxRxlURUdvs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WlXEJo+CzNj6Ai3idWQrgZRGPSrOC5Yp0jST/fGosBNNUn/YfinqLNxJgHeCt8Xac J0P0T+q74gFqPzoOjYQj8DlyS8YR41zh1VYmnKuGLtnuCNdrhlTxPiKsbKuZtx77sy cDxjk1l1FipPXudd28FY4yHLrI/6W9nMETjAzS23iR9NkXc4lMFdgVZca2A20ck0OW p1POzMflHisqzi2hILJFISF1NCNef0j/o7wErqYAxbuEekH1xREO1zAvRb1It+yAIc 5bxOZk4/t963Gb8dfz858O13NkAfK73XfinSHhGtOISyBkhDbrkDUV4wH67/2oikxt l2rPrYSFC1dPg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Uday Shankar , Costa Sapuntzakis , Randy Jennings , Hannes Reinecke , Christoph Hellwig , Keith Busch , Sasha Levin , sagi@grimberg.me, linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 6.1 16/16] nvme: improve handling of long keep alives Date: Thu, 15 Jun 2023 07:38:16 -0400 Message-Id: <20230615113816.649135-16-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230615113816.649135-1-sashal@kernel.org> References: <20230615113816.649135-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.34 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230615_043855_248850_93204AFF X-CRM114-Status: GOOD ( 16.57 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org From: Uday Shankar [ Upstream commit c7275ce6a5fd32ca9f5a6294ed89cf0523181af9 ] Upon keep alive completion, nvme_keep_alive_work is scheduled with the same delay every time. If keep alive commands are completing slowly, this may cause a keep alive timeout. The following trace illustrates the issue, taking KATO = 8 and TBKAS off for simplicity: 1. t = 0: run nvme_keep_alive_work, send keep alive 2. t = ε: keep alive reaches controller, controller restarts its keep alive timer 3. t = 4: host receives keep alive completion, schedules nvme_keep_alive_work with delay 4 4. t = 8: run nvme_keep_alive_work, send keep alive Here, a keep alive having RTT of 4 causes a delay of at least 8 - ε between the controller receiving successive keep alives. With ε small, the controller is likely to detect a keep alive timeout. Fix this by calculating the RTT of the keep alive command, and adjusting the scheduling delay of the next keep alive work accordingly. Reported-by: Costa Sapuntzakis Reported-by: Randy Jennings Signed-off-by: Uday Shankar Reviewed-by: Hannes Reinecke Reviewed-by: Christoph Hellwig Signed-off-by: Keith Busch Signed-off-by: Sasha Levin --- drivers/nvme/host/core.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 06dd1c0780bfc..4e4203c327114 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1234,6 +1234,20 @@ static enum rq_end_io_ret nvme_keep_alive_end_io(struct request *rq, struct nvme_ctrl *ctrl = rq->end_io_data; unsigned long flags; bool startka = false; + unsigned long rtt = jiffies - (rq->deadline - rq->timeout); + unsigned long delay = nvme_keep_alive_work_period(ctrl); + + /* + * Subtract off the keepalive RTT so nvme_keep_alive_work runs + * at the desired frequency. + */ + if (rtt <= delay) { + delay -= rtt; + } else { + dev_warn(ctrl->device, "long keepalive RTT (%u ms)\n", + jiffies_to_msecs(rtt)); + delay = 0; + } blk_mq_free_request(rq); @@ -1252,7 +1266,7 @@ static enum rq_end_io_ret nvme_keep_alive_end_io(struct request *rq, startka = true; spin_unlock_irqrestore(&ctrl->lock, flags); if (startka) - nvme_queue_keep_alive_work(ctrl); + queue_delayed_work(nvme_wq, &ctrl->ka_work, delay); return RQ_END_IO_NONE; } -- 2.39.2