Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A55DEB64D7 for ; Fri, 16 Jun 2023 10:28:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA46010E5F4; Fri, 16 Jun 2023 10:28:38 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 06D6D10E5FD for ; Fri, 16 Jun 2023 10:28:36 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7692F635C2; Fri, 16 Jun 2023 10:28:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 703F2C433CA; Fri, 16 Jun 2023 10:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686911314; bh=CNtcYf3C913L4qZW+Z+LQTGDw8tBa30R8IlCjpUSR1o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I5emMbS1/wEAoHgrau86b8YgSkBHpx9kGCAIXU3jY7n/4w+QFGf3IX0rve6600uvr zNHigF3dk8XQblrNukvP1onVcaHSJnBtZ4BLIDsEadlAs6fHeeBaHNEBwpMMFUxhZS dwB4EYe807JNVS9bXTdOttAEsYMMfhkcCyczImyUlrHlulyZJgZt/uOroycn1sZPgJ HdGWEVTKSoaVH9CjGtqc/Q36Kf+Jz/kW7XsZlHHcsQ+ZkKGRHkAFpFrow7rD6ll6HV EGuT6l8pmpQX3dfsTrY7tuIL8hmLZg8RYPIH9zpBf/JmcfG9zksqCJK4a6RTI2Ha59 TIlXUhcPNAADA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 5/8] drm/exynos: vidi: fix a wrong error return Date: Fri, 16 Jun 2023 06:28:18 -0400 Message-Id: <20230616102821.674153-5-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616102821.674153-1-sashal@kernel.org> References: <20230616102821.674153-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.247 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , linux-samsung-soc@vger.kernel.org, Andi Shyti , sw0312.kim@samsung.com, krzysztof.kozlowski@linaro.org, dri-devel@lists.freedesktop.org, kyungmin.park@samsung.com, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Inki Dae [ Upstream commit 4a059559809fd1ddbf16f847c4d2237309c08edf ] Fix a wrong error return by dropping an error return. When vidi driver is remvoed, if ctx->raw_edid isn't same as fake_edid_info then only what we have to is to free ctx->raw_edid so that driver removing can work correctly - it's not an error case. Signed-off-by: Inki Dae Reviewed-by: Andi Shyti Signed-off-by: Sasha Levin --- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c index 65b891cb9c50b..d882a22dfd6e6 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -483,8 +483,6 @@ static int vidi_remove(struct platform_device *pdev) if (ctx->raw_edid != (struct edid *)fake_edid_info) { kfree(ctx->raw_edid); ctx->raw_edid = NULL; - - return -EINVAL; } component_del(&pdev->dev, &vidi_component_ops); -- 2.39.2