Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 391E4EB64DA for ; Tue, 20 Jun 2023 00:42:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD40E8D0007; Mon, 19 Jun 2023 20:42:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C843A8D0001; Mon, 19 Jun 2023 20:42:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFD218D0007; Mon, 19 Jun 2023 20:42:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A2AEA8D0001 for ; Mon, 19 Jun 2023 20:42:49 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 604A4402E8 for ; Tue, 20 Jun 2023 00:42:49 +0000 (UTC) X-FDA: 80921276058.04.7853F8A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 5A66E10000F for ; Tue, 20 Jun 2023 00:42:47 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qk1SWrf4; spf=pass (imf05.hostedemail.com: domain of dakr@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dakr@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687221767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VAsnh4By1Dlsxa7yVRPYZeW4lQVXq7K2JYovOcCMg38=; b=Nj4ACUPOnWFIUxRGds91j96kfxw9xo/0Azb841WIIw2rCqXqgU4F1fccgYXh86wAgS3LUt eqLHeQuWuLywPtuaYgWZik81+MjDZfOfARKTP4fqtMRpuWgJc4TvewcdcEPmn/1bSO4Ega fTY9U2PUbYCg9xxhFv1+GhnQgfuLxxw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687221767; a=rsa-sha256; cv=none; b=RdABVxa9KolG0lAG7etAzFvs93M79hEKABKk8l8fNQEUPQaTZtDRxuA7fsqzZegMJYifbf 4i1FVso6qSRKUwg2W5qsxXrYIKI+VH5u8HfpbsCn4J9vBt5I2c0uqygU4UL20SlDBqdD69 7fB6a/q9XJNhVZ+1QwnX4p7ydycBFaw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qk1SWrf4; spf=pass (imf05.hostedemail.com: domain of dakr@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dakr@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687221766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VAsnh4By1Dlsxa7yVRPYZeW4lQVXq7K2JYovOcCMg38=; b=Qk1SWrf4crJCiNbsmnEA2yijuYXzZXS1684F8kMoZm2W2oR2MxeUWtiCWgT6QdRLKR5jQl 47J2QfgyT8iRKnkYZlqNvbZlStHtLEAq8pFUtxfgJ6vXiqgk/iVEJieIE3YUEg+FC6o0ie 0IKSVUUcRj+ilEBPl/ChBz9we4PoS+E= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-394-LI4tjQBkNbmrFXtuUeWQRw-1; Mon, 19 Jun 2023 20:42:45 -0400 X-MC-Unique: LI4tjQBkNbmrFXtuUeWQRw-1 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-51bca893729so76632a12.1 for ; Mon, 19 Jun 2023 17:42:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687221764; x=1689813764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VAsnh4By1Dlsxa7yVRPYZeW4lQVXq7K2JYovOcCMg38=; b=lD/UkDe0QaP0zd6i2sA9TKHK5mRT+9nV1NuB598P5K+tsdNMKar+C2Kx4YaCCNlGKv huQCmb92eXuqv0FAur//XdXnlHV6JNsUl2wum3iPFYFXy1VUWlBH5Qyj8qk9+wDRDT6c CWk2CAsMIno2jBesNAjBMb0jiZBEu2jzqZu/kS4Gwv9MG4cJQwEutN4OBT8HpokNIXV3 228QUYwY92E7daDLBg0PWE2wHBm+kn1mb93NI7awrRnELPc10xdYwTqCjEmsLLvo3xoh m27v+YEiE7HL2siaIeNORdjMcPE+Nb+z7qytosuIyuHBp9QPoZOAkBoihjck7RrZCLkP z/1A== X-Gm-Message-State: AC+VfDzbvgsWI9aD74m4EPMiXIn+fYm3cuZybv6kznQWZ2U6WUnUmLgR vCc0igT8rg3UtwJlFSb+CzDZSt80hFGq4P+g1wawHnuFh4lim5TFRYPkiVGG55XQBwpH0pxZKH7 fzpv1Su+LyYQ= X-Received: by 2002:a17:907:36c3:b0:988:fa98:2e7f with SMTP id bj3-20020a17090736c300b00988fa982e7fmr1299788ejc.38.1687221764010; Mon, 19 Jun 2023 17:42:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7HGMiGgWF6PMVUZoQgQKDhuvm3Qm7rw1HXP9heC2ekHKnGIcfwVvW2zWncnuxi/qoMwFCVhw== X-Received: by 2002:a17:907:36c3:b0:988:fa98:2e7f with SMTP id bj3-20020a17090736c300b00988fa982e7fmr1299766ejc.38.1687221763782; Mon, 19 Jun 2023 17:42:43 -0700 (PDT) Received: from cassiopeiae.. ([2a02:810d:4b3f:de9c:642:1aff:fe31:a19f]) by smtp.gmail.com with ESMTPSA id n22-20020a170906b31600b00982c0ac984asm386091ejz.176.2023.06.19.17.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 17:42:43 -0700 (PDT) From: Danilo Krummrich To: airlied@gmail.com, daniel@ffwll.ch, tzimmermann@suse.de, mripard@kernel.org, corbet@lwn.net, christian.koenig@amd.com, bskeggs@redhat.com, Liam.Howlett@oracle.com, matthew.brost@intel.com, boris.brezillon@collabora.com, alexdeucher@gmail.com, ogabbay@kernel.org, bagasdotme@gmail.com, willy@infradead.org, jason@jlekstrand.net Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Danilo Krummrich Subject: [PATCH drm-next v5 04/14] drm: debugfs: provide infrastructure to dump a DRM GPU VA space Date: Tue, 20 Jun 2023 02:42:07 +0200 Message-Id: <20230620004217.4700-5-dakr@redhat.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230620004217.4700-1-dakr@redhat.com> References: <20230620004217.4700-1-dakr@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Stat-Signature: 35aday3r443ffskzrtsj3de8ed81cjef X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5A66E10000F X-Rspam-User: X-HE-Tag: 1687221767-863905 X-HE-Meta: U2FsdGVkX18oOijNGEuwaLrSfbptAxLqMkAVb1CBF+kHnRkNqv9lXyFCWtVMrUsUYjIkXzhb9DHKeuEXPQSvUuncSSWUBzEyPMRAA9JUNmL2NyrAzvOd6dM1wemndt42YX/706+nBSHRi4SUcBA9S2OSU39BhaQPX3bluU9JRRlGIgMFoRvfIiW63oBRJdxWeAGg4HNvO89BDqVfMNXblLVjOQnGAfa19A4nvztbOui+DUmZbM/+P+Q+UFCsn13xXKLyUpXPG7NdkkYYoP+AFwahyTIFqAz3Xtvp6UabE93t1lucUmoujHslGy8Hf/PjG4RnvZ7pZB0QTlwEXYY8x8lEq0+kkC9jr7hlSXAYUqd5YvjAYK/XYSgVu33bqL6Nx//PKNHW8keHIDDFu5AFZPVqMa28am2AQrJO6EOHo5wnOsJGOMYqEoyrkYzwpiQM7ChMe4JMkRGS+eMeZtwWtbnS9M35iWnie53IEb//M3flPla0Mb4a2HEKqCwRAGr+uruJb8DnABzSl8yIdGcpya9AObqERGrerNTDZiQuinGfu8loVsTBmgUtAJUPdZTCRYquZCiJBqzXg6yQMkOHXPWe8I6uRbJd7SI2zAZx118bXZU0j5IUkCwEJbR0lqSKzUgpQhXyAvwiqQbDwuzNOGR283qhEoIUKNNUOIZcttqEAAHvzWJI7w1wFBzqlp1MBq2d97o/1ah23zCo3kieEgWK/bsKwKbSD7aIpfouBn24rvEcUUl4c03jTdOjoCkU0c3VTnvW1JdoLauxPkgngU88ON74oWojLbqOSxjQg/FAv1wwdqPWqt9r5DS64TrgaR3fBxJX/7lEynXsLqoYLB6eIhV8ip89fieeHPeC9Qm+SJFnGPIjN903+NEApQKXrXokDujYgZbcVprmGFIEH2V0kVvfk/gWvHMw86cxYK6vnOAe5dphbdcy9rltS1+ONZS9cAO1OwJMb8yTzcZ 6Co5nNHy GLyHEqSbDPPKTgwQOVDiB/sXAGUYv3dydnrKdS7TZ46fIKGgQpuplZ34rga5NJfVNceqN/DFhWgP3Gbss5LBO6zXxXfg1Mys6nwxo/7iZblzpNBb/wSGl+S3FMc8Yq5hrBvmYYxbEdlojG9Iuf2yABpY1KPOHVX6aOcCQTFnwfsx0Kp/60tTUc2th6HGMXHzCGnw8C99qcewtYy857ygKinn7XTrxusVixZ+KGXs/gKk5KEBWQhPPKoNPSVYBn9nNkptHTPecq0tRnYN3zfOZ+HQT+f1Wes9AGT5Tr5jOVJcDRKQ+IWficZAugQIzZTYmrz7Jw0F0CNX4jVfd6nc8IK1nABZf+XTV5DptBul+70jz3dG9RNJpn8sWbgpfrStfcSvY+plu0u9wuvgE/hGTZEYPFu4HSzpIflrFUxXRBx+s4+REpLS3iXtYiA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This commit adds a function to dump a DRM GPU VA space and a macro for drivers to register the struct drm_info_list 'gpuvas' entry. Most likely, most drivers might maintain one DRM GPU VA space per struct drm_file, but there might also be drivers not having a fixed relation between DRM GPU VA spaces and a DRM core infrastructure, hence we need the indirection via the driver iterating it's maintained DRM GPU VA spaces. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/drm_debugfs.c | 41 +++++++++++++++++++++++++++++++++++ include/drm/drm_debugfs.h | 25 +++++++++++++++++++++ 2 files changed, 66 insertions(+) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index 4855230ba2c6..82180fb1c200 100644 --- a/drivers/gpu/drm/drm_debugfs.c +++ b/drivers/gpu/drm/drm_debugfs.c @@ -39,6 +39,7 @@ #include #include #include +#include #include "drm_crtc_internal.h" #include "drm_internal.h" @@ -175,6 +176,46 @@ static const struct file_operations drm_debugfs_fops = { .release = single_release, }; +/** + * drm_debugfs_gpuva_info - dump the given DRM GPU VA space + * @m: pointer to the &seq_file to write + * @mgr: the &drm_gpuva_manager representing the GPU VA space + * + * Dumps the GPU VA mappings of a given DRM GPU VA manager. + * + * For each DRM GPU VA space drivers should call this function from their + * &drm_info_list's show callback. + * + * Returns: 0 on success, -ENODEV if the &mgr is not initialized + */ +int drm_debugfs_gpuva_info(struct seq_file *m, + struct drm_gpuva_manager *mgr) +{ + DRM_GPUVA_ITER(it, mgr, 0); + struct drm_gpuva *va, *kva = &mgr->kernel_alloc_node; + + if (!mgr->name) + return -ENODEV; + + seq_printf(m, "DRM GPU VA space (%s) [0x%016llx;0x%016llx]\n", + mgr->name, mgr->mm_start, mgr->mm_start + mgr->mm_range); + seq_printf(m, "Kernel reserved node [0x%016llx;0x%016llx]\n", + kva->va.addr, kva->va.addr + kva->va.range); + seq_puts(m, "\n"); + seq_puts(m, " VAs | start | range | end | object | object offset\n"); + seq_puts(m, "-------------------------------------------------------------------------------------------------------------\n"); + drm_gpuva_iter_for_each(va, it) { + if (unlikely(va == &mgr->kernel_alloc_node)) + continue; + + seq_printf(m, " | 0x%016llx | 0x%016llx | 0x%016llx | 0x%016llx | 0x%016llx\n", + va->va.addr, va->va.range, va->va.addr + va->va.range, + (u64)va->gem.obj, va->gem.offset); + } + + return 0; +} +EXPORT_SYMBOL(drm_debugfs_gpuva_info); /** * drm_debugfs_create_files - Initialize a given set of debugfs files for DRM diff --git a/include/drm/drm_debugfs.h b/include/drm/drm_debugfs.h index 7616f457ce70..cb2c1956a214 100644 --- a/include/drm/drm_debugfs.h +++ b/include/drm/drm_debugfs.h @@ -34,6 +34,22 @@ #include #include + +#include + +/** + * DRM_DEBUGFS_GPUVA_INFO - &drm_info_list entry to dump a GPU VA space + * @show: the &drm_info_list's show callback + * @data: driver private data + * + * Drivers should use this macro to define a &drm_info_list entry to provide a + * debugfs file for dumping the GPU VA space regions and mappings. + * + * For each DRM GPU VA space drivers should call drm_debugfs_gpuva_info() from + * their @show callback. + */ +#define DRM_DEBUGFS_GPUVA_INFO(show, data) {"gpuvas", show, DRIVER_GEM_GPUVA, data} + /** * struct drm_info_list - debugfs info list entry * @@ -134,6 +150,9 @@ void drm_debugfs_add_file(struct drm_device *dev, const char *name, void drm_debugfs_add_files(struct drm_device *dev, const struct drm_debugfs_info *files, int count); + +int drm_debugfs_gpuva_info(struct seq_file *m, + struct drm_gpuva_manager *mgr); #else static inline void drm_debugfs_create_files(const struct drm_info_list *files, int count, struct dentry *root, @@ -155,6 +174,12 @@ static inline void drm_debugfs_add_files(struct drm_device *dev, const struct drm_debugfs_info *files, int count) {} + +static inline int drm_debugfs_gpuva_info(struct seq_file *m, + struct drm_gpuva_manager *mgr) +{ + return 0; +} #endif #endif /* _DRM_DEBUGFS_H_ */ -- 2.40.1