Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F268EB64D7 for ; Fri, 23 Jun 2023 05:52:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229484AbjFWFwR (ORCPT ); Fri, 23 Jun 2023 01:52:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231137AbjFWFwJ (ORCPT ); Fri, 23 Jun 2023 01:52:09 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03F831A1 for ; Thu, 22 Jun 2023 22:52:09 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 8CFEC67373; Fri, 23 Jun 2023 07:52:05 +0200 (CEST) Date: Fri, 23 Jun 2023 07:52:05 +0200 From: Christoph Hellwig To: Bart Van Assche Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Vineeth Vijayan , Damien Le Moal , Ming Lei , Mike Snitzer , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Juergen Gross , Stefano Stabellini , Alasdair Kergon , dm-devel@redhat.com, Keith Busch , Sagi Grimberg , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , "James E.J. Bottomley" , "Martin K. Petersen" Subject: Re: [PATCH v4 7/7] block: Inline blk_mq_{,delay_}kick_requeue_list() Message-ID: <20230623055205.GF9085@lst.de> References: <20230621201237.796902-1-bvanassche@acm.org> <20230621201237.796902-8-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230621201237.796902-8-bvanassche@acm.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Jun 21, 2023 at 01:12:34PM -0700, Bart Van Assche wrote: > Patch "block: Preserve the order of requeued requests" changed > blk_mq_kick_requeue_list() and blk_mq_delay_kick_requeue_list() into > blk_mq_run_hw_queues() and blk_mq_delay_run_hw_queues() calls > respectively. Inline blk_mq_{,delay_}kick_requeue_list() because these > functions are now too short to keep these as separate functions. You're not inlining them, but you're removing them and open code the trivial logic in the callers. The code change looks good to me, though.