Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD700EB64DA for ; Sat, 24 Jun 2023 20:40:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B3314846C2; Sat, 24 Jun 2023 22:39:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="juOqQQr/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0F305847E3; Sat, 24 Jun 2023 22:39:57 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D02B0846A5 for ; Sat, 24 Jun 2023 22:39:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A8D5600BE; Sat, 24 Jun 2023 08:50:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 623A0C433C8; Sat, 24 Jun 2023 08:50:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687596644; bh=94J96KJsvilpU5JqweK6CxQ9fClt/iRa5nNOMnvq1qc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=juOqQQr/beDHVY23qCjR7zsb4H9g0xV150I5TzReLmlR4zMrzmpS3Unk+xSn+HvWW l/PXtKgdpwZsnfgmQRjR8Evhgk059xv6Y/js6keAb2C63Z6iP7CYfCuEjhhtAbKU1A zogEA2J2SWKFVo31LI1oZlK/wPe9LHRndhPGv2N+LAapAn4WwP77Y7ZqfKj83s9DGe RU9kc5Pg/kR4QTEPHL7/dUO+KODof2SzC4UQSH68AFaUInkHGXIVfnKwCFlxsHmj2F epVGQkWnfuZaPNyb9yurBGwNgQXCh7ZL1xEgl7ZgxYJ+njKU3jPXi7/UA0tpJU7Ncs iu3yzAZgfavPg== Received: by pali.im (Postfix) id A0B42723; Sat, 24 Jun 2023 10:50:41 +0200 (CEST) Date: Sat, 24 Jun 2023 10:50:41 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Simon Glass Cc: Tom Rini , Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH u-boot 0/3] Revert broken Bootmenu commits Message-ID: <20230624085041.jf3rs6bptfuzmaxy@pali> References: <20230611125324.15860-1-pali@kernel.org> <20230614195121.GR3931582@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Tuesday 20 June 2023 11:20:35 Simon Glass wrote: > Hi Tom, Pali, > > On Wed, 14 Jun 2023 at 20:51, Tom Rini wrote: > > > > On Sun, Jun 11, 2023 at 02:53:21PM +0200, Pali Rohár wrote: > > > > > These 3 commits broke support for U-Boot Bootmenu on Nokia N900. > > > Issues were reported more than month ago, but nobody reacted to them. > > > So revert these broken commits for now, to fix U-Boot Bootmenu support. > > > > > > With these revered commits, U-Boot Bootmenu from master branch is > > > working fine again on Nokia N900. > > > > > > Pali Rohár (3): > > > Revert "video: Enable VIDEO_ANSI by default only with EFI" > > > Revert "menu: Factor out menu-keypress decoding" > > > Revert "menu: Make use of CLI character processing" > > > > > > cmd/bootmenu.c | 9 ++-- > > > cmd/eficonfig.c | 12 ++--- > > > common/cli_getch.c | 12 ++--- > > > common/menu.c | 122 ++++++++++++++++++++++++++---------------- > > > drivers/video/Kconfig | 7 +-- > > > include/cli.h | 4 +- > > > include/menu.h | 17 +----- > > > 7 files changed, 91 insertions(+), 92 deletions(-) > > > > Following up over here, while > > https://patchwork.ozlabs.org/project/uboot/patch/20230612201434.861700-1-sjg@chromium.org/ > > addresses some of the issues, but not all (as it clearly isn't working > > in all of the cases Pali has explained), looking in to the VIDEO_ANSI > > part of this too, all three of these reverts are related seemingly to > > something escape-character related. I'm not taking any of the revert > > commits in just yet, but will by the next -rc if we don't have something > > that fixes all of the issues. > > I did send a series [1] with a fix for the nokia_rx51 keyboard driver, > including the previous ansi-code patch. Given that: > > - this problem doesn't seem to manifest on other boards > - it does not cause any CI test to fail > - there seem to be bugs in the nokia_rx51 implementation which are a > possible/likely cause > - the nokia_rx51 CI uses a 10-year-old out-of-tree QEMU > - the problem goes away if debugging is added, suggesting it is > related to timing > > ...I don't think a revert is appropriate. Unfortunately it does not fix this issue :-( New patch series from [1] applied on top of the master branch has still issue with DOWN key on emulated UART terminal. > Pali, can you please take a look and see if you can debug what is > actually going on? Here is my guess: > > 1. When an arrow key is pressed, cli_ch_process() handles it by being > passed the codes in sequence: \e [ B > 2. Calling cli_ch_process() with ichar = 0 causes it to think the > sequence is finished: \e [ \0 B (this doesn't work since the \0 ends > the sequence) > 3. nokia_rx51 keyboard driver is returning '\0' even when key codes > are pending, causing cli_ch_process() to be told that the sequence is > done I can look at it later, but I'm loosing motivation to do whole debugging for another issue again, because for the last year my fixes and other patches were stalled and u-boot devs show me that they are not interested even in commenting them. I do not want to work again on something which would be ignored. Hence, now I did only smaller - but still important - task: Locate exact commits which broke particular feature and prepare reverts on top of the master branch which _really_ fix the broken functionality - and make code working again. > It would help to move the keyboard driver into drivers/input/ so it is > easier to find. > > Regards, > Simon > > [1] https://patchwork.ozlabs.org/project/uboot/list/?series=360134