Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E68CEB64DC for ; Sun, 25 Jun 2023 14:52:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 74D27846E5; Sun, 25 Jun 2023 16:52:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="G3Xk3us9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B54DA861A5; Sun, 25 Jun 2023 16:52:21 +0200 (CEST) Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 15852846E0 for ; Sun, 25 Jun 2023 16:52:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-57026f4bccaso24851737b3.2 for ; Sun, 25 Jun 2023 07:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1687704737; x=1690296737; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HBFJpaeFXAVFkNW9lDUpUqrwAF2+F6YG270w5ExKJbM=; b=G3Xk3us98juYntRvBKokjvAnIkuhQn32LlSZKKeeGukinIppeJYAITtafLiLeJO+Vt 4ebesqOYPeto1vlaRztBlt/cSh2Z1VVvtwPm4zi10mKKPFHmriosVcw24rSr9e0Efn4k 8Hd/pJ1NfEc2vKa5AOdFv8DRBK0GsoqXsha6k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687704737; x=1690296737; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HBFJpaeFXAVFkNW9lDUpUqrwAF2+F6YG270w5ExKJbM=; b=I4H94DoFDycq/bGc3cH3wJdPUrsDEcnBPO2BIAk6by1vdLtgTA7lHx/4JijZFDFM6T mByNjTdLT6QfN3nKLalvUs/89d13gSRFYbO9nUKFp/L6RQMlZrjHEjmCndj+PEXcx987 v2rMH+NI3aFd1vz3Ezj/EAbKqoyjLojI/LfWD78xnJG5m6srgHlx1k/uec5uWYNfpdGe Au4Ol6BeIGavrvaBofahkZ5XuQq7mRvuA104pqreyEW4+f1L9ZWoj9fNQbQgSQbKejhu bkbelJSnThjcWk7EP5vevkN3v6Hm/YlKhiRJRgELm0p4soZ9Mj64jhIE8dV5K47ifd2M lR2w== X-Gm-Message-State: AC+VfDzXmofVk8siyNaZSDpKeS6tRm3vI37kI6VTD9Jhfm2guuOCAwjq tSmzeDo+c21CWiV4ESa4qqEGZg== X-Google-Smtp-Source: ACHHUZ6aA3PkUNJn/5OTVQzeHVyL2oLFE8Fdkhl7C4BFi5xtxDniVR6B/lWl+OrqoAEnWHvmWY4fMQ== X-Received: by 2002:a0d:f7c6:0:b0:576:6b83:2466 with SMTP id h189-20020a0df7c6000000b005766b832466mr7376650ywf.25.1687704736714; Sun, 25 Jun 2023 07:52:16 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-da61-6355-3777-b00c.res6.spectrum.com. [2603:6081:7b00:6400:da61:6355:3777:b00c]) by smtp.gmail.com with ESMTPSA id d125-20020a0ddb83000000b0057068c6924esm844783ywe.75.2023.06.25.07.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jun 2023 07:52:15 -0700 (PDT) Date: Sun, 25 Jun 2023 10:52:13 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH u-boot 0/3] Revert broken Bootmenu commits Message-ID: <20230625145213.GI3931582@bill-the-cat> References: <20230611125324.15860-1-pali@kernel.org> <20230614195121.GR3931582@bill-the-cat> <20230624085041.jf3rs6bptfuzmaxy@pali> <20230624165807.GX3931582@bill-the-cat> <20230625075039.j6unegxdpp2lj27p@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zZYHX64+K03mk2Er" Content-Disposition: inline In-Reply-To: <20230625075039.j6unegxdpp2lj27p@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --zZYHX64+K03mk2Er Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 25, 2023 at 09:50:39AM +0200, Pali Roh=E1r wrote: > On Saturday 24 June 2023 12:58:07 Tom Rini wrote: > > On Sat, Jun 24, 2023 at 10:50:41AM +0200, Pali Roh=E1r wrote: > > > On Tuesday 20 June 2023 11:20:35 Simon Glass wrote: > > > > Hi Tom, Pali, > > > >=20 > > > > On Wed, 14 Jun 2023 at 20:51, Tom Rini wrote: > > > > > > > > > > On Sun, Jun 11, 2023 at 02:53:21PM +0200, Pali Roh=E1r wrote: > > > > > > > > > > > These 3 commits broke support for U-Boot Bootmenu on Nokia N900. > > > > > > Issues were reported more than month ago, but nobody reacted to= them. > > > > > > So revert these broken commits for now, to fix U-Boot Bootmenu = support. > > > > > > > > > > > > With these revered commits, U-Boot Bootmenu from master branch = is > > > > > > working fine again on Nokia N900. > > > > > > > > > > > > Pali Roh=E1r (3): > > > > > > Revert "video: Enable VIDEO_ANSI by default only with EFI" > > > > > > Revert "menu: Factor out menu-keypress decoding" > > > > > > Revert "menu: Make use of CLI character processing" > > > > > > > > > > > > cmd/bootmenu.c | 9 ++-- > > > > > > cmd/eficonfig.c | 12 ++--- > > > > > > common/cli_getch.c | 12 ++--- > > > > > > common/menu.c | 122 ++++++++++++++++++++++++++--------= -------- > > > > > > drivers/video/Kconfig | 7 +-- > > > > > > include/cli.h | 4 +- > > > > > > include/menu.h | 17 +----- > > > > > > 7 files changed, 91 insertions(+), 92 deletions(-) > > > > > > > > > > Following up over here, while > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230612201434.8= 61700-1-sjg@chromium.org/ > > > > > addresses some of the issues, but not all (as it clearly isn't wo= rking > > > > > in all of the cases Pali has explained), looking in to the VIDEO_= ANSI > > > > > part of this too, all three of these reverts are related seemingl= y to > > > > > something escape-character related. I'm not taking any of the re= vert > > > > > commits in just yet, but will by the next -rc if we don't have so= mething > > > > > that fixes all of the issues. > > > >=20 > > > > I did send a series [1] with a fix for the nokia_rx51 keyboard driv= er, > > > > including the previous ansi-code patch. Given that: > > > >=20 > > > > - this problem doesn't seem to manifest on other boards > > > > - it does not cause any CI test to fail > > > > - there seem to be bugs in the nokia_rx51 implementation which are a > > > > possible/likely cause > > > > - the nokia_rx51 CI uses a 10-year-old out-of-tree QEMU > > > > - the problem goes away if debugging is added, suggesting it is > > > > related to timing > > > >=20 > > > > ...I don't think a revert is appropriate. > > >=20 > > > Unfortunately it does not fix this issue :-( New patch series from [1] > > > applied on top of the master branch has still issue with DOWN key on > > > emulated UART terminal. > > >=20 > > > > Pali, can you please take a look and see if you can debug what is > > > > actually going on? Here is my guess: > > > >=20 > > > > 1. When an arrow key is pressed, cli_ch_process() handles it by bei= ng > > > > passed the codes in sequence: \e [ B > > > > 2. Calling cli_ch_process() with ichar =3D 0 causes it to think the > > > > sequence is finished: \e [ \0 B (this doesn't work since the \0 e= nds > > > > the sequence) > > > > 3. nokia_rx51 keyboard driver is returning '\0' even when key codes > > > > are pending, causing cli_ch_process() to be told that the sequence = is > > > > done > > >=20 > > > I can look at it later, but I'm loosing motivation to do whole debugg= ing > > > for another issue again, because for the last year my fixes and other > > > patches were stalled and u-boot devs show me that they are not > > > interested even in commenting them. I do not want to work again on > > > something which would be ignored. > >=20 > > Well, unless your changes here break something else, I don't think a fix > > for your problem will be ignored. >=20 > This is something which I read here more times in the past... and > reality was different. >=20 > Should I remind you that there are waiting eMMC fixes for mvebu and > again discussion about them stalled? Or rather should I say that it is > again ignored? No, you should just say they're still waiting for review. Since they're waiting for review. The MMC custodian has been asked to review them, and hasn't yet. And they don't appear to be super critical changes, and they conflict with other series, so yes, they'll get picked up when the custodian has time to review everything. > I have already spend time on this and have done everything needed to > make bootmenu working again. I have also prepared patches which are > fixing this problem and which were also tested. Note that "I reverted the commit" is not a fix. > And if you want something more from me then you show me why this time it > would be different, and again empty promises. What I'd like is for you to not assume worst-faith. If you can fix the problem quickly at this point it'll get reviewed (assuming Simon has time, next week is EOSS) and merged if it's a safe enough looking fix. Otherwise it'll get in v2023.10. > > > Hence, now I did only smaller - but still important - task: Locate ex= act > > > commits which broke particular feature and prepare reverts on top of = the > > > master branch which _really_ fix the broken functionality - and make > > > code working again. > >=20 > > Unfortunately you're also the only person able to replicate the problem, > > and Simon has tried (and posted fixes to your platform for other issues, > > and debugging patches to hopefully making finding the problem easier). >=20 > Have somebody else even tried to reproduce this issue on any other HW > board or any other qemu board? The summary of Simon's thread where he tried to fix this problem is that only your platform still has a problem here. --=20 Tom --zZYHX64+K03mk2Er Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmSYVJQACgkQFHw5/5Y0 tyzTsgwAlDkw+3IxZxAf4b0jMGfw8KdcOPccDcsjfosee1OtqkUF9oJO7Ah4dkDS W91FObmXc10MQI1SVugFoF8AO6JFadRCDn6OuB2MU5GyH61bFGQ2rcEy/jxaFGqN 0HU9Y7+b/1lSpA8IYM2Xx5YLUdMNJUfYtpDnXsrUrE7lCQOCUVV2juHkWVkkETab tFCCmQ+4NqrNBa+sLu/id0HgJEC/inggoog85nCn2d6Nxv9g0+QYGRSA2zhiY54q Fl2iG+tOp4P3UHVvQPWYqDsKpUP+enb6EDvGuk/pbimkBIu4p1A5kC9qD/02aHjK soM5vwMC4PQ35bMXtBQvQiqcsRJgUmXVuOtvUp6dI28MCawTUSdswxlgrFEjI+tZ QskMbHzt+sHQWM5PCtPloTZOwq5vlwKxG6TvPnMNqfRNhwv+bJqJQA8jKPHIbRNx wu/vzbST2t3rwHazIqX0LRq2sNwA3zr/m+ZXlNr9tA3dsWcDxHjwQMtoGzELhBFT sdJ7dLEK =2F/p -----END PGP SIGNATURE----- --zZYHX64+K03mk2Er--