Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6FE99463 for ; Sun, 25 Jun 2023 23:07:49 +0000 (UTC) Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-666edfc50deso1679231b3a.0 for ; Sun, 25 Jun 2023 16:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687734469; x=1690326469; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vHqxeAotCnxkuVm3NE+mpH766uEaTTmXxUGQT2/zQXg=; b=i9FKP9QrAGjLwKNZZ0JjhCkf0OQyEDv1x5RoB0qkg01vXGEfopl3Pddg/0ZR7XvUAu nlUzlRpvzCu5obICyLJZvONDx9iY6BZ0s2/+5xurDlD7Ik02CCkPsMfRCrxKCLpyxcuT jfXlX0bd4+50EW1NEwUUP9y6ZrFDgwDJTzQzul3vON/QSiaVDzVMcmQefZn1P+VltW86 TIN3lu718abHeVvJ8TIxYYeKB0dfr6TXIIhnhl/2lsJgnSwXVz/4Ch8Oz87KMKr8jB83 Pqlutht00f3Nrfr3oFyYtklEqpDK8Rm8TdV3ryis7oio3m2Kvls9pjCi4Jepvhw79tBf Gv3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687734469; x=1690326469; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vHqxeAotCnxkuVm3NE+mpH766uEaTTmXxUGQT2/zQXg=; b=ZybB9P9lIZtmDIP9jfM9lTx3NnqZeExvHe+HXyMXr5mOJ22xB/j5cXokTH2zroKAQ6 wplM6Kz5cUlpYBbRR0AtsX++VQC/yxmZejQDrclT1Xuzej8Fs6bncuyB4UTFL7YcX3DJ ZW7sXRwNr2hhsyEfW1/0dzscY+N3Ua3zdp7hzfgYmGs1nf0moZPlS6y/o7Qzn0vsuWAq 9plyggf2OXHVTrThRlWNidvzWrBo5ePa0WOYnfJ9UGi6k+TFQEHuwy3DxCdRPanCs3wY Mz619xfpXTw1p3m1/vQ1+AKueQBvRetJQfx5aL0DuAcAzr0g95Af1q48F7XEPOearc1m 74iw== X-Gm-Message-State: AC+VfDzd9vZL2iAnQJKFqE+Vz+08HghdAvhxmoN91mbL+1BK9r2u5X/j tsM1OwaHIWgXvkVeRL6GhHw= X-Google-Smtp-Source: ACHHUZ6LiPxrHGKgvRwbrsWtmWQj0OpsUWu9zZW9lZ/7lWInjAzmncaflAQwfnGrIxaGPDnKxNv5Mg== X-Received: by 2002:a05:6a21:32a2:b0:110:b7fb:2c92 with SMTP id yt34-20020a056a2132a200b00110b7fb2c92mr35741019pzb.11.1687734469017; Sun, 25 Jun 2023 16:07:49 -0700 (PDT) Received: from sc9-mailhost1.vmware.com (c-24-6-216-183.hsd1.ca.comcast.net. [24.6.216.183]) by smtp.gmail.com with ESMTPSA id x20-20020aa79194000000b006668f004420sm2716397pfa.148.2023.06.25.16.07.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jun 2023 16:07:48 -0700 (PDT) From: Nadav Amit X-Google-Original-From: Nadav Amit To: Andrew Jones Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, Nikos Nikoleris , Paolo Bonzini , Nadav Amit Subject: [kvm-unit-tests PATCH v2 1/6] efi: keep efi debug information in a separate file Date: Sun, 25 Jun 2023 23:07:11 +0000 Message-Id: <20230625230716.2922-2-namit@vmware.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230625230716.2922-1-namit@vmware.com> References: <20230625230716.2922-1-namit@vmware.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Nadav Amit Debugging tests that run on EFI is hard because the debug information is not included in the EFI file. Dump it into a separeate .debug file to allow the use of gdb or pretty_print_stacks script. Signed-off-by: Nadav Amit --- v1->v2: * Making clean should remove .debug [Andrew] * x86 EFI support [Andrew] --- arm/Makefile.common | 5 ++++- x86/Makefile.common | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/arm/Makefile.common b/arm/Makefile.common index d60cf8c..9b45a8f 100644 --- a/arm/Makefile.common +++ b/arm/Makefile.common @@ -78,6 +78,9 @@ ifeq ($(CONFIG_EFI),y) %.efi: %.so $(call arch_elf_check, $^) + $(OBJCOPY) --only-keep-debug $^ $@.debug + $(OBJCOPY) --strip-debug $^ + $(OBJCOPY) --add-gnu-debuglink=$@.debug $^ $(OBJCOPY) \ -j .text -j .sdata -j .data -j .dynamic -j .dynsym \ -j .rel -j .rela -j .rel.* -j .rela.* -j .rel* -j .rela* \ @@ -103,7 +106,7 @@ $(libeabi): $(eabiobjs) $(AR) rcs $@ $^ arm_clean: asm_offsets_clean - $(RM) $(TEST_DIR)/*.{o,flat,elf,so,efi} $(libeabi) $(eabiobjs) \ + $(RM) $(TEST_DIR)/*.{o,flat,elf,so,efi,debug} $(libeabi) $(eabiobjs) \ $(TEST_DIR)/.*.d $(TEST_DIR)/efi/.*.d lib/arm/.*.d generated-files = $(asm-offsets) diff --git a/x86/Makefile.common b/x86/Makefile.common index 9f2bc93..c42c3e4 100644 --- a/x86/Makefile.common +++ b/x86/Makefile.common @@ -54,6 +54,9 @@ ifeq ($(CONFIG_EFI),y) @chmod a-x $@ %.efi: %.so + $(OBJCOPY) --only-keep-debug $^ $@.debug + $(OBJCOPY) --strip-debug $^ + $(OBJCOPY) --add-gnu-debuglink=$@.debug $^ $(OBJCOPY) \ -j .text -j .sdata -j .data -j .dynamic -j .dynsym -j .rel \ -j .rela -j .reloc -S --target=$(FORMAT) $< $@ @@ -124,4 +127,4 @@ arch_clean: $(RM) $(TEST_DIR)/*.o $(TEST_DIR)/*.flat $(TEST_DIR)/*.elf \ $(TEST_DIR)/.*.d lib/x86/.*.d \ $(TEST_DIR)/efi/*.o $(TEST_DIR)/efi/.*.d \ - $(TEST_DIR)/*.so $(TEST_DIR)/*.efi + $(TEST_DIR)/*.so $(TEST_DIR)/*.efi $(TEST_DIR)/*.debug -- 2.34.1