Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1qEvz0-0002JR-Jt for mharc-grub-devel@gnu.org; Thu, 29 Jun 2023 14:03:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEvyw-0002Ie-La for grub-devel@gnu.org; Thu, 29 Jun 2023 14:03:04 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEvyp-0006Hg-Ac for grub-devel@gnu.org; Thu, 29 Jun 2023 14:02:58 -0400 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35TH4AaI000355; Thu, 29 Jun 2023 18:02:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-type : mime-version; s=corp-2023-03-30; bh=GxMbq3nMAMYD1OFLWwAyT4Tr+cYBVFlJ/D0UwkLAICI=; b=dUuXBMsZrFUP0p4eH/7VNL4VS39ETuQ+74K7M/3EzEpz+OtseH5/Fnh0jL7i2itAgXoP CHIPiBd0E8FWLk6dOY/5z1kgGIVY2KduJA7nK1GjBx1kuJCP74QLK9A7Liba1cVjI2sa SYcPtmouRj057JfcaaqmYo6ALxwpJoRjvE+zbh0mPBJoUtc8VNJkuexU5j5b5LOW4Zyd hB/x4cVybv5BVM+akeqNEFOR5Ixfh1QqP5HdyA0Fxu0qTmwZ/65PYgD6OYADInFqqtSb Krx0MLadXsmEwASOYJIIjNeBD0C93wsuTgroz6YApvN3OGMs9t+SLeuRG8L2zUGyjqAw yw== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3rdq93dd78-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Jun 2023 18:02:43 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35THSLgl029755; Thu, 29 Jun 2023 18:02:42 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3rdpx7qxwe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Jun 2023 18:02:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O3dM/udI2myhMoDDt1r/zeWIyhA4ut0S3EOUghwyXUxEaYzwhnSnu+bR96CJE9qi4l0Dy8ysPWtafTipNFLiRv3pr1/qWXhxJc+w05Is+YoXkfxvnngHT+E7E+lJeeExG/ub4KvsApwlH74rGGJQayXURRk2vdBOQ0ZGXt+ec/HQKyHJvUgPXfE+Xgn8YwsVU2q8c9hMx5wkGDRbpSBahxForKakEBwmiS0MxUV76TLTPQ4HfTiH2s0gSyWvdlc9q0r4ZnKAtHVmOb1I3xbthmFgOC0hXtvnwYo32rgxCM7lYRtbah1/+h0oQ9j2/KUkdvivtJ9OF2s5DVa8ZO+KWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GxMbq3nMAMYD1OFLWwAyT4Tr+cYBVFlJ/D0UwkLAICI=; b=fM4gKu4ww2UYNNuA5wxjp2TbJTBThXRcvtM6clTvJRJEwKvIxuDBqvOVWrrEJWCmCxPhTyoxjYRTDpEStmIWj36mpDqgjtoDzKUp2SkqgUKn82xo39I0X0IvhLXNAEk6jWZ0NKZlQXxI86aQbTFQgxFW3AIb/JqYDjsNfDA7AmFljxzOlcrEE6kjRCBhc704MVDVPBv8q+cJwLnxFemfHGPJnEPfnNX6QTsc77ASX9qX7jcn2cDzZH7g3PrqLOn7ZU95RgXBtbHDpypkVPohDxgmRqMGRMmY+oc+gS1nPTmKh47U3tgIuHKFRnsff1FzhojkKZ0MF72hLMryE7LQuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GxMbq3nMAMYD1OFLWwAyT4Tr+cYBVFlJ/D0UwkLAICI=; b=bQDR67a0n83IqUIjVtm1h4wx95eUsfG5zOPJlyq2iqkpEhL4mYX5O1FoxQiclP5XW/VLsQlUeuT+rmG0qVfLbQmCsq0fAej9ApuUVbNbdI4OLIpJf9WGxoVA4Ox8+ZxyMw5IyAgr2xsOLhpz4akaCH9WaGnCedADXeVAhEdOVFI= Received: from BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) by DM6PR10MB4140.namprd10.prod.outlook.com (2603:10b6:5:21b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Thu, 29 Jun 2023 18:02:40 +0000 Received: from BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::86ed:de25:a973:cae6]) by BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::86ed:de25:a973:cae6%2]) with mapi id 15.20.6521.026; Thu, 29 Jun 2023 18:02:40 +0000 From: Daniel Kiper To: grub-devel@gnu.org Cc: ardb@kernel.org, development@efficientek.com, dimitri.ledkov@canonical.com, julian.klode@canonical.com, mjg59@srcf.ucam.org, pjones@redhat.com, rshailu.yash@gmail.com, tobias.powalowski@googlemail.com, thomas.frauendorfer@gmail.com Subject: [PATCH v2 0/2] efi: Secure Boot fixes Date: Thu, 29 Jun 2023 20:02:30 +0200 Message-Id: <20230629180232.1023-1-daniel.kiper@oracle.com> X-Mailer: git-send-email 2.11.0 Content-Type: text/plain X-ClientProxiedBy: BE1P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:7b::19) To BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN0PR10MB4822:EE_|DM6PR10MB4140:EE_ X-MS-Office365-Filtering-Correlation-Id: d1311676-3ead-46a5-f026-08db78cb0778 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JQrWvRt6OxepnitOx5gRMQYN2QX0Mq3FDpAIUhwztwevC9sisNnculUPtPvlkO+A2q45pCVaQ8vgMDjwdvBrElKgO/K/9qHN8o4vqQzn+XeWcSjFsRX6TjOT3ecKLD/T/dky2wYkqT7fbaBpP9dyhtoCTu/Mpn/4x2KUTenJan9xgonzTZQMrDqBLm1hMAZFt3UOU79aCaFr+qSi/I0gMzcwX+nqPpRzWYmv6EBNjwoUCMt/OJ6VbvfXkxI+NM4tWsYcDlodq1XTouxfc4fIsqn0EwKLEmzzqG4Y5vOkiDJhpZ/la1rYbY9vGQuGqxmcOnMVHaAN85eQRPr6V9zSQvkjBnwBdWPGDPWBC11jCSuzRSVDcd4LcUh8ZdWPMCPcj8u55kUqKs2Fd6EOhqtVIj6+ThV5lDbcAs6Rk3wzqHC+/lnush5qYFJX0R1UwLg1KWW1hMG8OxzLIZHJ1tnq80aX1hQjwrzNSWippzIBBkK3Wvtg+D4eCFq1TFoiG1rdolqw7ZN1Otjsypra5XS+iGwLJ18QDX02mpLgUbLm4i5wYjVqYbB26PAenTV50h5H X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR10MB4822.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199021)(83380400001)(6666004)(478600001)(6486002)(1076003)(4744005)(66946007)(2906002)(186003)(26005)(66476007)(6506007)(66556008)(6512007)(4326008)(5660300002)(316002)(44832011)(41300700001)(7416002)(38100700002)(8676002)(6916009)(8936002)(36756003)(86362001)(2616005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?G24jBSL7o1uNypHwXV1QFPykbh7901t9UBdGzECATbKxpCiZOjniNmxCrt7N?= =?us-ascii?Q?WAHIABmnxPFsekZCzjCbZSXoBbEONw2Fd7e6nkAwIwHsaPN2MRRAPnytV2xr?= =?us-ascii?Q?SDBYn2E5BbdbES5/PBixAk7XPkikTRecGEU7ysNR3mE5SywTTWD57GicXBG7?= =?us-ascii?Q?Hga3ElTLFZNKVSewFRKiRl3kj1jEkCLG/kIExtE1ZO0X2d6lhxIniXhQhuiJ?= =?us-ascii?Q?7mojTWDBMJ2YifkpztP9l3tsDYRihEKCjnEKonIVnE0ehVdzw1J5RXkMdAdC?= =?us-ascii?Q?TzsuhY5+MFySNYbHBaQIVvld2oYjFmUQonjI1RA4iqrYXkPQYQWtCVWwUdy/?= =?us-ascii?Q?MYYBRRmkGhKmRX20voROB/mlZq/3ChAFR0BsW5e3iLdtWMhZFCox87/DUn4A?= =?us-ascii?Q?XQPM7QVdfQQ5ZJUriNpvg5qgxJAHfbonArKyezyyGEEKF3li72QO8ClTrUwm?= =?us-ascii?Q?+wpNOKv/bE7W7iP4bXORcgQTI24nmSxrAbTMJWD8EnkVNKIsuvOQSwq6ENFx?= =?us-ascii?Q?2+enl/dyJN/+9FVE95czk6UcswUVeBxXaQRTVE9ge3zgyWu3jwtrsl5bMIBI?= =?us-ascii?Q?zI8Kzz9WRxLmxJaiLzPT+ejPHEj/92t3QNQbSrmOltCRPj6QdmKXA/d03yIR?= =?us-ascii?Q?eX1eKe+3uuxQjCKfscJ1b3pkTgtD/zBowYbmSMouhq6N/giwvkvG4K1+UMOS?= =?us-ascii?Q?3RDE8geKcdM6kwgLf3ewUFGCFLmuFhdw23rZNgYmNnSXc4DF+m3X9XnaxEYJ?= =?us-ascii?Q?r0AIuUB/txpzr5urzoU9E4QNBcRZMipmyGKZlRRAGktuMo4ZR6f0eOoPafJ4?= =?us-ascii?Q?tZN02zys1Py2kDGgvvLdt1wy2V/TsUPq2TrF3+QoluLh6rMJl3Q81/D3+z4E?= =?us-ascii?Q?vEpGJC6LAuu5fl88tbDbxSWP6zvL+AETS+xPCWVMNMUq4as5P1EZFulLkYvP?= =?us-ascii?Q?Ub0ib0GJ7uM6Tnz91Dl20hG0WvijN36IPIxQPcNrFDFC1oAIvF2yOl5VP/Al?= =?us-ascii?Q?K+Why4QAuFmGP2p2ILnTu6Dcv2F1y0G1mddow7XMmjXAWEVzG0QsVQQ/3Xa7?= =?us-ascii?Q?N6I/PN77fM//amOi/yRcyAWdZRwC7OJbfCCXBSMP4/EUBOrD79zGGwji+sYQ?= =?us-ascii?Q?ZKXf+Lx4xuRtuBw6ujgKwGe2TgINj6MtnkuKaLfM90pAYkNloC7Yv0oiIWF7?= =?us-ascii?Q?PRN3iO064Gcnrf3N7YdNNv/Pz4c/koCIhXjgNlIPo7cQJ1hRPvn1i6YdQRDK?= =?us-ascii?Q?7jwI2P3LOZJY7txs88xmu63wvQu7t/2oRE5nQ+9inPfNcIzrOgbHHo86Xj2E?= =?us-ascii?Q?Nfa0+ZJImBVcTB0Y54zHkankSDtW5BUJEgEimkGyAZhjDFSQRIUMXRsz29TM?= =?us-ascii?Q?GoIbQNcw31BjG5LoXZq4Y7EIhNGRMuO7nkrNtBlhWLDCrlrVyrz8/twfGOne?= =?us-ascii?Q?4uz9Z3jvv1YmgptnomCMPjvY6JgZrRWsD6ZBrEWibBPnGzkV23KWibL9ri+d?= =?us-ascii?Q?AxfIrCLjJC6gNhOyrSSNJw0y0pXT8T/KG3wvfmZ2VRgH/R6ZQ2/0/YlXoF2G?= =?us-ascii?Q?FbXlgQrf2irKBnIIx61zAu3dLx1gf1Ow4Dyk/Eqp?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?N0TWk4I0b9uuyJ6hgUhiQJ4g4L9Feks37uPq1BAQF0e1/zbVDID33m2vichH?= =?us-ascii?Q?eZfq1GLaDIovAdkd2mAph9o0aXjKAe1FR2XJwb9FAR9KYsAPLgewpcqrtCaz?= =?us-ascii?Q?oZK6iRgU/EBykTDaR9uhBYtGaaKsAspteSPeInHF4ZjrqRgTGM44IHPmTW1I?= =?us-ascii?Q?ssH3XuqDEsrreOLgXQ7npdlXca/VqJ6QJzPXDeFmbEpGc69OzK5LUXHdjw3k?= =?us-ascii?Q?zCYA6YuSgKZfgwxaGYWofn3zgEEFjuKq1/IWa+2gm+W0yNOQJpBcrV4uKP5a?= =?us-ascii?Q?zo7nk5SukZPlRIMWJtE69cMW9TkUvsu2RwhxEyULQ5DAzniBNHHRVioCCdt+?= =?us-ascii?Q?BZcjjihDEa4x7ivj7AcIVARltEy4WlMOpXwM4oSchIFhiJbazfu3o8Gj1LIv?= =?us-ascii?Q?uNNCyWylZhv1D7iwF0YtSis3AQfx9gf06EoE9A/0kA2LOOQlALT0st5UZXqg?= =?us-ascii?Q?4iLZgBauvNfRGrmoUyGlvsznusDN9M+e242lksi23UZGRe0Rh0TPUlb1FpVE?= =?us-ascii?Q?ekB3QnQNj2HVRPi1JoEuXIP3qPdP6HlewtmqlhpUZ9CsJq+/TQkaUr14WrXC?= =?us-ascii?Q?06cwoJ8OjFrSiGI8HGHc6h3dQ+z1mWWKzW3Qxf1Clw/MZK0AK/2JXurKUexi?= =?us-ascii?Q?NHH7a9nbf2uvv/tGCOyLQ0Q5Onow5XRp8gX56QmwEXYwmgODGPmqvWNX2ddB?= =?us-ascii?Q?YyuuZOA/gUxJSrHOuUTsFVRrKi8viUcTXC4M1TP/l4DaG8w26TAr2fWTGWag?= =?us-ascii?Q?gES3bqzA9i6p8e9vovfsUBotq2vFGJQY+gsvKAMcXsBjlkKJROsCDWiDRcQe?= =?us-ascii?Q?zpWW2E6qWMVt8DaNeZIqZDcCxiK0RuDVpyX95gz0EZJ9Vf8Y9RO38eYtNiPV?= =?us-ascii?Q?z8OUjoVVSrLJFZxrkGyK9vT9DdkxvyHYg7FfYWHnMl/YtZ8hBMeDcj1Jithk?= =?us-ascii?Q?lPu7G5yPXgv+nRWMzg0HB5x7zH8buJapzX9AJcxOzVs=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1311676-3ead-46a5-f026-08db78cb0778 X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB4822.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 18:02:40.4319 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yqHIBEB4FlYUCOzQ+B0SjXKQv6exj0wo6PV0clqLtveBIJRbLG5xJPLHOOZVIl2vdf8d/wQBDWzS2BTFkYM8fw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4140 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-29_05,2023-06-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 adultscore=0 mlxlogscore=975 phishscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306290162 X-Proofpoint-ORIG-GUID: fe9zzh4m3YsuJMa5CPVbb2jkencJdtgk X-Proofpoint-GUID: fe9zzh4m3YsuJMa5CPVbb2jkencJdtgk Received-SPF: pass client-ip=205.220.177.32; envelope-from=daniel.kiper@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2023 18:03:04 -0000 Hi, Here are two fixes for Secure Boot issues reported recently. This version of patch set is more verbose in case of fallback to legacy Linux kernel loader as it was suggested by Ard. Please review and test. Daniel Daniel Kiper (2): efi: Drop __grub_efi_api attribute from shim_lock->verify() call efi: Fallback to legacy mode if shim is loaded on x86 archs grub-core/kern/efi/sb.c | 10 ++++++++++ grub-core/loader/efi/linux.c | 17 +++++++++++++++++ include/grub/efi/api.h | 2 +- include/grub/efi/sb.h | 5 ++++- 4 files changed, 32 insertions(+), 2 deletions(-)