Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E3B2EB64DD for ; Thu, 29 Jun 2023 19:01:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 76C7C10E1AF; Thu, 29 Jun 2023 19:01:56 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE1CF10E1AF for ; Thu, 29 Jun 2023 19:01:53 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AB14A61600; Thu, 29 Jun 2023 19:01:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE846C433CB; Thu, 29 Jun 2023 19:01:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688065311; bh=f4U2mnHC17deILTlIjHR/zjNCQG4W2AmYyWztzIAOXo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Mosd/zNnjqmCXMGlkNZNHc1e5vrcosXtvK6XMaqGHw/PjFHRuxQekVlarzCm3Vp0X Rcpu8n5pg+3ywCl3H8psT+L4ZJe8xTU1cWqe4+oiiXOsIivPIrU+TX8rOuHdEbBo50 Jkr8WF+J3C4oiJxo0tYQOL/RPPbsd0ziTswZmqn3+1+c42Pr/4UOZTi6VUH0AGFgAe lAzy7Q3NBXYLXa7reOZ7sEq97jACthSNi85dVC0/XzL0S4lHsU/nz4bsPFiM0ermWH vXWF8PTpmr+35QT16JXJnR5IHiyHHlbvsEmdMGBqnhIUKnhQODtlTRQDNyBMex7AGO yApDRSsf3Jo4Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 09/12] drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2 Date: Thu, 29 Jun 2023 15:01:29 -0400 Message-Id: <20230629190134.907949-9-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230629190134.907949-1-sashal@kernel.org> References: <20230629190134.907949-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.35 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Jani Nikula , Jeff Layton , dri-devel@lists.freedesktop.org, Wayne.Lin@amd.com, alexander.deucher@amd.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Jeff Layton [ Upstream commit 54d217406afe250d7a768783baaa79a035f21d38 ] I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg: amdgpu 0000:30:00.0: [drm] Failed to create MST payload for port 000000006d3a3885: -5 ...followed by an Oops due to a NULL pointer dereference. Switch to using mgr->dev instead of state->dev since "state" can be NULL in some cases. Link: https://bugzilla.redhat.com/show_bug.cgi?id=2184855 Suggested-by: Jani Nikula Signed-off-by: Jeff Layton Reviewed-by: Jani Nikula Reviewed-by: Lyude Paul Signed-off-by: Lyude Paul Link: https://patchwork.freedesktop.org/patch/msgid/20230419112447.18471-1-jlayton@kernel.org Signed-off-by: Sasha Levin --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c index 38dab76ae69ea..e2e21ce79510e 100644 --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c @@ -3404,7 +3404,7 @@ int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr, /* Skip failed payloads */ if (payload->vc_start_slot == -1) { - drm_dbg_kms(state->dev, "Part 1 of payload creation for %s failed, skipping part 2\n", + drm_dbg_kms(mgr->dev, "Part 1 of payload creation for %s failed, skipping part 2\n", payload->port->connector->name); return -EIO; } -- 2.39.2