Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD70F171A4 for ; Thu, 29 Jun 2023 19:02:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93043C43397; Thu, 29 Jun 2023 19:02:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688065349; bh=JZJm62kSdl7ABrTnShuW9exqvH2hUSIZGc/Sl6p/s7w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=es8ziq9d/UCB9hPi1APfWPMnMDDycIszGvXDVVq2fSw0p5HJ3O+fKHrgqeIecUZyv DL26K764ualv7ryDg016EQdlofQjtVyQdxlGZmsharyV7i2Cy9HKcF5cyQG2NCJQ2i y3DzYJG6P0nxKifh+IsQ5jvrGQtjERjivsCbVGAmOlHyN2v/H9YT6v65vKSGy0tFoo DsKT5opLCxxAjCFF8mlrgTrfFXhw5m1Vr8C4oU9nnE5drJB0obI0X+WtJR0CxwJVOS 5sE8wjILHrtVIPLVHBInF4OY2OJnWL1ueBs0uam1S78RKHRgb05tKHAqbXo/4vbXna MSrEWjNInmYMg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Rasmus Villemoes , Jacob Keller , "David S . Miller" , Sasha Levin , edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 4/4] net: loopback: use NET_NAME_PREDICTABLE for name_assign_type Date: Thu, 29 Jun 2023 15:02:24 -0400 Message-Id: <20230629190225.908451-4-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230629190225.908451-1-sashal@kernel.org> References: <20230629190225.908451-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.14.319 Content-Transfer-Encoding: 8bit From: Rasmus Villemoes [ Upstream commit 31d929de5a112ee1b977a89c57de74710894bbbf ] When the name_assign_type attribute was introduced (commit 685343fc3ba6, "net: add name_assign_type netdev attribute"), the loopback device was explicitly mentioned as one which would make use of NET_NAME_PREDICTABLE: The name_assign_type attribute gives hints where the interface name of a given net-device comes from. These values are currently defined: ... NET_NAME_PREDICTABLE: The ifname has been assigned by the kernel in a predictable way that is guaranteed to avoid reuse and always be the same for a given device. Examples include statically created devices like the loopback device [...] Switch to that so that reading /sys/class/net/lo/name_assign_type produces something sensible instead of returning -EINVAL. Signed-off-by: Rasmus Villemoes Reviewed-by: Jacob Keller Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/loopback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c index 30612497643c0..daef41ce23492 100644 --- a/drivers/net/loopback.c +++ b/drivers/net/loopback.c @@ -206,7 +206,7 @@ static __net_init int loopback_net_init(struct net *net) int err; err = -ENOMEM; - dev = alloc_netdev(0, "lo", NET_NAME_UNKNOWN, loopback_setup); + dev = alloc_netdev(0, "lo", NET_NAME_PREDICTABLE, loopback_setup); if (!dev) goto out; -- 2.39.2