Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1qFEi0-0001zy-GB for mharc-grub-devel@gnu.org; Fri, 30 Jun 2023 10:02:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFEhv-0001y1-Pg for grub-devel@gnu.org; Fri, 30 Jun 2023 10:02:45 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFEhp-0004TA-0o for grub-devel@gnu.org; Fri, 30 Jun 2023 10:02:39 -0400 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35UBOblW015260; Fri, 30 Jun 2023 14:02:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-type : mime-version; s=corp-2023-03-30; bh=vsh2EycvCLJWFZ1d1jWFuCu6BFq/EYix/zSs1l37c88=; b=Mgf7kjuxqfANHIFSr8vIta5dzFgBjKFUG5LR2yFua+XX+DFSh1nvn6P0MQNN5e4aqa+z fiZsQsGuhCSm5upoq0FQBVwSvPHrspIPEVcGpQlIidXTc4viv2fE+E6jBNuB9STCDApU mdw1in5WkvTggirAKrNjVpdIcGy7SiMOtvsZ5xsDgOAxj72q6sK/a8dwZigaR5JPkEZN /vML+Z700RzIFUj2SuJIwEfbBDSb5KrzsogHIHssYQJ4Y633EuZriVlazXQXWBhb5sIm /Pa2Rlv3JcKy5aa1lXPesr2qX+/j4DphJQ4MTZSU9gl65nGuVIIA7SeCnFlMgThsakdT dA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3rdrcagjhw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Jun 2023 14:02:28 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35UD9UFq020005; Fri, 30 Jun 2023 14:02:27 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2169.outbound.protection.outlook.com [104.47.59.169]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3rdpxenxj1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Jun 2023 14:02:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H/2ALxWHOEnRAErR5llrhTWfTTHu22qwksIvx65JSylUUDBGN4l3h0ZHloZc9011tWBJtyS02/Y9FvCNOCv61cVbgHxlEDjXCUVdtv8xvifu089X9oraWLWukniG08L3syDvllUfIir6c/Y5lCe/Gze5Ie4YYj6kBKf1RtO790BHGYXr52R4gg79HEC7jh53aHFcZjtMbOh9kfO3uWTLCXZV3/WAXymwyjibiEJEgTbcF83PLP5TmfOVFslQjvDbzprMKjkn5ZdLfvwD83VGCzBYV2QM5Rvvd2YVRpzmEZP1Aqa+drlO/5DJA7gX2AbHo6yMm0F8MpldUru1XKOl9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vsh2EycvCLJWFZ1d1jWFuCu6BFq/EYix/zSs1l37c88=; b=mbbM27Vo+ESlMLUJamMC85d4yd7cgCZshsNKcQQVnHiCPaV26vHnEPguQPxyvqHB0GOGGTsTFH3BpGpxsXEHtu/Kylj7w+ca9oYHW8fyHXl/Ru2VCgwHTEMzXbyBHn0ReHbz2byLABfscjROGFQPzO16KBl5+R6oxikFskZJKF8YA3VuqZ7Sy0YnhMSfub41Gvjhf+97CeEwce2aFfqH/xLInJQsKEshgKZ2Ts1H5EYR31820vC0MliwnbpkvH4FPPcOK/D23uLj5zlWjKFqj8dTnmKH09dtPsasu7eJHXfAcF223w6atYVwXjSnCHH0Cg1Z2T+GkGiB7i0JWzgl2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vsh2EycvCLJWFZ1d1jWFuCu6BFq/EYix/zSs1l37c88=; b=pWsRBVgHLB0EmWRJK9EM2MHelLRxL53qtOURvdk223prldxSW+Z4uqr4agcJY8fB8jj/wX+tpY3QA1dYq3dzHpG5yJpeI4coSulC5AEZyKBdOu2D/PwuRVqW5TQcToJIAMa/nsXQaDt2WYWrcYMcf56MJ/5lu7nJts1Vb+WXrL0= Received: from BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) by DS7PR10MB4896.namprd10.prod.outlook.com (2603:10b6:5:3a0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19; Fri, 30 Jun 2023 14:02:24 +0000 Received: from BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::9e9:42ec:2d46:492d]) by BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::9e9:42ec:2d46:492d%6]) with mapi id 15.20.6544.019; Fri, 30 Jun 2023 14:02:24 +0000 From: Daniel Kiper To: grub-devel@gnu.org Cc: ardb@kernel.org, development@efficientek.com, dimitri.ledkov@canonical.com, julian.klode@canonical.com, mjg59@srcf.ucam.org, pjones@redhat.com, rshailu.yash@gmail.com, tobias.powalowski@googlemail.com, thomas.frauendorfer@gmail.com Subject: [PATCH v3 0/2] efi: Secure Boot fixes Date: Fri, 30 Jun 2023 16:02:13 +0200 Message-Id: <20230630140215.13465-1-daniel.kiper@oracle.com> X-Mailer: git-send-email 2.11.0 Content-Type: text/plain X-ClientProxiedBy: BE1P281CA0343.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:7d::12) To BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN0PR10MB4822:EE_|DS7PR10MB4896:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ca577ed-3f1c-4731-3cd1-08db7972a16a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /T8EjDixLwPN06xfSxOobZInulWeVzLDY9H9uU2ufoCMI/wGBAFEPmOY04xbnKhovNt0ZfV3u4r3SXclht7WqgR50LeMzCYYQlRaz2WSpiiB960S+zduKYSX4bYqV+/+lzf2kjaVrxzImCIGlt6diXYvJXSZe4T0EszkQ7Hq1RxRwn9sXccw9+c2x4Wxit6ZZxVoask1IFMQsMPCghTwAYrO5QsmqrgHYUK5+6oLeluga7caX28L2X8QRoP+PCdP0/Ou3yA8I4BSVMxDJsGBGp+kfNtF/SIcRnbpppK5Mq97DJqfQTmxuyIxz+jfXvvRh+iGWPu76xSTCYfg2w+IteyX/FsBZTJA39AFIUBfF0JawHLf2yY8oOP0cJXZW1ZgQJ3FaPLCDqcF7rVar/aLvo9YQZQq0JDozfeU6OLATcIGNcmSpplr8FFCaEgEU62XveYQIevcV3pDc2EVXIU40RHZs8BEInWKr+ofjN+4l6OOBtG/JAnXC2+Jjc0j70lWQ7oDdpJB03YPSYbN60E+tHROPlhNJMCq2Jlgj7tw9dYXHGN87O5NHr9CALlsPT41 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR10MB4822.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(376002)(396003)(346002)(366004)(136003)(451199021)(8936002)(8676002)(7416002)(5660300002)(44832011)(66946007)(66556008)(66476007)(6916009)(4326008)(2906002)(4744005)(316002)(41300700001)(478600001)(6666004)(6486002)(6506007)(1076003)(2616005)(83380400001)(36756003)(6512007)(186003)(26005)(38100700002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kIpD1x8F6W60BxiXkWih0T8GacfjnK0QgU7vTZ+9ve8VvY8BSSbh+cyIp0aS?= =?us-ascii?Q?vL5bxnMGfSRSv2rpaoY/sB/XeR8+p/Iuiy4pG0b9LRiCbw0EOlx3E+8FMgQX?= =?us-ascii?Q?XRT6L44YVl96GVCZ7Ci6FjihDmF4Y+uyfV18feJl//N+uF+Qe86/D1kxrTcw?= =?us-ascii?Q?u46uCEfw9cWbFM1xk8xl8uior+GEWfP+ZRhbOPjdLe04Xsb/zjCJYG7opY3g?= =?us-ascii?Q?EJ1n4bGW44vTvCesfzm1dhbNh8+mS2oAmqpRGq1U7BoPHQtjbKfFFL8dCQV3?= =?us-ascii?Q?j03h1nmnKjJLIhxpuwsmVdUzewTZ9/SIfrTkLcqggOFMoIkuLvQnRjUq8Ag0?= =?us-ascii?Q?IRmgOaZfhRozgVS7aehnZW9PmELlTywzNNFuNT1prXPI0rIAkXuLcr5Efm+J?= =?us-ascii?Q?qTYPLQ+Pv0SRp1m+/fixpXxIFsa69nbbvB5qJfJbEzPVOeQHhAMrqRZZo6P1?= =?us-ascii?Q?hBO15c237WO734tB0pvgu4QVFtn68q8owntolHDXts+/4mDbOGPaj3RpYF0Y?= =?us-ascii?Q?e+1q/1VJQiMc8vtm56IXsSLJlQlSJ0X+3fmUathxPAQHd4ASEZffWyAhR4iH?= =?us-ascii?Q?E/ZhXX1kSOQfTa/g0XvNl18SwMX7aytnCD7LbBFnfoy9Njn+7bKEuQwjquDa?= =?us-ascii?Q?G+Xrc5LK8rmGsdLc1sg5jdCNQ6eXyZbjmI1zuQTrfLo2WlWRkrD+d9qOM+P3?= =?us-ascii?Q?XPo24dnW4gsLkpg6u84fhDAnD0KZR4qw70XoX5XdG4IHkSIV9vUs9xmMn85o?= =?us-ascii?Q?XpYCX+8QNdKprKBMk0TtauHPOyMJ6+UYjCQExRyYwLl2wuVA51LLV3DwVTbZ?= =?us-ascii?Q?os5yhSpWnJvj30x5XoDmSFDTuKTE1Vbjk7tHdlYCQpwhs2DrSVAohWUCve2c?= =?us-ascii?Q?deos5o28GUeBJ75OgUOCNrPPSo4DZpAZ0LUzXAsckkFpoaHn2O/a6Vaduy8e?= =?us-ascii?Q?KzBKRCEYKudRn25I3nWf+1fekyTED+IIrndXkAGh+bnVXw2Nxvb8F2U5rrJV?= =?us-ascii?Q?Xi2zVjkrv6OFw4C8UU9JD/4XNq3EfCm+9gEFmAYkYzHR13d3/kkfrdVHfhZD?= =?us-ascii?Q?79sdNmsnE0hPMDutMQCzGcHpce1iWSmfBaKX2OkK/+iWXvA+1zHmAHyZTopa?= =?us-ascii?Q?WoH0AOHtCoJZGnhUoS8w8pkgn+Ro6uvb7ypCt2YuDofwJw4yOd3O4rrAaoEL?= =?us-ascii?Q?t4XbTk6b59+EZavaTuU7dHAAW3v7EgZBEOD62hFnsPnfh/H87YmmJm89KnLL?= =?us-ascii?Q?5Ayu1XBxq6qFWn8R7MJPX0NUNS//fjmP57881vt4WZV1AWA4aSvb0sLccGAO?= =?us-ascii?Q?rjGWU0GGqiqIEmOgnxnT7HkEiDLLgcnZMb8LnCJYHQScGcDmT2OPlHtZJWxy?= =?us-ascii?Q?jGJ7wyiTyzi9IiKXQsDjD305ZmOTqWhQxRpHOVTBaAAK2HM77/vE/hizP4Nf?= =?us-ascii?Q?DMIupb496ykWWOis//YbCxD0fl17AK17IXsAaZiKgjXPG2/gVkdZi4CazTQx?= =?us-ascii?Q?+EFCuuVLmTzvt5198qda9nRBq99wAWtqM6QGAboi7JRE4aagpVYWywhCY11n?= =?us-ascii?Q?9UGCqVsWO+5T3QTwEvKupb4xP3wYf3AWfUkJEX7O?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?+P2U4ul+I/Ae2A8lDtXZqtKvo6cdiHj+6sJ4TT2rsEVpIxieLzHAhd6SegOD?= =?us-ascii?Q?gXDB/I+zYJprjDxZt9u5TtfqmblJ6E+9OkMAgRN4mJqYEJtfV1PhSAW5+ui4?= =?us-ascii?Q?ASJK0CoQhAt1IkXO27+qi3OCayfs0rHO0JRr1PWZc/UVwSfH94GwVS/VHKgH?= =?us-ascii?Q?8Okf+3bqsr7jRMhMMIIiR/WC2jsMwMtYnaEgghrt1KkzUBbzQtpNw39yh1Pg?= =?us-ascii?Q?X8SInCmNg/AILD24GEC6y0KvK0uoh0JI8FZqBgzKIUIh6Rq0MVEwm4HltnPq?= =?us-ascii?Q?pZKaV1GoupEi/5NygBBsR4ZJzAE2MLy9BL6tOInWXB4f0kI0bO2NsNv02Z3r?= =?us-ascii?Q?EheNn6jZdukFYNlc7y1zGSQSDCWfkYy0a8jfGvWUHYfyLtH862n1lg9NwRa3?= =?us-ascii?Q?4LWPRoL1IKfKAKbV3lLFhri459iKwttBnhqyz4r5V1vJcysiOOJHznddtX7Z?= =?us-ascii?Q?p9en91OO0ncidoxxbF0xXUo/Ek6OvyFeWIicysJhE4DsUYIEjKfYIWLjq+BN?= =?us-ascii?Q?OpAMXQ+XnyWfzhtc+qkl2MZjnIi7wYZQxKWLlJzNlxJfvdb4ff8EqiLhSDea?= =?us-ascii?Q?K2+iF0InTNli4Y6TgTqYuxTWuSnEP/U9miTF/HV9qD5TZS4aSURjHVaB033J?= =?us-ascii?Q?k2hKLVIZZ6Fe+6GtiTDONpJFTbx8+g/KryoDuuG9+JQJgUqcANYeMD79laXQ?= =?us-ascii?Q?zkT3lTfYpUEUggB5eBC2NqFYgv8diMJh9t3wEXRs1tphwxs0kvaginSV1FsL?= =?us-ascii?Q?tVnE2uWEfiUIURo8dF6NSZgjiiAgwwUxNLyqSF3yBFNPraM0t2GQKDE/nEiu?= =?us-ascii?Q?+W60J/QD07Xbf96i61ZlX3ud8cWvU+QK6wNE+yZ/IlzsCErrVffzj4+HocYG?= =?us-ascii?Q?fbWU2aZWcUHjPMLxtUfjFu1DxWAMr/RgpZRc9BlHYnmRZdFd6SZHVx/YHFMh?= =?us-ascii?Q?nugrg407jAM2D5KAo0DeL800A4hDZHoHihw+8mM8qak=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ca577ed-3f1c-4731-3cd1-08db7972a16a X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB4822.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 14:02:24.6363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3A6rc6IX4IoQbbw+4aZRP6fRHvIsJhoZC/UYls5v8Kyu1SF90uWnpRbmSc9g23dlbattHjHk/9kjZRTjI0h3XQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4896 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-30_05,2023-06-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=941 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306300120 X-Proofpoint-ORIG-GUID: as_1K3y-yVKbvbkhJRFLENd15nZdhF0L X-Proofpoint-GUID: as_1K3y-yVKbvbkhJRFLENd15nZdhF0L Received-SPF: pass client-ip=205.220.165.32; envelope-from=daniel.kiper@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2023 14:02:46 -0000 Hi, Here are two fixes for Secure Boot issues reported recently. This version of patch set adds comment to shim_lock->verify() function prototype and updates patch #1 commit message as it was suggested by Glenn. Please review and test. Daniel Daniel Kiper (2): efi: Drop __grub_efi_api attribute from shim_lock->verify() function efi: Fallback to legacy mode if shim is loaded on x86 archs grub-core/kern/efi/sb.c | 10 ++++++++++ grub-core/loader/efi/linux.c | 17 +++++++++++++++++ include/grub/efi/api.h | 6 +++++- include/grub/efi/sb.h | 5 ++++- 4 files changed, 36 insertions(+), 2 deletions(-)