Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1qFEhz-0001zh-QQ for mharc-grub-devel@gnu.org; Fri, 30 Jun 2023 10:02:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFEhx-0001yC-1j for grub-devel@gnu.org; Fri, 30 Jun 2023 10:02:45 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFEhu-0004TV-SI for grub-devel@gnu.org; Fri, 30 Jun 2023 10:02:44 -0400 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35UBObSS027612; Fri, 30 Jun 2023 14:02:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=corp-2023-03-30; bh=65FmYUczO8vZssYel2jgBdntU5Cu8TRQaTDVp+3kzTc=; b=kQH027VuWS+RZkCIxN2F74pkFXH8Y5lvbxecvsbNBe8abbft5hexRwq1zJw2sFqO7bvb 7r9U334SnbXd/ZfIiePp07q/gf48V9Hy4dVtlltGuOP2gd5vjD9IvObGcam2wNZLLesC ihymjexWxfz6H3SRlUzDSO/pI7Wyfv1XU1MoL1f1M9wagifhDm7wiQMM8JwKj8CJkiU/ Ld/3jd++2qdhJUiLvdLhTEZEbQgSYbyoTDW1Rrb1S4v6+9fygjxIoN4ge2MJU1J4T64S 22q0QOzktDe69bCg+nHlntmv15FTgrE+A759I6uyzfubtAbwTCKupqg2qyc2LMAqkeWY +Q== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3rdq3195nc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Jun 2023 14:02:32 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35UDKBqZ008601; Fri, 30 Jun 2023 14:02:32 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3rdpx8vfxh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Jun 2023 14:02:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nz8CdmEOAqLXdgwprlbu4Ohp0blvpiHmOX2VkakfMcjaVqnN/aFDv3e5/jrJ5ouOTrfUTOJlWFME63TpUzB55yp3ClAKnLzqOcMR/VVP9LInMVe/XFxttVNz3avCxV9Xkm3SPg2DTZ7ZGODT0RvbLkm1abtF9bLpu1fwOnaBTV5LNH1VvCn98mhSj7ENTKTQjOG4zTQigx0P7+g0dVYBGeE+n3OzhvPZw6hslvBsxGGLS/TDo6SujxaIZj2DOpkw+EytmqthnqfJVf3RSetYdR/LLRgBz+DXenjSKTXd/VyH+OXjKv/0O1KOGtDYTRQ3kJn2iQWjp+u3M2h+cJfOnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=65FmYUczO8vZssYel2jgBdntU5Cu8TRQaTDVp+3kzTc=; b=QDzb17YZ9KWzDTayeWZbiH0BcKXrZ5Ne8uUdL38WpHJtSXGDkAme/1+ABxS2jxTA3zS7HkQF+XjdRah/9AfFGL+Ku9s1cEmLZbfU24edXtJJYqEj6SlHjUjzJQVoBdgwa/DJ5otcHTC+yM2kUh8W2apDcOXA8QzbCs08J+3alHrhR7TpfDka78DqszdmOFI4HzeehJ1K4jhk+P4j8CoSSkrWbgJSxh6ARE1MmXnd64tyXFRwQ1ZBXfsyzCRQLEoMJ/NX6iTDlIgIp/joag088bvihd+0Qtsx42eZfRO0P/saE/VNzGuDP+e1UEwtg8deVBy9T+kfVsaH2pExedIRuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=65FmYUczO8vZssYel2jgBdntU5Cu8TRQaTDVp+3kzTc=; b=sPPjcg8Jm4h6qX49RZ6MxgetWt0v3P+5rbIYYVlJ0GLLiq2emv6OUQ/DFTYwFj0+tVJqWIKAExZvTfa+wqmDz3YstERyBknjRpgVZwSiULmbzSRlnud52RhmeePJjBWOkDBWoGnF8bJpDluCpUypQjwxXy3dUqBJ4W9O2zGWl0M= Received: from BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) by DS7PR10MB4896.namprd10.prod.outlook.com (2603:10b6:5:3a0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19; Fri, 30 Jun 2023 14:02:29 +0000 Received: from BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::9e9:42ec:2d46:492d]) by BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::9e9:42ec:2d46:492d%6]) with mapi id 15.20.6544.019; Fri, 30 Jun 2023 14:02:29 +0000 From: Daniel Kiper To: grub-devel@gnu.org Cc: ardb@kernel.org, development@efficientek.com, dimitri.ledkov@canonical.com, julian.klode@canonical.com, mjg59@srcf.ucam.org, pjones@redhat.com, rshailu.yash@gmail.com, tobias.powalowski@googlemail.com, thomas.frauendorfer@gmail.com Subject: [PATCH v3 1/2] efi: Drop __grub_efi_api attribute from shim_lock->verify() function Date: Fri, 30 Jun 2023 16:02:14 +0200 Message-Id: <20230630140215.13465-2-daniel.kiper@oracle.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230630140215.13465-1-daniel.kiper@oracle.com> References: <20230630140215.13465-1-daniel.kiper@oracle.com> Content-Type: text/plain X-ClientProxiedBy: BE1P281CA0092.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:79::6) To BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN0PR10MB4822:EE_|DS7PR10MB4896:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ce2cc8a-d5ad-4429-1fb9-08db7972a43a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8txO5XmCrVosF9y6FYAPawxMhNAVnZRQJX28e7bX+Dc9bmsBgD2ZJ1yJDZV7xI2GAkTEAr5+DkkodZSryIKKPuW8Yhcn607lGNzGhxryBtoCWc9zi2fF8fY4j9pjeLZSS1picR9toRRHm2L2CF3sDKOoVqXHYPxQLxDYlf2dY1oQ9ZtZPzePRVZtX+/G3l19HJ8w7uJh8WZYEWNIoF9IGdOSXEbVRI3F39j6uZAb7fjo5uLKZIBBBCG2f2Y3rMliBAE5O7gT//gZt8oLoRVM1o4tML7IwGD8ketMnKy2g70hgwLXwNP3TTqwZt11p1eXYJoGlAe5Z7YWkEw3ocOkgEsEJRg08xZV1DDv+JJ+mxeKsMaN5TslSdA62twh2hY2ZGARSFzWP3Bpt2T+UNqswhNSfJXDqazZohjBonjP9MG5os0acE8vqWpY9yJGUcHTTZqTN6VqkCXd0FEE48pJfp1cV1x0d2+DWShgqw0aDAGQEvc48BAUk1ijf0WncgOvv86gqL5ft6qUCUR7d8nLOh66Zox0gf/UKMEr31dv2NO6ttm6KrboR6yaVbyqm5tl X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR10MB4822.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(376002)(396003)(346002)(366004)(136003)(451199021)(15650500001)(8936002)(8676002)(7416002)(5660300002)(44832011)(66946007)(66556008)(66476007)(6916009)(4326008)(2906002)(4744005)(316002)(41300700001)(478600001)(6666004)(6486002)(6506007)(1076003)(2616005)(83380400001)(36756003)(6512007)(186003)(26005)(38100700002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TCxPfv8CfYGjpFZNDBxUgWJGtBOCOw5K91NFf53cOJw9QZj7DvaDpsVwerTf?= =?us-ascii?Q?i3OGkO0ZpyqzpHLIxjAnBpQOtHjZCPa1+xkfXP3al+DP30EfZriLytL7B1qU?= =?us-ascii?Q?Sp/9pBYF5RqyV8F3AdCKXQjkiJtqbxR5LpYF/jmJ85saPtxCx60UBjtlXRii?= =?us-ascii?Q?lqq5I+C4eHHi2cBZQgqHap3uLgB9cI4GHg0GouGj5CWNVp4pzyUWIyHJZO8o?= =?us-ascii?Q?0FbIg5c3R32W4caDSW4+C56FL7x85NB/eNHDptRGVVU0KbRM8jpAvaXJNMJj?= =?us-ascii?Q?4HbqtsJaDh/be0SXkb8h7/4MoEBB3ylsINLDRAiOv7N5PWgdjDHC+c/TzOjq?= =?us-ascii?Q?SpDf0gWb8SrNJzFcWgGKpgU+RjK1SZlWQ8jCaw4QH1Xp4xwmcqH510UCz1rF?= =?us-ascii?Q?xbHvzgy469dYiDJBK+6l3HSWMjsBXwPv8rbnw/GZWGRFXHTivDBnUxkXFHTo?= =?us-ascii?Q?eq1SsXSWd5ZsDBGwyEZwRnYiAsj/kgL0rZuGgypXt+qLveXJqQsNik3SIfUh?= =?us-ascii?Q?hMBmAED11kIu5ZskZssJN81zORFZdUASsi0KpZr896vjcaDUdkYMsoT3kN3a?= =?us-ascii?Q?NvCO9tR2W0XCF2xmiDDCxYhXHS8KD1+VC7YSzCCGd446Nas1kPkOrynmty46?= =?us-ascii?Q?UYRV+d1Cos4mYziPYQI+I4tjkpl2+ZZqxzjLEXDwzoataSWaarEKEoqgbXTq?= =?us-ascii?Q?mlhC4kvEwliXaKaMe69DPHTxDJcRmYUcWNNZJcmUSAHuqMx/wT2SE7+VOl0w?= =?us-ascii?Q?ptvnK3syoramSDtN3nbnpDPHD8mGktaB8jfVTDIkuR2c0x9NsS1pSj3vQzRp?= =?us-ascii?Q?pFx5G0Xa8AMphh3O55izZT4yFQKp0zxSFh70dp+wK1C8RoO9JD8FAsSK5W/X?= =?us-ascii?Q?wq83AACZv/TYGU1EzNieAHdF5jRY+g/uMMKGZj+8P+snmMFCTLoSqEkrXQSV?= =?us-ascii?Q?Cx2hL0TDY1013Og/ev7nyKuHoeFJGSwlIf2t1KVRFDanFsaV5scD+BQ+JNpr?= =?us-ascii?Q?5waWi+7SVtDCuXi5H7JE6kSlm7wJoVM2WUmEQaGjyBwLDSQR7QQZl7q3Y8c1?= =?us-ascii?Q?WYrf8RJaVKwmpEKbJFEUogA/S85k1g8+xsb7p0ZriNbAu0H6FMdxKrRZ/Drz?= =?us-ascii?Q?s/RTzya6J28CQCwsP0zbwZiYA77nBLSSulqdG1j0TFfZHrYM2J3qf5RBI7gH?= =?us-ascii?Q?5kWiDpl6JV4u7bHND+/38DOZJpXK8x9FECZGePpgrEPwZ+TXR18Z7Inng6TL?= =?us-ascii?Q?ksK7+J0ojD6e71IYgDCucTPGFb95AqwN3vjo3NTUESPOCkAj6HUX3iBIPNtT?= =?us-ascii?Q?evvK0/P3VNg3mSkbmfB/ejkgqMDRsm2EF/GgqnEeO3V75KuBwGdeJ7bSeA8P?= =?us-ascii?Q?7ofZtEz7J3mEnGYtZraDxOSOZG6MsPOJJLirN+9C390O6GxmkRB3r3HpEnQ2?= =?us-ascii?Q?YsbQoEa0Jgb3NpyaNR7y0jyOfpnmD4WFevi9L8a56EG8bUDzcTv0JXJi1mAT?= =?us-ascii?Q?Q6vZSfcI+L0KXzTbG+0WdUhN9B65U0pk9oaysAkYW5FTgrjk6bXq2VFBYjtj?= =?us-ascii?Q?TNyZHMIQNhrnkAWF/DSRlmYCdH3yRRU628qvBvNx?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?dD1nH8dadSCz0iQVjp/TWRgjJfLPGz55CmqebBMXJG26muUneU/UXIOYWOyd?= =?us-ascii?Q?JRgt0tl0Owy4tmCOhuw9Rs+wXYNK8ULI/C/U4PjusSLv9+7qe0ePP2VPDGpZ?= =?us-ascii?Q?PkifkgK9VxRPkpL6faLh5DhASnNQ11w+XfW8mT9JDVgu3973SrujI5Ye99eC?= =?us-ascii?Q?/9e0RzzmF2dKsr00IWYrAb8qLTTKiAiyRr6Qi1l61YMHYdyfK927YBSo9VFK?= =?us-ascii?Q?Un9j/8KGHAvxjMlgmHFf9qJc5yqLuM5ABuxFQF9EUA1zTFxqwfUG86r0HT5X?= =?us-ascii?Q?kst0KgyXltTe5Km51X0EHCS3dvEkYc2jwDIWOLTV8hmxcB++d6hiopNgvzHu?= =?us-ascii?Q?UR4XhV9Ahk+2D/Y0UZZPHvposAuYMlJZ5VR9c/QNCgPOhjZVy30ajSkf/kn5?= =?us-ascii?Q?yK16QItEVpzsbzfSwTe/7tFlk+J/yzaCSkE5hcYV4svlK5QmU5RUk/d4VjXc?= =?us-ascii?Q?kPkcrlyckS5vt24xI+rmeeuJD0nAJKxCjCgzxYEI0eRZcfiieVC74SjEzrGd?= =?us-ascii?Q?aBXBp2zdOKr0B5Fb3/ZzeFfwFoidoRfiFaquXAL5AjZIDWjnLojZuQYbGGZk?= =?us-ascii?Q?CXF0TDMQwgpHpcOWayEx58W/jB8QRiaRGV5GGthd38PJdFULFwZs5cohkVZh?= =?us-ascii?Q?vxlMCkTV/Niy1aIGdYYk5bGesJvzsr5wbmxmVHENgHIUI1YwZ6RQIRXBMvem?= =?us-ascii?Q?exW2LYnGNOp/ABqjOC2Q+8tIUh7v+/q2OHzVlmE+T9sjwP8I5/4RUJBU3nWP?= =?us-ascii?Q?rwlAWIXzp2YrIAon5SuCmG8QvjEmc617C6VueCmquqc1BX6oDN9YRGKnBqSG?= =?us-ascii?Q?ccA9arEOEnnD0NiM9nwsSjz4S/Mrh2oZycQ4MwbaI2IgEtdzskXfDS3CrZdY?= =?us-ascii?Q?8flJqnvJ5EDQ74NGcn396FEQwOHbjK9OrWOQhKrE2LEqeXWRj4i2nPqex8EQ?= =?us-ascii?Q?7Y57ZO9bH3CzVacyEXzcMRkfpeK5rHIk8zF5PDj6Fec=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ce2cc8a-d5ad-4429-1fb9-08db7972a43a X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB4822.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 14:02:29.2222 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WTSnN/He6tmshLIJsOGX+e/nL4zxSTG38jgSKloSefbI8Tl6gvkYxdyXE7bW1uvCGvaWkg6C5vQIVFcXMF4D1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4896 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-30_05,2023-06-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306300120 X-Proofpoint-ORIG-GUID: ENO0ucynRuAhjJzVTSXQrjv8r_FML_gt X-Proofpoint-GUID: ENO0ucynRuAhjJzVTSXQrjv8r_FML_gt Received-SPF: pass client-ip=205.220.165.32; envelope-from=daniel.kiper@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2023 14:02:46 -0000 ... because (surprisingly) it does not use specific EFI calling convention... Fixes: 6a080b9cd (efi: Add calling convention annotation to all prototypes) Signed-off-by: Daniel Kiper --- include/grub/efi/api.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/grub/efi/api.h b/include/grub/efi/api.h index 16161e1f0..d3eaef3fb 100644 --- a/include/grub/efi/api.h +++ b/include/grub/efi/api.h @@ -1777,7 +1777,11 @@ typedef struct grub_efi_block_io grub_efi_block_io_t; struct grub_efi_shim_lock_protocol { - grub_efi_status_t (__grub_efi_api *verify) (void *buffer, grub_uint32_t size); + /* + * verify() function (surprisingly) does not use specific EFI calling convention. + * So, it does not need to be tagged with __grub_efi_api attribute. + */ + grub_efi_status_t (*verify) (void *buffer, grub_uint32_t size); }; typedef struct grub_efi_shim_lock_protocol grub_efi_shim_lock_protocol_t; -- 2.11.0