Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83EA1EB64D7 for ; Fri, 30 Jun 2023 15:25:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 50F2F86823; Fri, 30 Jun 2023 17:25:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="unYNGrCX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 75E5F86820; Fri, 30 Jun 2023 17:25:11 +0200 (CEST) Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8568B86825 for ; Fri, 30 Jun 2023 17:25:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-5700401acbeso21414697b3.0 for ; Fri, 30 Jun 2023 08:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1688138702; x=1690730702; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mQStditKIjAEvT1QSRyTT7SZCSgTNLtI9wx9mZuAl6k=; b=unYNGrCXVPBsiyuE3M0Y/bly4y4YHjqPNXnrZfx4NqNDRMFGKzryd+d8HijofL2BE0 AYUh/tg+FtnZHYaG5kY//2K4tWVwLpzRO8EEuJQAi6OcwmX9qY54JLEkdSbfT/Svj4DO SJRwSQJdAauDiB3qG6GUjAuqjJsaFzhMFNeMM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688138702; x=1690730702; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mQStditKIjAEvT1QSRyTT7SZCSgTNLtI9wx9mZuAl6k=; b=K+8lopBgFeLhzkuF0QOWTvbysxud+fq4lDPjK9yCUHr98cmzEgfrErBpjRJEAknRkC bwlvNgJZK1ZBwnBBbFKCiMyS8Y/1+xtQuQxxMtj9l9++TiyfQ5V0KNvpIaUvHOGHzCR2 svxI8Nk5mj7YH2JUTmKTqQEU3FgZiMmSArAMaU9VavLlz/uHtYd/MQmwwsgMBBC5hcIx Hk9kPk7W4KWRNISu1iDIcFk+271cYBmTqAaJcJ42yKsQQ5ECVqUjL5yWalkbAzfMMQZH SQko8ZtnDjnl7WYAlFLlbHtuW2/Iltt3vr1z715Vl7JSGjoQ4udafQBbXLjpvKbA1tum KSZA== X-Gm-Message-State: ABy/qLYrQG4r+Pxb3j45eyoNP2eGHLPOSNyx9cgnpahuB/GvXSjarh/F oNwoj3d7lcB/jidBo7tf8WFmZw== X-Google-Smtp-Source: APBJJlH3zvB7CVXkS6PNXKmArSyJop7FSnslPI/YzCCBX7+H26g+a6HqinBvi8EIrV+ydKKSOG/rPA== X-Received: by 2002:a0d:d595:0:b0:56d:2189:d87a with SMTP id x143-20020a0dd595000000b0056d2189d87amr2872906ywd.15.1688138701869; Fri, 30 Jun 2023 08:25:01 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-8f3c-e954-a9b1-f559.res6.spectrum.com. [2603:6081:7b00:6400:8f3c:e954:a9b1:f559]) by smtp.gmail.com with ESMTPSA id i13-20020a81910d000000b0057734885f49sm707596ywg.74.2023.06.30.08.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 08:25:01 -0700 (PDT) Date: Fri, 30 Jun 2023 11:24:59 -0400 From: Tom Rini To: Fabio Estevam Cc: marex@denx.de, u-boot@lists.denx.de, francesco.dolcini@toradex.com, Fabio Estevam Subject: Re: [PATCH] spl: spl_legacy: Fix spl_end address Message-ID: <20230630152459.GL3931582@bill-the-cat> References: <20230630142311.435336-1-festevam@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9LRIuB/0ksvq/MZQ" Content-Disposition: inline In-Reply-To: <20230630142311.435336-1-festevam@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --9LRIuB/0ksvq/MZQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 30, 2023 at 11:23:11AM -0300, Fabio Estevam wrote: > From: Fabio Estevam >=20 > Currently, spl_end points to the __bss_end address, which > is an external RAM address instead of the end of the SPL text > section in the internal RAM. >=20 > This causes boot failures on imx6-colibri, for example: >=20 > ``` > Trying to boot from MMC1 > SPL: Image overlaps SPL > resetting ... > ``` > Fix this problem by assigning spl_end to the _image_binary_end, as this > symbol properly represents the end of the SPL text section. >=20 > From u-boot-spl.map: >=20 > .end > *(.__end) > 0x00000000009121a4 _image_binary_end =3D . >=20 > Fixes: 77aed22b48ab ("spl: spl_legacy: Add extra address checks") > Reported-by: Francesco Dolcini > Signed-off-by: Fabio Estevam > --- > Tom, >=20 > As 2023.07 is coming in a few days, maybe it is safer to revert 77aed22b4= 8ab > in master and then squash 77aed22b48ab + this fix to next. >=20 > 77aed22b48ab has been applied to 2023.07-rc5, which is too late in the cy= cle. I want to see what Marek says about which changes are the most critical for the security issue aspect of this and then figure out what's next. --=20 Tom --9LRIuB/0ksvq/MZQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmSe88EACgkQFHw5/5Y0 tyxxbAwAkTirxkmje2Mk7v6269+tkJUnpPtFr3NMAwCmSfw81OUR1Ys6Su2osYtL cHzEf2KgHgflpIDj/6aFLUVWbHf2QNzTeMLEgZ9ZBtftRaMitdzwOlIMH41RsMp1 X9nfxYlQXMx9HxN0bCcyXuwiRfarx9UrbB8DjnkUUUCHzscuZybl5h68et4YnbQL iW/eGs3pXz2wDGxM3YS33aUIe/njJ6t9O7gG++G3+bDd96WObZuYbUaeoj57L0wc lmDpdbi5/y6M8CzeTtDY0Uuq3gYK65OG25a7idv4zPVg233DeGBXDk0mrneKoNRt e9zLSN/FQqvO/fpvK3MGky8koTXpy8W/pirzYW5T613e5/RLYRewTKaZuKQknW7l jRvDpn3ITxIY0K/+H1fzNDf4j45z40E6WBFrwiL8+oaBkpdosPmsw1Nt5K/InRND WdaGkdgLCjmoWwPrcXYqplyh+W1i/Irg7UvZ0XvSJFsdAnKJEM1/UtByRmA6etSC 9VKcP6Er =MNaw -----END PGP SIGNATURE----- --9LRIuB/0ksvq/MZQ--