Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26BC9EB64D7 for ; Fri, 30 Jun 2023 19:11:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 723D18686D; Fri, 30 Jun 2023 21:11:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="jYJSI5A6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 064C1846AF; Fri, 30 Jun 2023 21:11:46 +0200 (CEST) Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 317D3846AF for ; Fri, 30 Jun 2023 21:11:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-5701e8f2b79so24793177b3.0 for ; Fri, 30 Jun 2023 12:11:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1688152300; x=1690744300; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CV0M0g32YrczaOZ6/lMlTyy2v2NksGb23N2BsAgQV2s=; b=jYJSI5A6UK8hSvGtiqQmnf0dHJA8S2JwtCnTiGg3cV+tFep48p9Zi/WpekraxAIJ5n PQrYkujOAg7XTkao+NbzXkhpXys6iIpz5HME8OHiNi8wmsCOXco3Oz5YQoEj5cXxuub6 wVrilnkVBRkKJIvd13HiUpLRoZE03EITU4LoA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688152300; x=1690744300; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CV0M0g32YrczaOZ6/lMlTyy2v2NksGb23N2BsAgQV2s=; b=i/LNnziQ5TbXvbFFKaNwfwylZJepaon7AV4pVz8SScj+qPFOQg8rxkvHw3qO9s4+WA NV1wvDrX9ClFcrfoER6voAr/uvjktoIKXyFtf7EjlN6KE2Y20Smoao/2ClD9elnDln94 Qzom50cJ1SeCXwbRTN/2Z9BTFzSyRFAjvcAWC9AfQOLe3OMXYCy8vPewEDQ4qtUZcelr 5RPK+Z6rzf59/5hrY+mGsKycVrdrHWBx186DVu+vAcBy5bSAXNPHwiITIhwR3y5lEbKU yS9riSfU9RPn18b/3VCfCB74VCEO8piFAPDl2tlMJn8hpu8CKSZL6zOmVbrpdGwVuqbf 2/vQ== X-Gm-Message-State: ABy/qLYYDaIHUyRm0oflOVwqLm/cJyTI547J5QYgxiXrTasQ87uncbe+ YjxK6IpzhLlypo6QT/TONuLNbQ== X-Google-Smtp-Source: APBJJlEg+IJ98Qa0jz1WgU3U5kWKmUYWFEWujpxwpCX9tm1xkJB3tVszgi7ty9qh8aJ4QfU+9ocObg== X-Received: by 2002:a81:848c:0:b0:56f:e973:a7 with SMTP id u134-20020a81848c000000b0056fe97300a7mr3589010ywf.3.1688152300696; Fri, 30 Jun 2023 12:11:40 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-1dc5-0846-cf6b-8ae6.res6.spectrum.com. [2603:6081:7b00:6400:1dc5:846:cf6b:8ae6]) by smtp.gmail.com with ESMTPSA id g2-20020a0ddd02000000b005772154dddbsm1113304ywe.24.2023.06.30.12.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 12:11:40 -0700 (PDT) Date: Fri, 30 Jun 2023 15:11:38 -0400 From: Tom Rini To: Fabio Estevam Cc: marex@denx.de, u-boot@lists.denx.de, francesco.dolcini@toradex.com, Fabio Estevam Subject: Re: [PATCH] spl: spl_legacy: Fix spl_end address Message-ID: <20230630191138.GP3931582@bill-the-cat> References: <20230630142311.435336-1-festevam@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="si6AF+zumrLXXvn9" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --si6AF+zumrLXXvn9 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 30, 2023 at 04:08:42PM -0300, Fabio Estevam wrote: > On Fri, Jun 30, 2023 at 3:36=E2=80=AFPM Fabio Estevam wrote: >=20 > > I tested this with CONFIG_SPL_SEPARATE_BSS=3Dn and it failed. >=20 > Tested this one with CONFIG_SPL_SEPARATE_BSS enabled and disabled: >=20 > --- a/common/spl/spl_legacy.c > +++ b/common/spl/spl_legacy.c > @@ -18,9 +18,17 @@ >=20 > static void spl_parse_legacy_validate(uintptr_t start, uintptr_t size) > { > - uintptr_t spl_start =3D (uintptr_t)_start; > - uintptr_t spl_end =3D (uintptr_t)__bss_end; > uintptr_t end =3D start + size; > + uintptr_t spl_start; > + uintptr_t spl_end; > + > + if (IS_ENABLED(CONFIG_SPL_SEPARATE_BSS)) { > + spl_start =3D (uintptr_t)_start; > + spl_end =3D (uintptr_t)_image_binary_end; > + } else { > + spl_start =3D (uintptr_t)__bss_start; > + spl_end =3D (uintptr_t)__bss_end; > + } >=20 > Does it look okay? Probably? But have you thrown this at CI, or a world build? --=20 Tom --si6AF+zumrLXXvn9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmSfKOMACgkQFHw5/5Y0 tyyKbAv+OWfizTspY6BvCMeIV9UtRb0XRWstKTRUTrzhuk3WmJu5OTW8egvSHr5s +Jkw/7MR1490S8BsDIMsMYra4UOPaUojEC8W52vMB5rpeQHL6Sq4GRmrRPllxODp 8ACUssswErtvGxABArBMjLLWVsVsqNmwDMJVBPAeuqA78jSrpup83c+IROR2lDx8 R/O5xFY7eUwxUd0gbsOF5fBJIe6JeZ2DJDfivSQnQoj8mqLSI8qDSsgcQAMcTKKY pQUl8jq3eZv9+3+M3YClf+J66oqASLq7lqADhxFGHRNE1ck71UQi8Mw1W2GLXL1e SpKWZxaXVVgosDjVhWA7InjElgNQc7/jy3JEzO0VrwHNRxf48kwuMDSv3JnIOpir 4ZUHZ6MHQfvXuKjh15HlkubxsGiEYmgjTl+StHfoeOMc0Pq/tkgAooNpCG3efBMZ kxNfw2ILCO8uMXDK8o/0tVnn4qamsE0uLJHdZ+UbZbFvYo6xHLB99wwbQ0rPTLhC zW32GBA/ =CmHy -----END PGP SIGNATURE----- --si6AF+zumrLXXvn9--