Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1616DEB64DA for ; Fri, 30 Jun 2023 23:13:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3D45584701; Sat, 1 Jul 2023 01:13:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="D8B1GPdn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CDC418469C; Sat, 1 Jul 2023 01:13:42 +0200 (CEST) Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F1D9A8545F for ; Sat, 1 Jul 2023 01:13:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-57026f4bccaso26960287b3.2 for ; Fri, 30 Jun 2023 16:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1688166816; x=1690758816; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iEEuCUT3+a6lLHbl53I9+suJJbYfpOzycoSPDkJmXDc=; b=D8B1GPdnbXMOeBemuzHOhvsgHGbaaJ1fbBahk/t6UtRWv3ry2kQTo1STdOk1tBuq33 8VW/o1yGId6rBTAXKUPG67Vtr97yXePC4Hx3eTZmhboq3aMBIHJ8pvF71IhopGKn8AY6 ZxiCFSpb6QmPZCHysQRjT4vm0wzNX/Y1p38DQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688166816; x=1690758816; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iEEuCUT3+a6lLHbl53I9+suJJbYfpOzycoSPDkJmXDc=; b=jFc4ZvqBvYHkX2bX12wfSfzQ2ad/Gd9+h2wv6S25uegWHxWKo9+2r0qJIEZOftknzB PpcYRwocxP0/K93cpvTI66srjYO7j31NyndRkr7HNPAbdaTEum/ePEGKKP7OYmfvRshA nkJtT/l3a9lg6nSre0lYYn63Q+IGtkmR+Su6k0cdQVuF3tBsOH27kBndvz38Dj/3wPMg vY+eR5uBjVdFE94DA4y7mGzo5LZoskB7QmI9hU0phqM1XSZs/ROrr7WO14Xt3+b7b0d/ M0NGJ1PlqIz1Ow2F4POLe+ql+yx0cfVZWf8GvEmwUGU2qm8YN1nHhn4W3p9M9t9qPLUI b5Vw== X-Gm-Message-State: ABy/qLZYtcTIi1WjzwDrxEFWVE9niCjFlIXK4XZolEfnDP7naKMcBshQ 7O9qmVimifTXtKFm78HVLXiZZQ== X-Google-Smtp-Source: APBJJlGb6bQFo89Jm+ieTsVL/77FtIkMKiJYUD7zQefAxgrTf5L9hez+z81rzF+C9jepgd+v2MG2pg== X-Received: by 2002:a81:4a05:0:b0:56d:2d59:dc30 with SMTP id x5-20020a814a05000000b0056d2d59dc30mr4063426ywa.24.1688166816562; Fri, 30 Jun 2023 16:13:36 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-1dc5-0846-cf6b-8ae6.res6.spectrum.com. [2603:6081:7b00:6400:1dc5:846:cf6b:8ae6]) by smtp.gmail.com with ESMTPSA id y127-20020a818885000000b00576cd8f9770sm2662848ywf.146.2023.06.30.16.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 16:13:36 -0700 (PDT) Date: Fri, 30 Jun 2023 19:13:34 -0400 From: Tom Rini To: Fabio Estevam Cc: marex@denx.de, u-boot@lists.denx.de, francesco.dolcini@toradex.com, Fabio Estevam Subject: Re: [PATCH] spl: spl_legacy: Fix spl_end address Message-ID: <20230630231334.GR3931582@bill-the-cat> References: <20230630142311.435336-1-festevam@gmail.com> <20230630191138.GP3931582@bill-the-cat> <20230630210419.GQ3931582@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tPZBrnLRz7PQE9Te" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --tPZBrnLRz7PQE9Te Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 30, 2023 at 08:12:36PM -0300, Fabio Estevam wrote: > On Fri, Jun 30, 2023 at 6:04=E2=80=AFPM Tom Rini wro= te: >=20 > > Yeah, just hit re-run when that happens, sadly. >=20 > Ok, only sunxi failed. >=20 > If I try: >=20 > --- a/arch/arm/cpu/arm926ejs/sunxi/u-boot-spl.lds > +++ b/arch/arm/cpu/arm926ejs/sunxi/u-boot-spl.lds > @@ -37,6 +37,8 @@ SECTIONS > __image_copy_end =3D .; > _end =3D .; >=20 > + _image_binary_end =3D .; > + > .bss : > { > . =3D ALIGN(4); > diff --git a/arch/arm/cpu/armv7/sunxi/u-boot-spl.lds > b/arch/arm/cpu/armv7/sunxi/u-boot-spl.lds > index 306a4ddf3cd2..0787dfff8fb7 100644 > --- a/arch/arm/cpu/armv7/sunxi/u-boot-spl.lds > +++ b/arch/arm/cpu/armv7/sunxi/u-boot-spl.lds > @@ -46,6 +46,8 @@ SECTIONS > __image_copy_end =3D .; > _end =3D .; >=20 > + _image_binary_end =3D .; > + > .bss : > { > . =3D ALIGN(4); >=20 > Then it builds fine. >=20 > I am thinking of sending the sunxi lds change as part of a series in v2. >=20 > So v2 would become: >=20 > 1/2: the sunxi lds change above >=20 > 2/2 the original patch: >=20 > --- a/common/spl/spl_legacy.c > +++ b/common/spl/spl_legacy.c > @@ -19,7 +19,7 @@ > static void spl_parse_legacy_validate(uintptr_t start, uintptr_t size) > { > uintptr_t spl_start =3D (uintptr_t)_start; > - uintptr_t spl_end =3D (uintptr_t)__bss_end; > + uintptr_t spl_end =3D (uintptr_t)_image_binary_end; > uintptr_t end =3D start + size; Sounds good. --=20 Tom --tPZBrnLRz7PQE9Te Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmSfYZsACgkQFHw5/5Y0 tyxX+wv/UWFgqYxmTKwb7D8UWLkNCqUx21LADJCmqaBMI56sSJcQiLfQ7CJHGHUY eAFyx+CUwGZCeX9eNCS6OmsSys3zUnkBUgKgIweshCApWmNVnV8yz2aaaF8POSvA u8qkBkD9SLY32Hj/caaYRirtMeRZoCLlX5aTDLM52SiQHBNI+DO8jE9BKVG1iPwY A2OKWDLPKwUm+tpCah79zUVqtxfJFxJynVlesaB1fZ30rebZA2vpghtfPH4MQJOC XGUYpmqVlhassz8/XMg06/SiIWIIjEVoFLshhhHEhQ91pdnqbLh+ZeFjHVQzMTGF PhqKBCCakPyffXB+ttR9T+KdISt+M2wD40IGZPTgPLxpUpepmN3c3Z94XXpFxJqd l+t+g4j0QcrSZr2warctI35I1B4lIKmxqYcTXzDJ8znyBJRhhYBvbQ3jX55dv/Bv VVbFzN5rPLv/mjQ4ukO06R2Dh+JycVxztduBW04ZuVS9tXF+GlMg5mPXj7mOOhlJ YvyK0hR6 =dnMX -----END PGP SIGNATURE----- --tPZBrnLRz7PQE9Te--