Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50517EB64DA for ; Wed, 5 Jul 2023 15:36:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3523B862A8; Wed, 5 Jul 2023 17:35:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="uH6Bq4b6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8098886205; Wed, 5 Jul 2023 17:35:56 +0200 (CEST) Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C125F86264 for ; Wed, 5 Jul 2023 17:35:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb2c.google.com with SMTP id 3f1490d57ef6-bd77424c886so8069783276.0 for ; Wed, 05 Jul 2023 08:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1688571352; x=1691163352; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=G1J2Z1P0Kw+GL5+F0CXcsvrvWcmtPZ0cEXRRHkjE5Y0=; b=uH6Bq4b6Rc+g9PZSfMRnnW821DtaDhAxY4HPu7DuTJYJg+0QhucOAv4673s2UUOX4f DS7RNY9jhjz6tlp2/somz601yxhDiimu5TNpiOhmAx12TAEQSI8o9NR2f7hTnq5aAATs JAhxZQk3ipTrTgX09MUS2h2KJ0bOnr2OJAV20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688571352; x=1691163352; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G1J2Z1P0Kw+GL5+F0CXcsvrvWcmtPZ0cEXRRHkjE5Y0=; b=eBC/QMREdxHESxFBARfeMdoQEPR7PMWWZAsP20ySxfLiyPaXxPAKSvEEIYFdttaFxM k3SfH5ohNNjTHmCa6e290UMIYj30qnRr7ZjXyiTC6BlyL5aSyYgU83U6Z8PV1lNmeV7L nY0kUnOHBZI9AvXR8cfT7vUUeTLsIVDI9urWDIv8A2KtqbLCs0jyHH5Drpz21ehG1swL 9qN7FiWDtPFVO52+2Tm+3FtvWkcFR8efzoZLAX848V/Ec/yEvZHHCNX2w4y0TZT8Z4Eu SIEJlRmCF24vd/PG8u3KMo2EI0YZy8C7EyCQl77hwUOJWjB0+aR2JtJm4gGi8ALjhue1 HK+Q== X-Gm-Message-State: ABy/qLYkHAZxsqcOOZzO31vo/nPdxibOnP0BC6FGeeXDLkc3EnNzZw1U w5b4IBSVGM/F+BKyqxzPeGRaqfrtTonxpC5v4gWKnA== X-Google-Smtp-Source: APBJJlEbdy6xzuQYGeN1CfNgsqB9iI8q4sX0/viAbNxaRaqUdsDpWNccTY85165aP4YIyWJxF+TiEA== X-Received: by 2002:a25:7d83:0:b0:bff:d659:1b3f with SMTP id y125-20020a257d83000000b00bffd6591b3fmr17270260ybc.51.1688571352489; Wed, 05 Jul 2023 08:35:52 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-8ba1-0159-c56f-2ec5.res6.spectrum.com. [2603:6081:7b00:6400:8ba1:159:c56f:2ec5]) by smtp.gmail.com with ESMTPSA id e7-20020a256907000000b00c65cfcace05sm86650ybc.42.2023.07.05.08.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 08:35:52 -0700 (PDT) Date: Wed, 5 Jul 2023 11:35:50 -0400 From: Tom Rini To: Fabio Estevam Cc: Francesco Dolcini , Fabio Estevam , Simon Glass , Marek Vasut , u-boot@lists.denx.de, Marcel Ziswiler Subject: Re: v2023.07-rc5 regression: Image overlaps SPL Message-ID: <20230705153550.GO3931582@bill-the-cat> References: <37cfa797-eea6-2f20-16a4-7a44a075d760@denx.de> <20230703200115.GD3931582@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HxdQFXEJ/6So2162" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --HxdQFXEJ/6So2162 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 04, 2023 at 02:13:01PM -0300, Fabio Estevam wrote: > On 04/07/2023 14:04, Francesco Dolcini wrote: >=20 > > The boards that do not check the return value might start to behave > > wrongly without an obvious error to help the debugging. >=20 > Yes, the current implementation of fdt_status_disabled() is fragile, but > there's not so much we can do for the upcoming 2023.07. >=20 > I can try to prepare a patch to improve it after 2023.07 is out next week. It's also been fragile-as-designed since inception. The trigger here was that renaming a ton of properties _reduced_ the overall dtb size itself and so some edge cases got pushed over the edge. I'm honestly not sure if it's better to: - Give everyone a small padding by default - Make the platforms which may call one of these functions a small padding by default - Audit the callers and make them handle -FDT_ERR_NOSPACE like the other cases where we grow the dtb size do. Even if yes, many of those other cases are for non-trivial growth rather than just adding 4 more letters. - Make fdt_set_node_status() handle the disabled case when out of space and grow/retry. --=20 Tom --HxdQFXEJ/6So2162 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmSljdMACgkQFHw5/5Y0 tyz9ygwArnRl8uiYwk/stu2br4BiRAbX5cwBWS0AjuCw8azvcdhEAhTBToorbKHz G5m+OrmyGAhzaSe+MlPsKcq1GBcD7v637UIHw+ekhC4St0Bu5Zlyoo92iEWUCLfT NuGd5BSSQgb1+PM+fg8Ugz5XZTRO6yNgI2mbD0D1duAT9TvDJdycPDb4gXTnUoud elKY+m4uwEfspYLc/OMopysDcDOt/RVbqsQ5bc1afgrSNF1ha8Sf+V3x7YzWAT6y mQ1/6xjNc0WRpk3whj6EjYpXS7zvEpNE+jrnRYu9C9Tcx7e+aVtWjEJ5n9R6Z8cL 56RkAvJygiXijMV8/fLNrdzIRTJqjQze/CpAcG2uya+WCGFkcRzCYvoA+pJOdUnn zWOay67FOW9T3koovOL8CLMSWsfI/JRpKowCJvYvtHnozW5Isl1n7in9b4Zb2r42 /SVNNy5PxUYbf4Cd5n0ysm5I6x38sCtnKAGAjvW04MY0N2xUHz+Lf5dXCzKLeJIC 6ba4mG2w =7rXi -----END PGP SIGNATURE----- --HxdQFXEJ/6So2162--