Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53E6914AB5 for ; Tue, 11 Jul 2023 14:12:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3ED1CC433C7; Tue, 11 Jul 2023 14:12:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689084729; bh=NRBCd7EYg1Ttg7Sd52hrW/FKaUnozUqBArGH46pm5Hs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dv3ZPcOrttwlRQ7ym+XMaMprZg4jGyXAIcnMCZRSQeRCMr+rPOx+AR2x6FEX+gXnQ JsZ9nzbfIpxOMv7EyoXY5LJgHFl8NMwBFdr6qI/rnUm22VqNc+CWNgEThskgCZR0JZ 9XOm7XCRs+H/vlnlGMQ5Vg0k9wAffpQtZ8WSlAYw= Date: Tue, 11 Jul 2023 16:12:06 +0200 From: Greg KH To: Sagi Grimberg Cc: Christoph Hellwig , Linux regressions mailing list , Pankaj Raghav , Keith Busch , Bagas Sanjaya , Jens Axboe , "Clemens S." , Martin Belanger , Chaitanya Kulkarni , John Meneghini , Hannes Reinecke , Linux Kernel Mailing List , Linux NVMe , Kanchan Joshi , Javier Gonzalez , =?utf-8?B?67CV7KeE7ZmY?= , Linus Torvalds Subject: Re: Fwd: Need NVME QUIRK BOGUS for SAMSUNG MZ1WV480HCGL-000MV (Samsung SM-953 Datacenter SSD) Message-ID: <2023071135-opt-choosing-51dd@gregkh> References: <6f333133-2cc4-406a-d6c2-642ac6ccabca@leemhuis.info> <462e0e1e-98ea-0f3c-4aaa-8d44f0a8e664@leemhuis.info> <20230711120609.GB27050@lst.de> <23017407-83eb-8fb0-5d91-2c7c4ae02544@grimberg.me> Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23017407-83eb-8fb0-5d91-2c7c4ae02544@grimberg.me> On Tue, Jul 11, 2023 at 03:14:54PM +0300, Sagi Grimberg wrote: > > > > Well, that "They keep pumping out more and more devices with the same > > > breakage" and the "new device" comment from Pankaj below bear the > > > question: should we stop trying to play "whack a mole" with all those > > > quirk entries and handle devices with duplicate ids just like Windows does? > > > > As far as I can tell Windows completely ignores the IDs. Which, looking > > back, I'd love to be able to do as well, but they are already used > > by udev for the /dev/disk/by-id/ links. Those are usually not used > > on desktop systems, as they use the file system labels and UUIDs, but > > that doesn't work for non-file system uses. > > > > And all this has been working really well with the good old enterprise > > SSDs, it's just that the cheap consumer devices keep fucking it up. > > > > If we'd take it away now we'd break existing users, which puts us between > > a rock and a hard place. > > Maybe the compromise would be to add a modparam that tells the driver > to ignore it altogether (like allow_bogus_identifiers) that would > default to false. Then people can just workaround the problem instead > of having the back-and-fourth with the vendor? > Module parameters do not work on a per-device basis, sorry. This isn't the 1990's anymore, please do not attempt to add new ones :) thanks, greg k-h