Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB701EB64DA for ; Thu, 13 Jul 2023 03:04:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9904B86AE5; Thu, 13 Jul 2023 05:04:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="mampVGZ1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 193A486AEA; Thu, 13 Jul 2023 05:04:10 +0200 (CEST) Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 497F586AD7 for ; Thu, 13 Jul 2023 05:04:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-cabf1dbafc4so167132276.2 for ; Wed, 12 Jul 2023 20:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1689217446; x=1691809446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YmrCEZ+F5JVBAbAbVgkijIJ9qqAEq4cH1ciQ7AXNC34=; b=mampVGZ1yImJo0KOJe4aZyM0AJVYXwdTSS8IpynF7mFq43ktQgl1Lgag7bfVPqLCRy 3afd78RG5G3OI6n/D0JIJd3djlik4N8s3NihCsQxjZvUIh8lY8DK/YkFTCfdgKGyMr8c PCwRq5we7X8ZDl/m7B2W7b257Eihsnc2GzoLw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689217446; x=1691809446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YmrCEZ+F5JVBAbAbVgkijIJ9qqAEq4cH1ciQ7AXNC34=; b=V9R32CMF+rcvNxlP3AT+ZIeEkod5K1B+ZnZuZT6FXT7CTWK/0e3bkZ0NXpTpFE+YTh MnqJjiKfd0LMmD1jhDDXJvBAx++ewA88IaFRVi/5GmxudWMAgwrvMYnN0DJ+01oPVLpV ABUhIkMXDI4MVKCmrILceuCD94nw38Zfxq2ExNWuHdn0D1SRmVeTP3cK3wt/B7et5gUb GYL7wC270Q3qKlWUe/eIhqFNuTgf9Epkm3CCpRDF0g0PZprDZ0MEJbcLUt5ik8uI+u4B 1532pBO0QqMhjD0RssY5kGrbKOIzNt8aOxzigabK1ZD3CJ8OckaOWsVTiEvY1k+TzUEM /u+Q== X-Gm-Message-State: ABy/qLaCLlI2Rp5AhzLWd0UafdLoswr2KHm+e4JO2emS0qvHtKCvmfNd IVyWDck6Wis66BCbM8mlC304mnhOSntZQPQQfCJ7tw== X-Google-Smtp-Source: APBJJlFs5mvOWJTt0g+CfwAeGiKO0zKZiY6v2v3XZjy7q7/80JPJ8euh3N1zTvtHlFJOqBEtr/zATA== X-Received: by 2002:a81:6609:0:b0:561:d1b0:3f7e with SMTP id a9-20020a816609000000b00561d1b03f7emr568862ywc.44.1689217445745; Wed, 12 Jul 2023 20:04:05 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-cb70-e592-de93-e6d2.res6.spectrum.com. [2603:6081:7b00:6400:cb70:e592:de93:e6d2]) by smtp.gmail.com with ESMTPSA id i65-20020a819144000000b0057072e7fa77sm1539720ywg.95.2023.07.12.20.04.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 20:04:04 -0700 (PDT) Date: Wed, 12 Jul 2023 23:04:02 -0400 From: Tom Rini To: Bin Meng Cc: u-boot@lists.denx.de Subject: Re: [PATCH 1/2] CI: Update to QEMU 8.0.3 Message-ID: <20230713030402.GL2066889@bill-the-cat> References: <20230713020415.441563-1-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nYcIsJT9tmkosCAx" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --nYcIsJT9tmkosCAx Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 13, 2023 at 10:51:15AM +0800, Bin Meng wrote: > On Thu, Jul 13, 2023 at 10:04=E2=80=AFAM Tom Rini wr= ote: > > > > Move up to the latest tagged release of QEMU >=20 > I have the same patch in my local tree :) >=20 > > > > Signed-off-by: Tom Rini > > --- > > tools/docker/Dockerfile | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile > > index aa54e2689fb5..733099684be6 100644 > > --- a/tools/docker/Dockerfile > > +++ b/tools/docker/Dockerfile > > @@ -77,6 +77,7 @@ RUN apt-get update && apt-get install -y \ > > libsdl1.2-dev \ > > libsdl2-dev \ > > libseccomp-dev \ > > + libslirp-dev \ > > libssl-dev \ > > libtool \ > > libudev-dev \ > > @@ -175,13 +176,11 @@ RUN git clone git://git.savannah.gnu.org/grub.git= /tmp/grub && \ > > > > RUN git clone https://gitlab.com/qemu-project/qemu.git /tmp/qemu && \ > > cd /tmp/qemu && \ > > - git checkout v6.1.0 && \ > > + git checkout v8.0.3 && \ > > # config user.name and user.email to make 'git am' happy > > git config user.name u-boot && \ > > git config user.email u-boot@denx.de && \ > > - # manually apply the bug fix for QEMU 6.1.0 Xilinx Zynq UART em= ulation codes > > - wget -O - http://patchwork.ozlabs.org/project/qemu-devel/patch/= 20210823020813.25192-2-bmeng.cn@gmail.com/mbox/ | git am && \ > > - ./configure --prefix=3D/opt/qemu --target-list=3D"aarch64-softm= mu,arm-softmmu,i386-softmmu,m68k-softmmu,mips-softmmu,mips64-softmmu,mips64= el-softmmu,mipsel-softmmu,ppc-softmmu,riscv32-softmmu,riscv64-softmmu,sh4-s= oftmmu,x86_64-softmmu,xtensa-softmmu" && \ > > + ./configure --prefix=3D/opt/qemu --target-list=3D"aarch64-softm= mu,arm-softmmu,i386-softmmu,m68k-softmmu,mips-softmmu,mips64-softmmu,mips64= el-softmmu,mipsel-softmmu,ppc-softmmu,riscv32-softmmu,riscv64-softmmu,sh4-s= oftmmu,x86_64-softmmu,xtensa-softmmu" --enable-slirp && \ >=20 > --enable-slirp is not necessary as libslirp-dev is installed as a > dependency which will be automatically figured out I thought about it, and I first tripped in to "no libslirp, no user netdev, CI fails". I then spelled out we need the library and configure failed, and then ah, right, we need libslirp-dev installed. So I was thinking about being explicit about this flag as we specify the user netdev in a number of cases and this means if something changes in the future we'll get a failure here, rather than later on when testing the image. Does that make sense? Or do you still think I should drop the flag here? --=20 Tom --nYcIsJT9tmkosCAx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmSvaZ8ACgkQFHw5/5Y0 tyzs0QwAtiyoOFJCUfpnZEWWCLA4bBo0yjJysltvPfFT52NzX7LOHZ2h2okJ40Qn mzPcdNoEztFo6s2zx+swHoFZB720wM0JTO05Q/y6Xss0sl4DvA5FjyeeEGE22Rsj mRp+Knb2H/3sypLdiWTtxrJJctGPV18pvkM9hrTA87N9I86H51r9Di9GCN2lKbwq cEyll1k17p8DFtgq5L+OxMfLpdawafMcWkTMHKvHQukpI6OL6aR4B3GrFxFIHz4N b2F3o7HZ03wkHYnfufLeyOmZfLVpMLUArfyHMDkcUL4TbnaF+148JYlTVAsA49sY YiCpwV8yGeQzw6iwuQLyvxYTFxG3RYD2NnjPMvqcUbgm6vPGNiJ9x0psJcICPW61 rUq7PdtFNQBGp+wPkOKO2Nxy/0VoxASradddxqCbzvJx9wjUKxAzg2O96Y5FbgUE kGG3A3ZZmF+f4YcLv38EV+7vMNLTQ8Wv6BmJh+n+LjdK9MH8VH2Mjx5btGKdU5hb OIkybLyn =4RLu -----END PGP SIGNATURE----- --nYcIsJT9tmkosCAx--