Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5975AEB64DC for ; Fri, 14 Jul 2023 14:48:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED5AD8D000E; Fri, 14 Jul 2023 10:48:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5C758D0005; Fri, 14 Jul 2023 10:48:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFDC58D000E; Fri, 14 Jul 2023 10:48:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BBADD8D0005 for ; Fri, 14 Jul 2023 10:48:04 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 62E7C1602B2 for ; Fri, 14 Jul 2023 14:48:04 +0000 (UTC) X-FDA: 81010497288.02.8B1AC67 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf05.hostedemail.com (Postfix) with ESMTP id 2BD0B10001B for ; Fri, 14 Jul 2023 14:48:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=WZYk4jxa; dmarc=none; spf=none (imf05.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689346082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=njTLHLFMh16HuHE6NvqX3Yjrmk8yNTzTQKCOyHUveJs=; b=cSocz2WWETXomlwOUMGDt/CJICuYWp85qdp7DWfmHcCczzVJKqZ+V0Xho7wptZl4YC6bkq NdAk1SYT+pUtHPNaZWXQ/q9qfcPZCycDKWo4TmNfCh+j6gstKisv03Ysv4C0MXBHbp95V6 bs9qSPZ7hKVGFc1+dB/GsGv4M3QGR9c= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=WZYk4jxa; dmarc=none; spf=none (imf05.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689346082; a=rsa-sha256; cv=none; b=svSdgMFsYZJdjx97MUod7lc5d6SZoVg6YUl9wBR48oEFLEOy+nX7bBdkh9UxAVej7YhD6z kAVpKWG8SkYC/ZirO6l8k6vcj++stTj1/aqAgIht8+wfZyL3kN+3HR+YaDqFzyWlMvioYg eaqYUONk4RihkC+Xu5IfDNHjTEFX4bM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=njTLHLFMh16HuHE6NvqX3Yjrmk8yNTzTQKCOyHUveJs=; b=WZYk4jxaFlnChcvddb0bl2o/as xkSs+mNy8/ZsEWQhsbL0TVjICEaLcZIVyHbJOqK4v9MskwnDo/Mzay+QctqXTWBD1JqUmBM1TYEas B8kItNsA2ZcQ+/ThLZqrtLu4b1Kw37BQo50qAh2QDK0KMODZ6xWrRJ/nYSMuNqhvA0oKdXDm5k7wv F7VAGnV9cuJub90tZH8EXoE7I/MZ+Ei7W+djkMs4XEhT6bsd0/hSrcYTlfXNDVH5pKaSFFwVNEzrs QhCfu3gEXGnjOCfmXegxdbtMbLPEp/4SLHPuXl3PTfsnckUSMJKfd2lPDA0+LNFf7wmVY808dcM8p CmySDnkA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qKK5G-006J0O-1m; Fri, 14 Jul 2023 14:47:50 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 542A53001E7; Fri, 14 Jul 2023 16:47:49 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 3AEB8213728A5; Fri, 14 Jul 2023 16:47:49 +0200 (CEST) Date: Fri, 14 Jul 2023 16:47:49 +0200 From: Peter Zijlstra To: Arnd Bergmann Cc: Thomas Gleixner , Jens Axboe , linux-kernel@vger.kernel.org, Ingo Molnar , Darren Hart , dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, Christoph Hellwig , Lorenzo Stoakes , linux-api@vger.kernel.org, linux-mm@kvack.org, Linux-Arch , malteskarupke@web.de Subject: Re: [RFC][PATCH 04/10] futex: Add sys_futex_wake() Message-ID: <20230714144749.GA3261758@hirez.programming.kicks-ass.net> References: <20230714133859.305719029@infradead.org> <20230714141218.879715585@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: 1def6kce11uj8mma9ryathcshyiys7pe X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2BD0B10001B X-HE-Tag: 1689346081-451075 X-HE-Meta: U2FsdGVkX191SHdu00CSN8/586SPjlftebioiuoabvkp7gJ6yb8GTgrAUhBni6zV2tjugRxZ4kWr9UfTtBdNleQpl1VtQkYS0weretOn81Q7hfHgubRhQQlEBh4mLkzs3ceaUjUrsZZmV85Lij8ejrdv3+/oYx0z6jhLUqMfn0AmQEuQrzliZBGWksEaEpmmyHpgdW4xJuwi9/V7uZQmw33KKK8a9Ip7NonVnI09PPh7rXIqXfR11DW6fPnYr9xVuTmLyqi8DBSCg+LB3A2ffF7n/QFOn9iOPJkbKyFmv72jqlB5Xepj1l1nz+XEOH8uK41huNvbTqAgZZva6yxH43wCPYymcfnyu0kXjSYtpjj7A2iTu8pVZ9V/lhhva15na/Bj2morfaWMRj5s3bHccEmSkZw3RvBv278AiwSab6OL9xC1LWPhOieNnrwlKB2aUKa6pIO1rLZFDBRbd1X3ol/G9YAZLsbf5TT1C+fpJv+3g7GJCpOj7wrhPojClS9ANGYmNIn1UYZZHaZ+IyoH9nFw2ysTz0+dCql5090LDYiSL7IM/AIJ9u7U23D0QDjPbDViwtzy6bAFA7myj/VH2J3bmX/BENZwEXmwj8sdnNMGR7N9YqY8+rKp7ZwXqEYCBqDiYahpcm4QjX177G1B5SVY6HAbFF30p7JOywGOWXK7C9pw2qZaDLSNgADkbOszYTH2dQlG0QrQ91/ruIivgQkMxJSW7b7K0b207lRIKedI3kxERO2ryt/9+ZZ2/xW3mHD6KCbA82f+hdTQ2C+7ka24inSFtunsmkR3eNcdCv/4Cgh3AOiaiEO3gcIQNDdiZ2EwMfJaQmCCh7XKQSculLhIyX+Y+N8TTYImVqAIRAZSSseUssLaMQlAYDc/P89q7ea3vfxZ4u0zcy8pv13e18FAJc93Hj41sZ6EHnKQDPq9jUhaRJahvG7Fl0d57fEVAddgoHJMJKJHFmK/4ZK v87qBXxV d0lGlKWH23fHZjIpNlqLySNMorke9mgAV/aKbGwt48fb3ObqMJDZeN5cu3e3rF7S4HpeTwGonZ6tQWrNN3lljRH18cbxSKZrEuE+WYVeh5t2ngeArtEvGALzQixa9jNgLsAvJV+Y5HOPr6wP+F186n5r+kf7o226naXkmIFm+nZx93ZzlFew/K8CRWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 14, 2023 at 04:26:45PM +0200, Arnd Bergmann wrote: > On Fri, Jul 14, 2023, at 15:39, Peter Zijlstra wrote: > > > > +++ b/include/linux/syscalls.h > > @@ -563,6 +563,9 @@ asmlinkage long sys_set_robust_list(stru > > asmlinkage long sys_futex_waitv(struct futex_waitv *waiters, > > unsigned int nr_futexes, unsigned int flags, > > struct __kernel_timespec __user *timeout, clockid_t clockid); > > + > > +asmlinkage long sys_futex_wake(void __user *uaddr, int nr, unsigned > > int flags, u64 mask); > > + > > You can't really use 'u64' arguments in portable syscalls, it causes > a couple of problems, both with defining the user space wrappers, > and with compat mode. > > Variants that would work include: > > - using 'unsigned long' instead of 'u64' > - passing 'mask' by reference, as in splice() > - passing the mask in two u32-bit arguments like in llseek() > > Not sure if any of the above work for you. Durr, I was hoping they'd use register pairs, but yeah I can see how that would be very hard to do in generic code. Hurmph.. using 2 u32s is unfortunate on 64bit, while unsigned long would limit 64bit futexes to 64bit machines (perhaps not too bad). Using unsigned long would help with the futex_wait() thing as well. I'll ponder things a bit. Obviously I only did build x86_64 ;-)