Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9683C001DF for ; Sat, 15 Jul 2023 15:03:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 814CB861D4; Sat, 15 Jul 2023 17:03:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="l56Qir9I"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 200FC861A1; Sat, 15 Jul 2023 17:03:13 +0200 (CEST) Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CC51F846BA for ; Sat, 15 Jul 2023 17:03:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-1b45fe36cd9so1827167fac.2 for ; Sat, 15 Jul 2023 08:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1689433389; x=1692025389; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UtEkMc/MGhCMmpBhg97U36+rAxlLRdm08lw48SWX0xM=; b=l56Qir9IXfa/RWE/bN91rJX5V69EWCnYsfjYnolcrkOSUrWgINEIiIFKdVje7/5uqE TJEGyZNsZN+Gune5GjE+a8WYsRxRlAbxijSP2Tj39KqgvatdKzYFhEQrJ+XlEbYYKDTZ ZFk/VawIuFJNSxlKKtxCoP3mSV/n+QnJ2wxKA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689433389; x=1692025389; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UtEkMc/MGhCMmpBhg97U36+rAxlLRdm08lw48SWX0xM=; b=X3TaO1jyJJIR3FBHakbsrOoj8doOttAgTm19eEe6QHBB9llw6YKLlR6P7OyksQlRWj OWhHwOj1UNjP56ARyQ8jBhVRdZ4nKcb8M//AEt8+E28ZWSuHam1RhnAuqfOpGRAgpIEp nQ0Lop2IzkSL8L4Hx8pSgYOggVj0S/PnntFsgBtK6S3VWgKNNSm82aKB0AafAIEHci6F fiHU5/uAbpFQ/LToqCZsHucngmlx8H1OLqRQXayarOb4N258yOEhVjt4xdHuY6wMJvGO jTH87GvNN8HRK33wxc4Vcv5rtQf6+q7nQOktd79GRqtneyrJ1sVpjT0ZzNIKuhSEF1Kl tkSg== X-Gm-Message-State: ABy/qLYBQVxFExV3XgLneN3WzcsD6afv0haFqY7F/bhnFNcLJnQH+Y4d q4kp7kPAk4I5gXvV0vJ7jNQBlLAawlS0SvXlg7e7cp/o X-Google-Smtp-Source: APBJJlGAL+5x0bq252v0nKTh86/dG4Yu9IkkRnNInTDBK9bbH+Vn8e1ph0Qpx7dFLRjNuJFxK7EfKA== X-Received: by 2002:a05:6870:c087:b0:18e:e0bc:829 with SMTP id c7-20020a056870c08700b0018ee0bc0829mr7834265oad.17.1689433389420; Sat, 15 Jul 2023 08:03:09 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-2ff3-b443-1227-0d00.res6.spectrum.com. [2603:6081:7b00:6400:2ff3:b443:1227:d00]) by smtp.gmail.com with ESMTPSA id p203-20020a815bd4000000b00579f1c5ebdasm2892921ywb.15.2023.07.15.08.03.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jul 2023 08:03:09 -0700 (PDT) Date: Sat, 15 Jul 2023 11:03:07 -0400 From: Tom Rini To: Sergei Antonov Cc: u-boot@lists.denx.de, Breno Lima Subject: Re: [PATCH] hash: fix a memory leak Message-ID: <20230715150307.GC2066889@bill-the-cat> References: <20230612195910.61772-1-saproj@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SdGDxzNKDFdxF5Gz" Content-Disposition: inline In-Reply-To: <20230612195910.61772-1-saproj@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --SdGDxzNKDFdxF5Gz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 12, 2023 at 10:59:10PM +0300, Sergei Antonov wrote: > memalign() returns a pointer which is to be freed by free(). To call > unmap_sysmem() is incorrect, furthermore it was called in a wrong scope. >=20 > Also add a check for allocation error. >=20 > Fixes: d7af2baa49c6 ("crypto/fsl: Fix HW accelerated hash commands") > Cc: Breno Lima > Signed-off-by: Sergei Antonov > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --SdGDxzNKDFdxF5Gz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmSytSsACgkQFHw5/5Y0 tyxMzAv/WcYL1Ffc6IcF7cxnBD+LCLwqrHUOH4RoYknxuFWdr41u/zcbaJAzZPUv pnQHQcIl8vTS46wdMxczQFy00lTJ0hUwHZvF3k2B0g+6yoKbBa5OCWyteDQ8Uy6k 3npgsbeCXo4C9NGray6MLfoL3SoVxRVAvUYWQA07fHBNnAXZe6pvsJQo5iunW/bS QcE+rktiISTVgkHKrJ7MPpsLurX0Z7BbHhs+kyDiDPqzxBQnRlHaEG//P6g1OEMI l/dls86T2cDwqT/qQ0l6tY3eE+GsXgJXwJgDjJqUO+xRQUrlJxEoAHoVFWTljMTO OV0WeDAIesg1vFySIeN/NBE0z7FzAb49yCnjexsWu03u3Z1xsDdb30PaCxH3NVzH ejIK4syXF0tkOvTvitSPk5R0t1fRyFWaTEgNRJFNxtrBvkarueYr+GaSJqrK/9nE MydZ/I7CyCR4QogTo/98CLC0xRl4cMHqb5aG+jbA6DSwhWGl/488/OtNLFbcJNGF gSwWQHaR =MpV4 -----END PGP SIGNATURE----- --SdGDxzNKDFdxF5Gz--